Skip to content

Commit 079309f

Browse files
bwilkersoncommit-bot@chromium.org
authored andcommitted
Create curly braces when resynthesizing map and set literals
Change-Id: I918624f0a07a02c98fdd2725a18fb3fd945eca8d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95664 Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Brian Wilkerson <[email protected]>
1 parent 68c9909 commit 079309f

File tree

3 files changed

+34
-21
lines changed

3 files changed

+34
-21
lines changed

pkg/analyzer/lib/src/summary/expr_builder.dart

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -877,7 +877,12 @@ class ExprBuilder {
877877
: typeArguments.arguments[0].type;
878878
staticType = resynthesizer.typeProvider.setType.instantiate([valueType]);
879879
}
880-
_push(AstTestFactory.setOrMapLiteral(Keyword.CONST, typeArguments, elements)
880+
_push(astFactory.setOrMapLiteral(
881+
constKeyword: TokenFactory.tokenFromKeyword(Keyword.CONST),
882+
typeArguments: typeArguments,
883+
leftBracket: TokenFactory.tokenFromType(TokenType.OPEN_CURLY_BRACKET),
884+
elements: elements,
885+
rightBracket: TokenFactory.tokenFromType(TokenType.CLOSE_CURLY_BRACKET))
881886
..staticType = staticType);
882887
}
883888

pkg/analyzer/test/src/summary/resynthesize_ast2_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright (c) 2019, the Dart project authors. Please see the AUTHORS file
1+
// Copyright (c) 2019, the Dart project authors. Please see the AUTHORS file
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

Lines changed: 27 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,37 @@
1-
// Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
1+
// Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

55
import 'package:test_reflective_loader/test_reflective_loader.dart';
66

7-
import 'expr_builder_test.dart' as expr_builder_test;
8-
import 'in_summary_source_test.dart' as in_summary_source_test;
9-
import 'linker_test.dart' as linker_test;
10-
import 'name_filter_test.dart' as name_filter_test;
11-
import 'package_bundle_reader_test.dart' as package_bundle_reader_test;
12-
import 'prelinker_test.dart' as prelinker_test;
13-
import 'resynthesize_ast_test.dart' as resynthesize_ast_test;
14-
import 'summarize_ast_strong_test.dart' as summarize_ast_strong_test;
15-
import 'top_level_inference_test.dart' as top_level_inference_test;
7+
import 'api_signature_test.dart' as api_signature;
8+
import 'dependency_walker_test.dart' as dependency_walker;
9+
import 'expr_builder_test.dart' as expr_builder;
10+
import 'flat_buffers_test.dart' as flat_buffers;
11+
import 'in_summary_source_test.dart' as in_summary_source;
12+
import 'linker_test.dart' as linker;
13+
import 'name_filter_test.dart' as name_filter;
14+
import 'package_bundle_reader_test.dart' as package_bundle_reader;
15+
import 'prelinker_test.dart' as prelinker;
16+
import 'resynthesize_ast2_test.dart' as resynthesize_ast2;
17+
import 'resynthesize_ast_test.dart' as resynthesize_ast;
18+
import 'summarize_ast_strong_test.dart' as summarize_ast_strong;
19+
import 'top_level_inference_test.dart' as top_level_inference;
1620

1721
main() {
1822
defineReflectiveSuite(() {
19-
expr_builder_test.main();
20-
in_summary_source_test.main();
21-
linker_test.main();
22-
name_filter_test.main();
23-
package_bundle_reader_test.main();
24-
prelinker_test.main();
25-
resynthesize_ast_test.main();
26-
summarize_ast_strong_test.main();
27-
top_level_inference_test.main();
23+
api_signature.main();
24+
dependency_walker.main();
25+
expr_builder.main();
26+
flat_buffers.main();
27+
in_summary_source.main();
28+
linker.main();
29+
name_filter.main();
30+
package_bundle_reader.main();
31+
prelinker.main();
32+
resynthesize_ast2.main();
33+
resynthesize_ast.main();
34+
summarize_ast_strong.main();
35+
top_level_inference.main();
2836
}, name: 'summary');
2937
}

0 commit comments

Comments
 (0)