Skip to content

Commit 0884dae

Browse files
filmilcommit-bot@chromium.org
authored andcommitted
Revert "Fix the #include path for ICU headers"
This reverts commit 444cb00. Reason for revert: The original change broke time reporting on new devices. Since this was a touch-up, it will need to change as well. Original change's description: > Fix the #include path for ICU headers > > The ICU headers in os_fuchsia.cc have been included with their path > relative to the dart root directory. They should instead be included > relative to the paths mentioned in `-I` directives of the current > compiler invocation. > > This allows downstreams that have a different directory organization to > build dart sdk even if they don't exactly replicate the directory > structure of dart sdk. > > Change-Id: Iec79f261aee5ccc7b74448978fc69244e260400a > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154163 > Reviewed-by: Martin Kustermann <[email protected]> > Commit-Queue: Filip Filmar <[email protected]> [email protected],[email protected],[email protected] # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ib2c22c2bfaabb07001acb707d996d90a18df3fd0 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/155502 Reviewed-by: Filip Filmar <[email protected]> Commit-Queue: Filip Filmar <[email protected]>
1 parent 5171534 commit 0884dae

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

runtime/vm/os_fuchsia.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@
2424
#include <zircon/syscalls/object.h>
2525
#include <zircon/types.h>
2626

27-
#include "unicode/errorcode.h"
28-
#include "unicode/timezone.h"
27+
#include "third_party/icu/source/common/unicode/errorcode.h"
28+
#include "third_party/icu/source/i18n/unicode/timezone.h"
2929

3030
#include "platform/assert.h"
3131
#include "platform/syslog.h"

0 commit comments

Comments
 (0)