Skip to content

Commit 08d7e0a

Browse files
mralephCommit Queue
authored and
Commit Queue
committed
[vm] Disable waitFor for 3.3 release
Revert "[vm] Enable waitFor for 3.2 release" This reverts commit f8086ed. [email protected] TEST=covered by existing tests Bug: #52121 Change-Id: Ic5c7ad9af8ff142564ce237f868dd39354dfd615 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/338761 Reviewed-by: Martin Kustermann <[email protected]> Commit-Queue: Slava Egorov <[email protected]>
1 parent 6249b7e commit 08d7e0a

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

CHANGELOG.md

+10
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,16 @@ constraint][language version] lower bound to 3.2 or greater (`sdk: '^3.2.0'`).
144144

145145
- Added `broadcast` parameter to `Stream.empty` constructor.
146146

147+
#### `dart:cli`
148+
149+
- **Breaking change** [#52121][]:
150+
- `waitFor` is disabled by default and slated for removal in 3.4. Attempting
151+
to call this function will now throw an exception. Users that still depend
152+
on `waitFor` can enable it by passing `--enable_deprecated_wait_for` flag
153+
to the VM.
154+
155+
[#52121]: https://github.com/dart-lang/sdk/issues/52121
156+
147157
#### `dart:convert`
148158

149159
- **Breaking change** [#52801][]:

runtime/vm/dart_api_impl.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ DEFINE_FLAG(bool,
8484
"Dump common hash tables before snapshotting.");
8585
DEFINE_FLAG(bool,
8686
enable_deprecated_wait_for,
87-
true,
87+
false,
8888
"Enable deprecated dart:cli waitFor. "
8989
"This feature will be fully removed in Dart 3.4 release. "
9090
"See https://dartbug.com/52121.");

0 commit comments

Comments
 (0)