[vm] Ensure hot-reload will allocate-finalize new classes if old ones were

This was missed when is_allocate_finalized() was introduced and is now
revealed due to [0] having added

  ASSERT(cls.is_allocate_finalized());

into object allocation paths that were calling finalization code before.

[0] https://dart-review.googlesource.com/c/sdk/+/241202

Fixes #48869

TEST=Fixes test failures.

Change-Id: I5ff0491d4980630cbdbf799f15aa45089ee4d15f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/242101
Reviewed-by: Ryan Macnak <[email protected]>
Commit-Queue: Martin Kustermann <[email protected]>

Author: mkustermann

runtime/vm/object_reload.cc

@@ -656,10 +656,15 @@ void Class::CheckReload(const Class& replacement,
               TypeParametersChanged(context->zone(), *this, replacement));
       return;
     }
+  }
+
+  if (is_finalized() || is_allocate_finalized()) {
+    auto thread = Thread::Current();
 
     // Ensure the replacement class is also finalized.
-    const Error& error =
-        Error::Handle(replacement.EnsureIsFinalized(Thread::Current()));
+    const Error& error = Error::Handle(
+        is_allocate_finalized() ? replacement.EnsureIsAllocateFinalized(thread)
+                                : replacement.EnsureIsFinalized(thread));
     if (!error.IsNull()) {
       context->group_reload_context()->AddReasonForCancelling(
           new (context->zone())