Skip to content

Commit 0c23106

Browse files
liamappelbecommit-bot@chromium.org
authored andcommitted
Revert "Another attempt to fix the upload script."
This reverts commit 0e57805. Reason for revert: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8919710985306895504/+/steps/upload_abi_dills/0/stdout Original change's description: > Another attempt to fix the upload script. > > Bug: #36047 > Change-Id: I2302bd3ee2072651cebcc1179e9778dc4c617965 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95662 > Reviewed-by: Alexander Thomas <[email protected]> > Commit-Queue: Liam Appelbe <[email protected]> [email protected],[email protected],[email protected] Change-Id: Ibe5c52ae0005ea8aa0e69862a19b54cd64864974 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: #36047 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95702 Reviewed-by: Liam Appelbe <[email protected]> Commit-Queue: Liam Appelbe <[email protected]>
1 parent d1e60e0 commit 0c23106

File tree

1 file changed

+7
-8
lines changed

1 file changed

+7
-8
lines changed

tools/upload_abi_dills.sh

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@
88
# $build_dir/vm_platform_strong.dill
99
# $build_dir/gen/kernel_service.dill
1010
# $build_dir/gen_kernel_bytecode.dill
11-
# This script is a no-op unless $BUILDBOT_BUILDERNAME is "dart-sdk-linux-be".
12-
# It's also a no-op if dill files were already uploaded today.
11+
# This script is a no-op unless $BUILDBOT_BUILDERNAME is "dart-sdk-linux". It's
12+
# also a no-op if dill files were already uploaded today.
1313
set -e
1414
set -x
1515

@@ -18,7 +18,7 @@ if [ -z "$2" ]; then
1818
exit 1
1919
fi
2020

21-
if [ "$BUILDBOT_BUILDERNAME" != "dart-sdk-linux-be" ]; then
21+
if [ "$BUILDBOT_BUILDERNAME" != "dart-sdk-linux" ]; then
2222
echo "This script only works on the dart-sdk-linux buildbot"
2323
exit 0
2424
fi
@@ -34,7 +34,6 @@ if [ ! -z "$search_results" ]; then
3434
exit 0
3535
fi
3636

37-
sdk_dir=$(pwd)
3837
tmpdir=$(mktemp -d)
3938
cleanup() {
4039
rm -rf "$tmpdir"
@@ -43,9 +42,9 @@ trap cleanup EXIT HUP INT QUIT TERM PIPE
4342
pushd "$tmpdir"
4443

4544
mkdir abiversions
46-
cp "$sdk_dir/$2/vm_platform_strong.dill" "abiversions/vm_platform_strong.dill"
47-
cp "$sdk_dir/$2/gen/kernel_service.dill" "abiversions/kernel_service.dill"
48-
cp "$sdk_dir/$2/gen_kernel_bytecode.dill" "abiversions/gen_kernel_bytecode.dill"
45+
cp "$2/vm_platform_strong.dill" "abiversions/vm_platform_strong.dill"
46+
cp "$2/gen/kernel_service.dill" "abiversions/kernel_service.dill"
47+
cp "$2/gen_kernel_bytecode.dill" "abiversions/gen_kernel_bytecode.dill"
4948

5049
cipd create \
5150
-name dart/abiversions/$abi_version \
@@ -55,6 +54,6 @@ cipd create \
5554
-tag date:$current_date \
5655
-tag git_revision:$git_revision \
5756
-ref latest \
58-
-ref version_$abi_version
57+
-ref version:$abi_version
5958

6059
popd

0 commit comments

Comments
 (0)