Skip to content

Commit 11a6820

Browse files
athomasCommit Bot
authored and
Commit Bot
committed
[infra] Use safaridriver to launch Safari
For some reason, we launched Safari from a file, which since macOS 10.14 requires the user to confirm the operation in a modal dialog which caused timeouts. * Removed unused http test driver port option. * Added some basic tests for test.py's browser interactions. Bug: b/208186791 Change-Id: I070529148d37bf312f219c576abca3da972f73e6 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/204202 Commit-Queue: Alexander Thomas <[email protected]> Reviewed-by: William Hesse <[email protected]>
1 parent c4c9dc5 commit 11a6820

9 files changed

+353
-502
lines changed

pkg/test_runner/bin/launch_browser.dart

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ void main(List<String> arguments) {
3535
var configuration = TestConfiguration(
3636
configuration: Configuration(
3737
"dummy-configuration", null, null, null, runtime, null));
38-
var executable = configuration.browserLocation;
39-
var browser = Browser.byRuntime(runtime, executable);
38+
var browser = Browser.fromConfiguration(configuration);
4039
browser.start(arguments[1]);
4140
}

0 commit comments

Comments
 (0)