[analyzer] Mark new asset and extension type diagnostic docs as published

Closes dart-lang/site-www#5396

Bug: dart-lang/site-www#5396
Change-Id: Ic4ebe03fd7195a241608cffebfd91b11125c7fa2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/340481
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Marya Belanger <[email protected]>
Reviewed-by: Marya Belanger <[email protected]>

Author: parlough

pkg/analyzer/lib/src/error/codes.g.dart

@@ -261,6 +261,7 @@ class CompileTimeErrorCode extends AnalyzerErrorCode {
     correctionMessage:
         "Try removing the `await`, or updating the extension type to implement "
         "'Future'.",
+    hasPublishedDocs: true,
   );
 
   ///  Parameters:
@@ -1668,6 +1669,7 @@ class CompileTimeErrorCode extends AnalyzerErrorCode {
     'EXTENSION_TYPE_CONSTRUCTOR_WITH_SUPER_FORMAL_PARAMETER',
     "Extension type constructors can't declare super formal parameters.",
     correctionMessage: "Try removing the super formal parameter declaration.",
+    hasPublishedDocs: true,
   );
 
   ///  No parameters.
@@ -1676,6 +1678,7 @@ class CompileTimeErrorCode extends AnalyzerErrorCode {
     'EXTENSION_TYPE_CONSTRUCTOR_WITH_SUPER_INVOCATION',
     "Extension type constructors can't include super initializers.",
     correctionMessage: "Try removing the super constructor invocation.",
+    hasPublishedDocs: true,
   );
 
   ///  No parameters.
@@ -1684,6 +1687,7 @@ class CompileTimeErrorCode extends AnalyzerErrorCode {
     'EXTENSION_TYPE_DECLARES_INSTANCE_FIELD',
     "Extension types can't declare instance fields.",
     correctionMessage: "Try replacing the field with a getter.",
+    hasPublishedDocs: true,
   );
 
   ///  No parameters.
@@ -1693,6 +1697,7 @@ class CompileTimeErrorCode extends AnalyzerErrorCode {
     "Extension types can't declare members with the same name as a member "
         "declared by 'Object'.",
     correctionMessage: "Try specifying a different name for the member.",
+    hasPublishedDocs: true,
   );
 
   ///  Parameters:
@@ -1703,6 +1708,7 @@ class CompileTimeErrorCode extends AnalyzerErrorCode {
     "Extension types can't implement '{0}'.",
     correctionMessage:
         "Try specifying a different type, or remove the type from the list.",
+    hasPublishedDocs: true,
   );
 
   ///  No parameters.
@@ -1712,6 +1718,7 @@ class CompileTimeErrorCode extends AnalyzerErrorCode {
     "The extension type can't implement itself.",
     correctionMessage:
         "Try removing the superinterface that references this extension type.",
+    hasPublishedDocs: true,
   );
 
   ///  Parameters:
@@ -1723,6 +1730,7 @@ class CompileTimeErrorCode extends AnalyzerErrorCode {
     "'{0}' is not a supertype of '{1}', the representation type.",
     correctionMessage:
         "Try specifying a different type, or remove the type from the list.",
+    hasPublishedDocs: true,
   );
 
   ///  Parameters:
@@ -1738,6 +1746,7 @@ class CompileTimeErrorCode extends AnalyzerErrorCode {
         "representation type of '{3}'.",
     correctionMessage:
         "Try specifying a different type, or remove the type from the list.",
+    hasPublishedDocs: true,
   );
 
   ///  Parameters:
@@ -1750,6 +1759,7 @@ class CompileTimeErrorCode extends AnalyzerErrorCode {
         "from implemented types.",
     correctionMessage:
         "Try redeclaring the corresponding member in this extension type.",
+    hasPublishedDocs: true,
   );
 
   ///  No parameters.
@@ -1758,6 +1768,7 @@ class CompileTimeErrorCode extends AnalyzerErrorCode {
     'EXTENSION_TYPE_REPRESENTATION_DEPENDS_ON_ITSELF',
     "The extension type representation can't depend on itself.",
     correctionMessage: "Try specifying a different type.",
+    hasPublishedDocs: true,
   );
 
   ///  No parameters.
@@ -1766,6 +1777,7 @@ class CompileTimeErrorCode extends AnalyzerErrorCode {
     'EXTENSION_TYPE_REPRESENTATION_TYPE_BOTTOM',
     "The representation type can't be a bottom type.",
     correctionMessage: "Try specifying a different type.",
+    hasPublishedDocs: true,
   );
 
   ///  Parameters:
@@ -1776,6 +1788,7 @@ class CompileTimeErrorCode extends AnalyzerErrorCode {
     'EXTENSION_TYPE_WITH_ABSTRACT_MEMBER',
     "'{0}' must have a method body because '{1}' is an extension type.",
     correctionMessage: "Try adding a body to '{0}'.",
+    hasPublishedDocs: true,
   );
 
   static const CompileTimeErrorCode EXTERNAL_FIELD_CONSTRUCTOR_INITIALIZER =
@@ -3740,6 +3753,7 @@ class CompileTimeErrorCode extends AnalyzerErrorCode {
     correctionMessage:
         "Try removing the type parameters from function parameter types and "
         "type parameter bounds.",
+    hasPublishedDocs: true,
   );
 
   ///  Parameters:
@@ -4886,6 +4900,7 @@ class CompileTimeErrorCode extends AnalyzerErrorCode {
     'SUPER_IN_EXTENSION_TYPE',
     "The 'super' keyword can't be used in an extension type because an "
         "extension type doesn't have a superclass.",
+    hasPublishedDocs: true,
   );
 
   ///  No parameters.
@@ -7006,6 +7021,7 @@ class WarningCode extends AnalyzerErrorCode {
     correctionMessage:
         "Try updating this member to match a declaration in a superinterface, "
         "or removing the redeclare annotation.",
+    hasPublishedDocs: true,
   );
 
   ///  An error code indicating use of a removed lint rule.

pkg/analyzer/lib/src/pubspec/pubspec_warning_code.g.dart

@@ -56,6 +56,7 @@ class PubspecWarningCode extends ErrorCode {
     'ASSET_MISSING_PATH',
     "Asset map entry must contain a 'path' field.",
     correctionMessage: "Try adding a 'path' field.",
+    hasPublishedDocs: true,
   );
 
   ///  No parameters.
@@ -74,13 +75,15 @@ class PubspecWarningCode extends ErrorCode {
     'ASSET_NOT_STRING_OR_MAP',
     "An asset value is required to be a file path (string) or map.",
     correctionMessage: "Try converting the value to be a string or map.",
+    hasPublishedDocs: true,
   );
 
   ///  No parameters.
   static const PubspecWarningCode ASSET_PATH_NOT_STRING = PubspecWarningCode(
     'ASSET_PATH_NOT_STRING',
     "Asset paths are required to be file paths (strings).",
     correctionMessage: "Try converting the value to be a string.",
+    hasPublishedDocs: true,
   );
 
   ///  Parameters:

pkg/analyzer/messages.yaml

@@ -1171,6 +1171,7 @@ CompileTimeErrorCode:
   AWAIT_OF_EXTENSION_TYPE_NOT_FUTURE:
     problemMessage: "The 'await' expression can't be used for an expression with an extension type that is not a subtype of 'Future'."
     correctionMessage: Try removing the `await`, or updating the extension type to implement 'Future'.
+    hasPublishedDocs: true
     documentation: |-
       #### Description
 
@@ -5182,6 +5183,7 @@ CompileTimeErrorCode:
   EXTENSION_TYPE_CONSTRUCTOR_WITH_SUPER_FORMAL_PARAMETER:
     problemMessage: "Extension type constructors can't declare super formal parameters."
     correctionMessage: Try removing the super formal parameter declaration.
+    hasPublishedDocs: true
     comment: No parameters.
     documentation: |-
       #### Description
@@ -5222,6 +5224,7 @@ CompileTimeErrorCode:
   EXTENSION_TYPE_CONSTRUCTOR_WITH_SUPER_INVOCATION:
     problemMessage: Extension type constructors can't include super initializers.
     correctionMessage: Try removing the super constructor invocation.
+    hasPublishedDocs: true
     comment: No parameters.
     documentation: |-
       #### Description
@@ -5254,6 +5257,7 @@ CompileTimeErrorCode:
   EXTENSION_TYPE_DECLARES_INSTANCE_FIELD:
     problemMessage: "Extension types can't declare instance fields."
     correctionMessage: Try replacing the field with a getter.
+    hasPublishedDocs: true
     comment: No parameters.
     documentation: |-
       #### Description
@@ -5297,6 +5301,7 @@ CompileTimeErrorCode:
   EXTENSION_TYPE_DECLARES_MEMBER_OF_OBJECT:
     problemMessage: "Extension types can't declare members with the same name as a member declared by 'Object'."
     correctionMessage: Try specifying a different name for the member.
+    hasPublishedDocs: true
     comment: No parameters.
     documentation: |-
       #### Description
@@ -5336,6 +5341,7 @@ CompileTimeErrorCode:
   EXTENSION_TYPE_IMPLEMENTS_DISALLOWED_TYPE:
     problemMessage: "Extension types can't implement '{0}'."
     correctionMessage: Try specifying a different type, or remove the type from the list.
+    hasPublishedDocs: true
     comment: |-
       Parameters:
       0: the display string of the disallowed type
@@ -5364,6 +5370,7 @@ CompileTimeErrorCode:
   EXTENSION_TYPE_IMPLEMENTS_ITSELF:
     problemMessage: "The extension type can't implement itself."
     correctionMessage: Try removing the superinterface that references this extension type.
+    hasPublishedDocs: true
     comment: No parameters.
     documentation: |-
       #### Description
@@ -5402,6 +5409,7 @@ CompileTimeErrorCode:
   EXTENSION_TYPE_IMPLEMENTS_NOT_SUPERTYPE:
     problemMessage: "'{0}' is not a supertype of '{1}', the representation type."
     correctionMessage: Try specifying a different type, or remove the type from the list.
+    hasPublishedDocs: true
     comment: |-
       Parameters:
       0: the implemented not extension type
@@ -5440,6 +5448,7 @@ CompileTimeErrorCode:
   EXTENSION_TYPE_IMPLEMENTS_REPRESENTATION_NOT_SUPERTYPE:
     problemMessage: "'{0}', the representation type of '{1}', is not a supertype of '{2}', the representation type of '{3}'."
     correctionMessage: Try specifying a different type, or remove the type from the list.
+    hasPublishedDocs: true
     comment: |-
       Parameters:
       0: the representation type of the implemented extension type
@@ -5488,6 +5497,7 @@ CompileTimeErrorCode:
   EXTENSION_TYPE_INHERITED_MEMBER_CONFLICT:
     problemMessage: "The extension type '{0}' has more than one distinct member named '{1}' from implemented types."
     correctionMessage: Try redeclaring the corresponding member in this extension type.
+    hasPublishedDocs: true
     comment: |-
       Parameters:
       0: the name of the extension type
@@ -5551,6 +5561,7 @@ CompileTimeErrorCode:
   EXTENSION_TYPE_REPRESENTATION_DEPENDS_ON_ITSELF:
     problemMessage: "The extension type representation can't depend on itself."
     correctionMessage: Try specifying a different type.
+    hasPublishedDocs: true
     comment: No parameters.
     documentation: |-
       #### Description
@@ -5595,6 +5606,7 @@ CompileTimeErrorCode:
   EXTENSION_TYPE_REPRESENTATION_TYPE_BOTTOM:
     problemMessage: "The representation type can't be a bottom type."
     correctionMessage: Try specifying a different type.
+    hasPublishedDocs: true
     comment: No parameters.
     documentation: |-
       #### Description
@@ -5623,6 +5635,7 @@ CompileTimeErrorCode:
   EXTENSION_TYPE_WITH_ABSTRACT_MEMBER:
     problemMessage: "'{0}' must have a method body because '{1}' is an extension type."
     correctionMessage: "Try adding a body to '{0}'."
+    hasPublishedDocs: true
     comment: |-
       Parameters:
       0: the name of the abstract method
@@ -11568,6 +11581,7 @@ CompileTimeErrorCode:
   NON_COVARIANT_TYPE_PARAMETER_POSITION_IN_REPRESENTATION_TYPE:
     problemMessage: "An extension type parameter can't be used in a non-covariant position of its representation type."
     correctionMessage: "Try removing the type parameters from function parameter types and type parameter bounds."
+    hasPublishedDocs: true
     comment: No parameters.
     documentation: |-
       #### Description
@@ -15751,6 +15765,7 @@ CompileTimeErrorCode:
       ```
   SUPER_IN_EXTENSION_TYPE:
     problemMessage: "The 'super' keyword can't be used in an extension type because an extension type doesn't have a superclass."
+    hasPublishedDocs: true
     comment: No parameters.
     documentation: |-
       #### Description
@@ -21181,7 +21196,7 @@ PubspecWarningCode:
   ASSET_MISSING_PATH:
     problemMessage: "Asset map entry must contain a 'path' field."
     correctionMessage: "Try adding a 'path' field."
-    hasPublishedDocs: false
+    hasPublishedDocs: true
     comment: No parameters.
     documentation: |-
       #### Description
@@ -21260,7 +21275,7 @@ PubspecWarningCode:
   ASSET_NOT_STRING_OR_MAP:
     problemMessage: An asset value is required to be a file path (string) or map.
     correctionMessage: Try converting the value to be a string or map.
-    hasPublishedDocs: false
+    hasPublishedDocs: true
     comment: No parameters.
     documentation: |-
       #### Description
@@ -21309,7 +21324,7 @@ PubspecWarningCode:
   ASSET_PATH_NOT_STRING:
     problemMessage: Asset paths are required to be file paths (strings).
     correctionMessage: Try converting the value to be a string.
-    hasPublishedDocs: false
+    hasPublishedDocs: true
     comment: No parameters.
     documentation: |-
       #### Description
@@ -24905,6 +24920,7 @@ WarningCode:
   REDECLARE_ON_NON_REDECLARING_MEMBER:
     problemMessage: "The {0} doesn't redeclare a {0} declared in a superinterface."
     correctionMessage: Try updating this member to match a declaration in a superinterface, or removing the redeclare annotation.
+    hasPublishedDocs: true
     comment: |-
       An error code indicating the use of a redeclare annotation on a member that does not redeclare.