Skip to content

Commit 177511a

Browse files
mkustermanncommit-bot@chromium.org
authored andcommitted
[benchmarks] Disable literal_only_boolean_expressions/unnecessary_await_in_return analyzer hints
The literal_only_boolean_expressions analyzer hint flags this code: while (true) { ... if (cond) break; ... } => This is very common code. The unnecessary_await_in_return analyzer hint flags this code: Future foo() async { ... return await foo(); } => Addressing this hint by removing the `await` changes semantics, performance characteristics and async stack traces. Change-Id: I3c126123bfba7386b01033084e954267af21ba13 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152001 Reviewed-by: Alexander Markov <[email protected]> Commit-Queue: Martin Kustermann <[email protected]>
1 parent 0a6a4a2 commit 177511a

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

benchmarks/analysis_options.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ linter:
4141
- library_names
4242
- library_prefixes
4343
- list_remove_unrelated_type
44-
- literal_only_boolean_expressions
44+
#- literal_only_boolean_expressions
4545
- no_adjacent_strings_in_list
4646
- no_duplicate_case_values
4747
#- non_constant_identifier_names
@@ -77,7 +77,7 @@ linter:
7777
- throw_in_finally
7878
- type_init_formals
7979
- unawaited_futures
80-
- unnecessary_await_in_return
80+
#- unnecessary_await_in_return
8181
- unnecessary_brace_in_string_interps
8282
- unnecessary_const
8383
- unnecessary_getters_setters

0 commit comments

Comments
 (0)