Skip to content

Commit 23b73d7

Browse files
srawlinsCommit Queue
authored and
Commit Queue
committed
ignore unreachable constructors in reflective tests
These were flagged as unused by `unreachable_from_main` but they are used by `dart:mirrors`. Change-Id: I3637b4b234f0bf7fe795977cb7ec6a1ca5449810 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/293006 Reviewed-by: Phil Quitslund <[email protected]> Commit-Queue: Samuel Rawlins <[email protected]>
1 parent d47cd99 commit 23b73d7

File tree

3 files changed

+5
-1
lines changed

3 files changed

+5
-1
lines changed

pkg/analysis_server/test/services/snippets/snippet_request_test.dart

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,9 @@ void main() {
1919

2020
@reflectiveTest
2121
class SnippetRequestTest extends AbstractSingleUnitTest {
22-
SnippetRequestTest() {
22+
@override
23+
void setUp() {
24+
super.setUp();
2325
verifyNoTestUnitErrors = false;
2426
}
2527

pkg/nnbd_migration/test/decorated_type_test.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ class DecoratedTypeTest extends Object
3737
@override
3838
final decoratedTypeParameterBounds = DecoratedTypeParameterBounds();
3939

40+
// ignore: unreachable_from_main
4041
factory DecoratedTypeTest() {
4142
var typeProvider = TestTypeProvider();
4243
var graph = NullabilityGraph();

pkg/nnbd_migration/test/edge_builder_test.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ class AssignmentCheckerTest extends Object
6060

6161
final AssignmentCheckerForTesting checker;
6262

63+
// ignore: unreachable_from_main
6364
factory AssignmentCheckerTest() {
6465
var typeProvider = TestTypeProvider().asLegacy;
6566
_setCoreLibrariesTypeSystem(typeProvider);

0 commit comments

Comments
 (0)