Skip to content

Commit 260b9b1

Browse files
DanTupbwilkerson
authored andcommitted
[analysis_server] Fix location of ignore comments on getters with dartdocs
Fixes Dart-Code/Dart-Code#4775 Change-Id: I7fd049f2f58ed677c5c4a8e5ab7450e54ae61c9c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/329740 Reviewed-by: Phil Quitslund <[email protected]> Reviewed-by: Brian Wilkerson <[email protected]>
1 parent feb486f commit 260b9b1

File tree

2 files changed

+14
-1
lines changed

2 files changed

+14
-1
lines changed

pkg/analysis_server/lib/src/services/correction/dart/ignore_diagnostic.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,8 +97,9 @@ class IgnoreDiagnosticOnLine extends AbstractIgnoreDiagnostic {
9797
Future<void> compute(ChangeBuilder builder) async {
9898
if (_isCodeUnignorable()) return;
9999

100+
final diagnostic = this.diagnostic!; // Enforced by _isCodeUnignorable
100101
final insertDesc = CorrectionUtils_InsertDesc();
101-
insertDesc.offset = node.offset;
102+
insertDesc.offset = diagnostic.problemMessage.offset;
102103
await _computeEdit(
103104
builder,
104105
insertDesc,

pkg/analysis_server/test/src/services/correction/fix/ignore_diagnostic_test.dart

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,18 @@ void f() {
148148
''');
149149
}
150150

151+
Future<void> test_dartdoc_getter() async {
152+
await resolveTestCode('''
153+
/// AA
154+
String get _AA => '';
155+
''');
156+
await assertHasFix('''
157+
/// AA
158+
// ignore: unused_element
159+
String get _AA => '';
160+
''');
161+
}
162+
151163
Future<void> test_existingIgnore() async {
152164
await resolveTestCode('''
153165
void f() {

0 commit comments

Comments
 (0)