[dart:html] Rename emitters and regenerate dart:html

emitter is a module name, so we use a different name here to avoid
a collision when using the module name. This CL regenerates dart:html
after accounting for https://dart-review.googlesource.com/c/sdk/+/276560.

Change-Id: I1c9d3a54a5f37a5e42cd5b79bbc3d635b98c198e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276763
Reviewed-by: Nicholas Shahan <[email protected]>
Commit-Queue: Srujan Gaddam <[email protected]>

Author: srujzs

sdk/lib/html/dart2js/html_dart2js.dart

@@ -32735,7 +32735,7 @@ class Window extends EventTarget
    * ## Other resources
    *
    * * [Measuring page load speed with navigation
-   *   timeing](http://www.html5rocks.com/en/tutorials/webperformance/basics/)
+   *   timing](http://www.html5rocks.com/en/tutorials/webperformance/basics/)
    *   from HTML5Rocks.
    * * [Navigation timing
    *   specification](http://www.w3.org/TR/navigation-timing/) from W3C.

tools/dom/scripts/htmldartgenerator.py

@@ -536,23 +536,23 @@ def Mixins(self):
         return mixins
 
     def AddConstructors(self, constructors, factory_name,
-                        factory_constructor_name, emitter):
+                        factory_constructor_name, constructor_emitter):
         """ Adds all of the constructors.
     Arguments:
       constructors - List of the constructors to be added.
       factory_name - Name of the factory for this class.
       factory_constructor_name - The name of the constructor on the
           factory_name to call (calls an autogenerated FactoryProvider
           if unspecified)
-      emitter - Emitter used to emit constructors when generating classes
-          using the static extension pattern.
+      constructor_emitter - Emitter used to emit constructors when generating
+          classes using the static extension pattern.
     """
         for constructor_info in constructors:
             self._AddConstructor(constructor_info, factory_name,
-                                 factory_constructor_name, emitter)
+                                 factory_constructor_name, constructor_emitter)
 
     def _AddConstructor(self, constructor_info, factory_name,
-                        factory_constructor_name, emitter):
+                        factory_constructor_name, constructor_emitter):
         # Hack to ignore the constructor used by JavaScript.
         if ((self._interface.id == 'HTMLImageElement' or
              self._interface.id == 'Blob' or
@@ -566,7 +566,8 @@ def _AddConstructor(self, constructor_info, factory_name,
         metadata = self._metadata.GetFormattedMetadata(
             self._library_name, self._interface, self._interface.id, '  ')
 
-        target_emitter = emitter if emitter else self._members_emitter
+        target_emitter = constructor_emitter if constructor_emitter else \
+            self._members_emitter
 
         if not factory_constructor_name:
             factory_constructor_name = '_create'
@@ -669,7 +670,7 @@ def GenerateCall(stmts_emitter, call_emitter, version,
                     FACTORY_NAME=qualified_name,
                     FACTORY_PARAMS=args)
                 self.EmitStaticFactoryOverload(constructor_info, name,
-                                               arguments, emitter)
+                                               arguments, constructor_emitter)
 
             def IsOptional(signature_index, argument):
                 return self.IsConstructorArgumentOptional(argument)
@@ -817,12 +818,13 @@ def _AddFutureifiedOperation(self, info, html_name):
             FUTURE_GENERIC=future_generic,
             ORIGINAL_FUNCTION=html_name)
 
-    def EmitHelpers(self, base_class, emitter):
-        if (not self._members_emitter) and (not emitter):
+    def EmitHelpers(self, base_class, members_emitter):
+        if (not self._members_emitter) and (not members_emitter):
             return
 
         if self._interface.id not in custom_html_constructors:
-            target_emitter = emitter if emitter else self._members_emitter
+            target_emitter = members_emitter if members_emitter else \
+                self._members_emitter
             target_emitter.Emit(
                 '  // To suppress missing implicit constructor warnings.\n'
                 '  factory $CLASSNAME._() { '