Skip to content

Commit 3f1dfdc

Browse files
polina-cCommit Bot
authored and
Commit Bot
committed
Move configuration to separate section to make it easier to discover.
Change-Id: I70ef83de107388e732f3e2eda16511b663ac57ab Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/230959 Reviewed-by: Slava Egorov <[email protected]> Commit-Queue: Polina Cherkasova <[email protected]>
1 parent f85a44c commit 3f1dfdc

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

CONTRIBUTING.md

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,13 @@ Before we can use your code, you must sign the [Google Individual Contributor Li
2020

2121
Before you start working on a larger contribution, you should get in touch with us first through the [Dart Issue Tracker](https://dartbug.com) with your idea so that we can help out and possibly guide you. Coordinating up front makes it much easier to avoid frustration later on.
2222

23-
All submissions, including submissions by project members, require review. We use the same code-review tools and process as the chromium project. In order to submit a patch, you need to get the [depot\_tools](http://dev.chromium.org/developers/how-tos/depottools).
23+
All submissions, including submissions by project members, require review. We use the same code-review tools and process as the chromium project.
2424

25-
We occasionally take pull requests, e.g., for comment changes, but the main flow is to use the Rietveld review system as explained below.
25+
We occasionally take pull requests, e.g., for comment changes, but the main flow is to use the Gerrit review system as explained below.
26+
27+
## Setting up Environment
28+
29+
In order to submit a patch, you need to get the [depot\_tools](http://dev.chromium.org/developers/how-tos/depottools).
2630

2731
## Getting the code
2832

@@ -69,7 +73,9 @@ Upload the patch for review:
6973
git cl upload -s
7074
```
7175

72-
The above command returns a URL for the review. Attach this review to your issue in https://dartbug.com
76+
The above command returns a URL for the review. Attach this review to your issue in https://dartbug.com.
77+
78+
To update the cl, just commit your changes and run `git cl upload -s` for your branch.
7379

7480
If you have commit access, when the review is done and the patch is good to go, submit the patch on https://dart-review.googlesource.com:
7581

0 commit comments

Comments
 (0)