[analyzer] Mark DEFAULT_LIST_CONSTRUCTOR as removed

Follow-up to https://dart-review.googlesource.com/c/sdk/+/276770

Change-Id: I583d19e3fab99594a12083381cc98cd1e453efcf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/319641
Commit-Queue: Brian Wilkerson <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>

Author: parlough

pkg/analysis_server/lib/src/services/correction/error_fix_status.yaml

@@ -457,10 +457,6 @@ CompileTimeErrorCode.CONTINUE_LABEL_INVALID:
   status: noFix
 CompileTimeErrorCode.COULD_NOT_INFER:
   status: noFix
-CompileTimeErrorCode.DEFAULT_LIST_CONSTRUCTOR:
-  status: noFix
-  notes: |-
-    Removed in Dart 3.0.
 CompileTimeErrorCode.DEFAULT_VALUE_IN_REDIRECTING_FACTORY_CONSTRUCTOR:
   status: needsFix
   notes: |-

pkg/analyzer/lib/src/error/codes.g.dart

@@ -1115,17 +1115,6 @@ class CompileTimeErrorCode extends AnalyzerErrorCode {
     "Couldn't infer type parameter '{0}'.{1}",
   );
 
-  ///  No parameters.
-  static const CompileTimeErrorCode DEFAULT_LIST_CONSTRUCTOR =
-      CompileTimeErrorCode(
-    'DEFAULT_LIST_CONSTRUCTOR',
-    "The default 'List' constructor isn't available when null safety is "
-        "enabled.",
-    correctionMessage:
-        "Try using a list literal, 'List.filled' or 'List.generate'.",
-    hasPublishedDocs: true,
-  );
-
   ///  No parameters.
   static const CompileTimeErrorCode
       DEFAULT_VALUE_IN_REDIRECTING_FACTORY_CONSTRUCTOR = CompileTimeErrorCode(

pkg/analyzer/lib/src/error/error_code_values.g.dart

@@ -143,7 +143,6 @@ const List<ErrorCode> errorCodeValues = [
   CompileTimeErrorCode.CONST_WITH_UNDEFINED_CONSTRUCTOR_DEFAULT,
   CompileTimeErrorCode.CONTINUE_LABEL_INVALID,
   CompileTimeErrorCode.COULD_NOT_INFER,
-  CompileTimeErrorCode.DEFAULT_LIST_CONSTRUCTOR,
   CompileTimeErrorCode.DEFAULT_VALUE_IN_REDIRECTING_FACTORY_CONSTRUCTOR,
   CompileTimeErrorCode.DEFAULT_VALUE_ON_REQUIRED_PARAMETER,
   CompileTimeErrorCode.DEFERRED_IMPORT_OF_EXTENSION,

pkg/analyzer/messages.yaml

@@ -3296,6 +3296,7 @@ CompileTimeErrorCode:
       Parameters:
       0: the name of the non-type element
   DEFAULT_LIST_CONSTRUCTOR:
+    removedIn: "3.2"
     problemMessage: "The default 'List' constructor isn't available when null safety is enabled."
     correctionMessage: "Try using a list literal, 'List.filled' or 'List.generate'."
     hasPublishedDocs: true

pkg/analyzer/test/verify_diagnostics_test.dart

@@ -38,11 +38,6 @@ class DocumentationValidator {
     'CompileTimeErrorCode.CONST_CONSTRUCTOR_PARAM_TYPE_MISMATCH',
     // Produces two diagnostics when it should only produce one.
     'CompileTimeErrorCode.CONST_DEFERRED_CLASS',
-    // These docs need to be published until there are few enough users that
-    // are on a pre-3.0 SDK that we're OK with the possibility of them
-    // encountering a broken link.
-    // todo(pq): remove (some time) post 3.0
-    'CompileTimeErrorCode.DEFAULT_LIST_CONSTRUCTOR',
     // The mock SDK doesn't define any internal libraries.
     'CompileTimeErrorCode.EXPORT_INTERNAL_LIBRARY',
     // Also reports CompileTimeErrorCode.SUBTYPE_OF_BASE_OR_FINAL_IS_NOT_BASE_FINAL_OR_SEALED