Migrator: Use pedantic 1.9.0

Change-Id: Ia53e84ac6b2f3ab0679710c14453fd65c8f9c00d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/163161
Reviewed-by: Mike Fairhurst <[email protected]>
Reviewed-by: Paul Berry <[email protected]>
Commit-Queue: Samuel Rawlins <[email protected]>

Author: srawlins

pkg/nnbd_migration/analysis_options.yaml

@@ -1,6 +1,19 @@
+include: package:pedantic/analysis_options.1.9.0.yaml
+
 analyzer:
+  errors:
+    # There are currently 175 violations.
+    always_declare_return_types: ignore
+    # There are currently 60 violations.
+    annotate_overrides: ignore
+    # There are currently 200 violations.
+    omit_local_variable_types: ignore
+    # There are currently 20 violations.
+    unawaited_futures: ignore
+
   strong-mode:
     implicit-casts: false
+
 linter:
   rules:
     - empty_constructor_bodies

pkg/nnbd_migration/lib/fix_reason_target.dart

@@ -10,7 +10,7 @@ import 'package:analyzer/src/generated/utilities_general.dart';
 /// is associated with each reason.
 abstract class FixReasonTarget {
   /// Fix reason target representing the full type, rather than a part of it.
-  static const FixReasonTarget root = const _FixReasonTarget_Root();
+  static const FixReasonTarget root = _FixReasonTarget_Root();
 
   const FixReasonTarget._();
 

pkg/nnbd_migration/lib/migration_cli.dart

@@ -544,7 +544,7 @@ class MigrationCliRunner {
   NonNullableFix createNonNullableFix(
       DartFixListener listener,
       ResourceProvider resourceProvider,
-      LineInfo getLineInfo(String path),
+      LineInfo Function(String path) getLineInfo,
       Object bindAddress,
       {List<String> included = const <String>[],
       int preferredPort,

pkg/nnbd_migration/lib/src/decorated_type.dart

@@ -158,7 +158,8 @@ class DecoratedType implements DecoratedTypeInfo {
       return DecoratedType(type, nullabilityNode, typeArguments: typeArguments);
     } else if (type is FunctionType) {
       if (typeArguments != null) {
-        throw "Not supported: implicit function type with explicit type arguments";
+        throw 'Not supported: implicit function type with explicit type '
+            'arguments';
       }
       return DecoratedType.forImplicitFunction(
           typeProvider, type, nullabilityNode, graph, target);
@@ -184,7 +185,7 @@ class DecoratedType implements DecoratedTypeInfo {
     // [_decoratedTypeParameterBounds] so the type parameter needs to have an
     // enclosing element of `null`.
     assert(parameter.enclosingElement == null,
-        "$parameter should not have parent ${parameter.enclosingElement}");
+        '$parameter should not have parent ${parameter.enclosingElement}');
   }
 
   /// If `this` represents an interface type, returns the substitution necessary
@@ -219,8 +220,8 @@ class DecoratedType implements DecoratedTypeInfo {
   @override
   bool operator ==(Object other) {
     if (other is DecoratedType) {
-      if (!identical(this.node, other.node)) return false;
-      var thisType = this.type;
+      if (!identical(node, other.node)) return false;
+      var thisType = type;
       var otherType = other.type;
       if (thisType is FunctionType && otherType is FunctionType) {
         if (thisType.normalParameterTypes.length !=
@@ -244,7 +245,7 @@ class DecoratedType implements DecoratedTypeInfo {
         return true;
       } else if (thisType is InterfaceType && otherType is InterfaceType) {
         if (thisType.element != otherType.element) return false;
-        if (!_compareLists(this.typeArguments, other.typeArguments)) {
+        if (!_compareLists(typeArguments, other.typeArguments)) {
           return false;
         }
         return true;

pkg/nnbd_migration/lib/src/edge_builder.dart

@@ -211,7 +211,7 @@ class EdgeBuilder extends GeneralizingAstVisitor<DecoratedType>
 
   final Set<PromotableElement> _lateHintedLocals = {};
 
-  Map<Token, HintComment> _nullCheckHints = {};
+  final Map<Token, HintComment> _nullCheckHints = {};
 
   EdgeBuilder(this.typeProvider, this._typeSystem, this._variables, this._graph,
       this.source, this.listener, this._decoratedClassHierarchy,
@@ -484,7 +484,7 @@ class EdgeBuilder extends GeneralizingAstVisitor<DecoratedType>
       } else {
         var calleeType =
             getOrComputeElementType(callee, targetType: targetType);
-        assert(calleeType.positionalParameters.length > 0); // TODO(paulberry)
+        assert(calleeType.positionalParameters.isNotEmpty); // TODO(paulberry)
         _handleAssignment(rightOperand,
             destinationType: calleeType.positionalParameters[0]);
         return _fixNumericTypes(calleeType.returnType, node.staticType);
@@ -1728,7 +1728,7 @@ class EdgeBuilder extends GeneralizingAstVisitor<DecoratedType>
           var instantiatedType =
               _variables.decoratedTypeAnnotation(source, typeName);
           if (instantiatedType == null) {
-            throw new StateError('No type annotation for type name '
+            throw StateError('No type annotation for type name '
                 '${typeName.toSource()}, offset=${typeName.offset}');
           }
           var origin = InstantiateToBoundsOrigin(source, typeName);
@@ -2238,7 +2238,7 @@ class EdgeBuilder extends GeneralizingAstVisitor<DecoratedType>
           DecoratedType compoundOperatorType = getOrComputeElementType(
               compoundOperatorMethod,
               targetType: destinationType);
-          assert(compoundOperatorType.positionalParameters.length > 0);
+          assert(compoundOperatorType.positionalParameters.isNotEmpty);
           _checkAssignment(edgeOrigin, FixReasonTarget.root,
               source: sourceType,
               destination: compoundOperatorType.positionalParameters[0],
@@ -2757,7 +2757,7 @@ class EdgeBuilder extends GeneralizingAstVisitor<DecoratedType>
       }
     }
     int i = 0;
-    var suppliedNamedParameters = Set<String>();
+    var suppliedNamedParameters = <String>{};
     for (var argument in arguments) {
       String name;
       Expression expression;

pkg/nnbd_migration/lib/src/edit_plan.dart

@@ -90,7 +90,7 @@ class AtomicEdit {
   /// Optional argument [info] contains information about why the change was
   /// made.
   const AtomicEdit.insert(this.replacement,
-      {this.info, this.isInformative: false})
+      {this.info, this.isInformative = false})
       : assert(replacement.length > 0),
         assert(isInformative is bool),
         length = 0;
@@ -105,13 +105,13 @@ class AtomicEdit {
         isInformative = false;
 
   /// Return `true` if this edit is a deletion (no characters added).
-  bool get isDeletion => replacement.length == 0;
+  bool get isDeletion => replacement.isEmpty;
 
   /// Return `true` if this edit is an insertion (no characters removed).
   bool get isInsertion => length == 0;
 
   /// Return `true` if this edit is a replacement.
-  bool get isReplacement => length > 0 && replacement.length > 0;
+  bool get isReplacement => length > 0 && replacement.isNotEmpty;
 
   @override
   String toString() {

pkg/nnbd_migration/lib/src/front_end/info_builder.dart

@@ -238,7 +238,7 @@ class InfoBuilder {
     var description = 'Non-nullability reason${target.suffix}';
     var step = node.whyNotNullable;
     if (step == null) {
-      if (node != this.info.never) {
+      if (node != info.never) {
         // 'never' indicates we're describing an edge to never, such as a `!`.
         traces.add(TraceInfo(description, [
           _nodeToTraceEntry(node,