Reland "[vm/bytecode] Switch kernel service dill to bytecode if building Dart SDK with --bytecode"

This is a reland of https://dart-review.googlesource.com/c/sdk/+/113123
after stack overflow in the interpreter was fixed in https://dart-review.googlesource.com/c/sdk/+/117061

Original change's description:

Temporary setting of FLAG_enable_interpreter is avoided in the VM unit tests as
this flag is global and used by kernel service isolate while running tests.
Flipping this flag causes assertion failures in kernel isolate's background compiler
or infinite loop between LazyCompile stub and CompileFunction as AttachBytecode
doesn't set entry point to InterpretCall.

The less intrusive way to ensure compilation of functions in unit tests is to set
FLAG_compilation_counter_threshold to 0.

Change-Id: Ibbcf4b5bb0df558851c80cfa40a9a54f949dd187
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117122
Reviewed-by: Régis Crelier <[email protected]>
Commit-Queue: Alexander Markov <[email protected]>

Author: alexmarkov

runtime/vm/compiler/backend/il_test_helper.cc

@@ -46,8 +46,10 @@ RawFunction* GetFunction(const Library& lib, const char* name) {
 
 void Invoke(const Library& lib, const char* name) {
   // These tests rely on running unoptimized code to collect type feedback. The
-  // interpreter does not collect type feedback for interface calls.
-  SetFlagScope<bool> sfs(&FLAG_enable_interpreter, false);
+  // interpreter does not collect type feedback for interface calls, so set
+  // compilation threshold to 0 in order to compile invoked function
+  // immediately and execute compiled code.
+  SetFlagScope<int> sfs(&FLAG_compilation_counter_threshold, 0);
 
   Thread* thread = Thread::Current();
   Dart_Handle api_lib = Api::NewHandle(thread, lib.raw());

runtime/vm/compiler/jit/compiler.cc

@@ -230,14 +230,14 @@ DEFINE_RUNTIME_ENTRY(CompileFunction, 1) {
         Exceptions::PropagateError(Error::Cast(result));
       }
     }
-    if (function.HasBytecode()) {
+    if (function.HasBytecode() && (FLAG_compilation_counter_threshold != 0)) {
       // If interpreter is enabled and there is bytecode, LazyCompile stub
       // (which calls CompileFunction) should proceed to InterpretCall in order
       // to enter interpreter. In such case, compilation is postponed and
       // triggered by interpreter later via CompileInterpretedFunction.
       return;
     }
-    // No bytecode, fall back to compilation.
+    // Fall back to compilation.
   } else {
     ASSERT(!function.HasCode());
   }

runtime/vm/dart_entry.cc

@@ -152,15 +152,15 @@ RawObject* DartEntry::InvokeFunction(const Function& function,
       }
 
       // If we have bytecode but no native code then invoke the interpreter.
-      if (function.HasBytecode()) {
+      if (function.HasBytecode() && (FLAG_compilation_counter_threshold != 0)) {
         ASSERT(thread->no_callback_scope_depth() == 0);
         SuspendLongJumpScope suspend_long_jump_scope(thread);
         TransitionToGenerated transition(thread);
         return Interpreter::Current()->Call(function, arguments_descriptor,
                                             arguments, thread);
       }
 
-      // No bytecode, fall back to compilation.
+      // Fall back to compilation.
     }
 
     const Object& result =

runtime/vm/profiler_test.cc

@@ -1413,7 +1413,7 @@ ISOLATE_UNIT_TEST_CASE(Profiler_FunctionInline) {
   DisableNativeProfileScope dnps;
   DisableBackgroundCompilationScope dbcs;
   SetFlagScope<int> sfs(&FLAG_optimization_counter_threshold, 30000);
-  SetFlagScope<bool> sfs2(&FLAG_enable_interpreter, false);
+  SetFlagScope<int> sfs2(&FLAG_compilation_counter_threshold, 0);
 
   const char* kScript =
       "class A {\n"
@@ -1532,7 +1532,7 @@ ISOLATE_UNIT_TEST_CASE(Profiler_InliningIntervalBoundry) {
   DisableNativeProfileScope dnps;
   DisableBackgroundCompilationScope dbcs;
   SetFlagScope<int> sfs(&FLAG_optimization_counter_threshold, 30000);
-  SetFlagScope<bool> sfs2(&FLAG_enable_interpreter, false);
+  SetFlagScope<int> sfs2(&FLAG_compilation_counter_threshold, 0);
 
   const char* kScript =
       "class A {\n"
@@ -1850,8 +1850,8 @@ ISOLATE_UNIT_TEST_CASE(Profiler_BasicSourcePositionOptimized) {
   DisableNativeProfileScope dnps;
   DisableBackgroundCompilationScope dbcs;
   // Optimize quickly.
-  SetFlagScope<int> sfs2(&FLAG_optimization_counter_threshold, 5);
-  SetFlagScope<bool> sfs3(&FLAG_enable_interpreter, false);
+  SetFlagScope<int> sfs(&FLAG_optimization_counter_threshold, 5);
+  SetFlagScope<int> sfs2(&FLAG_compilation_counter_threshold, 0);
   const char* kScript =
       "class A {\n"
       "  var a;\n"
@@ -2020,8 +2020,8 @@ ISOLATE_UNIT_TEST_CASE(Profiler_SourcePositionOptimized) {
   DisableNativeProfileScope dnps;
   DisableBackgroundCompilationScope dbcs;
   // Optimize quickly.
-  SetFlagScope<int> sfs2(&FLAG_optimization_counter_threshold, 5);
-  SetFlagScope<bool> sfs3(&FLAG_enable_interpreter, false);
+  SetFlagScope<int> sfs(&FLAG_optimization_counter_threshold, 5);
+  SetFlagScope<int> sfs2(&FLAG_compilation_counter_threshold, 0);
 
   const char* kScript =
       "class A {\n"
@@ -2225,8 +2225,8 @@ ISOLATE_UNIT_TEST_CASE(Profiler_BinaryOperatorSourcePositionOptimized) {
   DisableNativeProfileScope dnps;
   DisableBackgroundCompilationScope dbcs;
   // Optimize quickly.
-  SetFlagScope<int> sfs2(&FLAG_optimization_counter_threshold, 5);
-  SetFlagScope<bool> sfs3(&FLAG_enable_interpreter, false);
+  SetFlagScope<int> sfs(&FLAG_optimization_counter_threshold, 5);
+  SetFlagScope<int> sfs2(&FLAG_compilation_counter_threshold, 0);
 
   const char* kScript =
       "class A {\n"
@@ -2300,11 +2300,9 @@ ISOLATE_UNIT_TEST_CASE(Profiler_BinaryOperatorSourcePositionOptimized) {
     ProfileStackWalker walker(&profile, true);
 
     EXPECT_STREQ("DRT_AllocateObject", walker.VMTagName());
-    if (!FLAG_enable_interpreter) {
-      EXPECT_STREQ("[Stub] Allocate A", walker.CurrentName());
-      EXPECT_EQ(1, walker.CurrentExclusiveTicks());
-      EXPECT(walker.Down());
-    }
+    EXPECT_STREQ("[Stub] Allocate A", walker.CurrentName());
+    EXPECT_EQ(1, walker.CurrentExclusiveTicks());
+    EXPECT(walker.Down());
     EXPECT_STREQ("B.boo", walker.CurrentName());
     EXPECT_EQ(1, walker.CurrentInclusiveTicks());
     EXPECT_STREQ("A", walker.CurrentToken());

utils/kernel-service/BUILD.gn

@@ -104,6 +104,13 @@ template("kernel_service_dill") {
           "--output=" + rebase_path(output),
           rebase_path(kernel_service_script),
         ]
+
+    if (dart_platform_bytecode) {
+      args += [
+        "--gen-bytecode",
+        "--drop-ast",
+      ]
+    }
   }
 }