Skip to content

Commit 5391447

Browse files
Hixietvolkert
authored andcommitted
Clarify dart:ui dependencies in foundation library (#24868)
1 parent 58c8489 commit 5391447

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

packages/flutter/lib/src/foundation/README.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,3 +2,12 @@ The rule for packages in this directory is that they can depend on
22
nothing but core Dart packages. They can't depend on `dart:ui`, they
33
can't depend on any `package:`, and they can't depend on anything
44
outside this directory.
5+
6+
Currently they do depend on dart:ui, but only for `VoidCallback` and
7+
`hashValues` (and maybe one day `hashList` and `lerpDouble`), which
8+
are all intended to be moved out of `dart:ui` and into `dart:core`.
9+
10+
See also:
11+
12+
* https://github.com/dart-lang/sdk/issues/27791 (`VoidCallback`)
13+
* https://github.com/dart-lang/sdk/issues/25217 (`hashValues`, `hashList`, and `lerpDouble`)

packages/flutter/lib/src/foundation/profile.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
44

5-
import 'dart:ui';
5+
import 'dart:ui' show VoidCallback;
66

77
/// Whether we've been built in release mode.
88
const bool _kReleaseMode = bool.fromEnvironment('dart.vm.product');

0 commit comments

Comments
 (0)