remove extension field checks

follow-up from: https://dart-review.googlesource.com/c/sdk/+/109322/3/pkg/analyzer/lib/src/dart/resolver/method_invocation_resolver.dart#241

and some test renames

Change-Id: Ia22768ed60cf85a0b3d6244ff044ff31af17aad6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109680
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>

Author: pq

pkg/analyzer/lib/src/dart/resolver/method_invocation_resolver.dart

@@ -246,9 +246,6 @@ class MethodInvocationResolver {
         for (var accessor in extension.accessors) {
           checkElement(accessor, extension);
         }
-        for (var field in extension.fields) {
-          checkElement(field, extension);
-        }
         for (var method in extension.methods) {
           checkElement(method, extension);
         }

pkg/analyzer/test/src/dart/resolution/extension_method_test.dart

@@ -23,7 +23,7 @@ class ExtensionMethodTest extends DriverResolutionTest {
     ..contextFeatures = new FeatureSet.forTesting(
         sdkVersion: '2.3.0', additionalFeatures: [Feature.extension_methods]);
 
-  test_more_specific_than_platform() async {
+  test_method_moreSpecificThanPlatform() async {
     //
     // An extension with on type clause T1 is more specific than another
     // extension with on type clause T2 iff
@@ -60,15 +60,7 @@ f() {
     expect(invocation.methodName.staticElement.library.isDartCore, isFalse);
   }
 
-  test_multipleExtensions() async {
-    await assertNoErrorsInCode('''
-class A {}
-extension E1 on A {}
-extension E2 on A {}
-''');
-  }
-
-  test_no_match() async {
+  test_method_noMatch() async {
     await assertErrorCodesInCode(r'''
 class B { }
 
@@ -83,7 +75,7 @@ f() {
 ''', [StaticTypeWarningCode.UNDEFINED_METHOD]);
   }
 
-  test_noMostSpecificExtension() async {
+  test_method_noMostSpecificExtension() async {
     await assertErrorsInCode('''
 class A { }
 
@@ -104,7 +96,7 @@ f() {
     ]);
   }
 
-  test_one_match() async {
+  test_method_oneMatch() async {
     await assertNoErrorsInCode('''
 class B { }
 
@@ -123,38 +115,7 @@ f() {
     expect(invocation.methodName.staticElement, declaration.declaredElement);
   }
 
-  test_specific_subtype_match_platform() async {
-    newFile('/test/lib/core.dart', content: '''
-library dart.core;
-
-class Core { }
-
-class Core2 extends Core { }
-''');
-
-    await assertNoErrorsInCode('''
-import 'core.dart';
-
-extension Core_Ext on Core {
-  void a() { }
-}
-
-extension Core2_Ext on Core2 {
-  void /*2*/ a() => 0;
-}
-
-f() {
-  Core2 c = Core2();
-  c.a();
-}
-''');
-
-    var invocation = findNode.methodInvocation('c.a()');
-    var declaration = findNode.methodDeclaration('void /*2*/ a()');
-    expect(invocation.methodName.staticElement, declaration.declaredElement);
-  }
-
-  test_specificSubtype_match_local() async {
+  test_method_specificSubtypeMatchLocal() async {
     await assertNoErrorsInCode('''
 class A { }
 
@@ -180,7 +141,7 @@ f() {
   }
 
   @failingTest
-  test_specificSubtype_match_local_generics() async {
+  test_method_specificSubtypeMatchLocalGenerics() async {
     await assertNoErrorsInCode('''
 class A<T> { }
 
@@ -207,4 +168,43 @@ main() {
     var declaration = findNode.methodDeclaration('void /*2*/ f(T x)');
     expect(invocation.methodName.staticElement, declaration.declaredElement);
   }
+
+  test_method_specificSubtypeMatchPlatform() async {
+    newFile('/test/lib/core.dart', content: '''
+library dart.core;
+
+class Core { }
+
+class Core2 extends Core { }
+''');
+
+    await assertNoErrorsInCode('''
+import 'core.dart';
+
+extension Core_Ext on Core {
+  void a() { }
+}
+
+extension Core2_Ext on Core2 {
+  void /*2*/ a() => 0;
+}
+
+f() {
+  Core2 c = Core2();
+  c.a();
+}
+''');
+
+    var invocation = findNode.methodInvocation('c.a()');
+    var declaration = findNode.methodDeclaration('void /*2*/ a()');
+    expect(invocation.methodName.staticElement, declaration.declaredElement);
+  }
+
+  test_multipleExtensions() async {
+    await assertNoErrorsInCode('''
+class A {}
+extension E1 on A {}
+extension E2 on A {}
+''');
+  }
 }