[3.0 alpha] Remove error for use of the List default constructor

Contributes to #49529

Change-Id: I65d147aa8f5f692df00663f5fac024351da7aaa7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/272161
Commit-Queue: Johnni Winther <[email protected]>
Reviewed-by: Jens Johansen <[email protected]>

Author: johnniwinther

pkg/_fe_analyzer_shared/lib/src/messages/codes_generated.dart

@@ -2218,16 +2218,6 @@ const MessageCode messageDeclaredMemberConflictsWithOverriddenMembersCause =
         severity: Severity.context,
         problemMessage: r"""This is one of the overridden members.""");
 
-// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
-const Code<Null> codeDefaultListConstructorError =
-    messageDefaultListConstructorError;
-
-// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
-const MessageCode messageDefaultListConstructorError = const MessageCode(
-    "DefaultListConstructorError",
-    problemMessage: r"""Can't use the default List constructor.""",
-    correctionMessage: r"""Try using List.filled instead.""");
-
 // DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
 const Template<Message Function(String name)>
     templateDefaultValueInRedirectingFactoryConstructor =

pkg/front_end/lib/src/fasta/type_inference/inference_visitor.dart

@@ -1183,12 +1183,6 @@ class InferenceVisitorImpl extends InferenceVisitorBase
           node, typeSchemaEnvironment, helper.uri,
           inferred: true);
     }
-    if (isNonNullableByDefault) {
-      if (node.target == coreTypes.listDefaultConstructor) {
-        resultNode = helper.wrapInProblem(node,
-            messageDefaultListConstructorError, node.fileOffset, noLength);
-      }
-    }
     return new ExpressionInferenceResult(
         result.inferredType, result.applyResult(resultNode));
   }
@@ -1244,13 +1238,6 @@ class InferenceVisitorImpl extends InferenceVisitorBase
     node.hasBeenInferred = true;
     Expression resultNode = node;
 
-    if (isNonNullableByDefault) {
-      if (node.target == coreTypes.listDefaultConstructor) {
-        resultNode = helper.wrapInProblem(node,
-            messageDefaultListConstructorError, node.fileOffset, noLength);
-      }
-    }
-
     return new ExpressionInferenceResult(
         result.inferredType, result.applyResult(resultNode));
   }
@@ -1306,12 +1293,6 @@ class InferenceVisitorImpl extends InferenceVisitorBase
         isConst: node.isConst, staticTarget: node.target);
     node.hasBeenInferred = true;
     Expression resultNode = node;
-    if (isNonNullableByDefault) {
-      if (node.target == coreTypes.listDefaultConstructor) {
-        resultNode = helper.wrapInProblem(node,
-            messageDefaultListConstructorError, node.fileOffset, noLength);
-      }
-    }
     return new ExpressionInferenceResult(
         result.inferredType, result.applyResult(resultNode));
   }

pkg/front_end/messages.status

@@ -181,10 +181,6 @@ CyclicClassHierarchy/script2: Fail # We report an error for each class involved
 CyclicRedirectingFactoryConstructors/part_wrapped_script: Fail # Error is reported for each factory involved in the cycle.
 CyclicRedirectingFactoryConstructors/script: Fail # Error is reported for each factory involved in the cycle.
 CyclicTypedef/example: Fail
-DefaultListConstructorError/analyzerCode: Fail
-DefaultListConstructorError/example: Fail
-DefaultListConstructorWarning/analyzerCode: Fail
-DefaultListConstructorWarning/example: Fail
 DeferredAfterPrefix/example: Fail
 DeferredExtensionImport/analyzerCode: Fail
 DeferredExtensionImport/part_wrapped_script: Fail

pkg/front_end/messages.yaml

@@ -5336,10 +5336,6 @@ JsInteropStaticInteropTrustTypesUsageNotAllowed:
   problemMessage: "JS interop class '#name' has an `@trustTypes` annotation, but `@trustTypes` is only supported within the sdk."
   correctionMessage: "Try removing the `@trustTypes` annotation."
 
-DefaultListConstructorError:
-  problemMessage: "Can't use the default List constructor."
-  correctionMessage: "Try using List.filled instead."
-
 NonNullableInNullAware:
   problemMessage: "Operand of null-aware operation '#name' has type '#type' which excludes null."
   severity: WARNING

pkg/front_end/testcases/nnbd/list_constructor.dart

@@ -182,9 +182,6 @@ class CoreTypes {
 
   late final Class listClass = index.getClass('dart:core', 'List');
 
-  late final Procedure listDefaultConstructor =
-      index.getProcedure('dart:core', 'List', '');
-
   late final Procedure listFromConstructor =
       index.getProcedure('dart:core', 'List', 'from');