[analyzer] DEPRECATED_MEMBER_USE message which ends with period.

Fixes #50518

Change-Id: I5c22eb73133b5591ca3b4ea4c63823fcab0935c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/271020
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>

Author: asashour

pkg/analyzer/lib/src/dart/error/hint_codes.g.dart

@@ -188,7 +188,7 @@ class HintCode extends AnalyzerErrorCode {
   static const HintCode DEPRECATED_MEMBER_USE_FROM_SAME_PACKAGE_WITH_MESSAGE =
       HintCode(
     'DEPRECATED_MEMBER_USE_FROM_SAME_PACKAGE',
-    "'{0}' is deprecated and shouldn't be used. {1}.",
+    "'{0}' is deprecated and shouldn't be used. {1}",
     correctionMessage:
         "Try replacing the use of the deprecated member with the replacement.",
     hasPublishedDocs: true,
@@ -200,7 +200,7 @@ class HintCode extends AnalyzerErrorCode {
   ///  1: message details
   static const HintCode DEPRECATED_MEMBER_USE_WITH_MESSAGE = HintCode(
     'DEPRECATED_MEMBER_USE',
-    "'{0}' is deprecated and shouldn't be used. {1}.",
+    "'{0}' is deprecated and shouldn't be used. {1}",
     correctionMessage:
         "Try replacing the use of the deprecated member with the replacement.",
     hasPublishedDocs: true,

pkg/analyzer/lib/src/error/deprecated_member_use_verifier.dart

@@ -307,7 +307,8 @@ class DeprecatedMemberUseVerifier extends BaseDeprecatedMemberUseVerifier {
       AstNode errorNode, Element element, String displayName, String? message) {
     var library = element is LibraryElement ? element : element.library;
 
-    if (message == null || message.isEmpty) {
+    message = message?.trim();
+    if (message == null || message.isEmpty || message == '.') {
       _errorReporter.reportErrorForNode(
         _isLibraryInWorkspacePackage(library)
             ? HintCode.DEPRECATED_MEMBER_USE_FROM_SAME_PACKAGE
@@ -316,6 +317,11 @@ class DeprecatedMemberUseVerifier extends BaseDeprecatedMemberUseVerifier {
         [displayName],
       );
     } else {
+      if (!message.endsWith('.') &&
+          !message.endsWith('?') &&
+          !message.endsWith('!')) {
+        message = '$message.';
+      }
       _errorReporter.reportErrorForNode(
         _isLibraryInWorkspacePackage(library)
             ? HintCode.DEPRECATED_MEMBER_USE_FROM_SAME_PACKAGE_WITH_MESSAGE

pkg/analyzer/messages.yaml

@@ -17901,7 +17901,7 @@ HintCode:
       should indicate what code to use in place of the deprecated code.
   DEPRECATED_MEMBER_USE_WITH_MESSAGE:
     sharedName: DEPRECATED_MEMBER_USE
-    problemMessage: "'{0}' is deprecated and shouldn't be used. {1}."
+    problemMessage: "'{0}' is deprecated and shouldn't be used. {1}"
     correctionMessage: Try replacing the use of the deprecated member with the replacement.
     hasPublishedDocs: true
     comment: |-
@@ -17938,7 +17938,7 @@ HintCode:
       in place of the deprecated code.
   DEPRECATED_MEMBER_USE_FROM_SAME_PACKAGE_WITH_MESSAGE:
     sharedName: DEPRECATED_MEMBER_USE_FROM_SAME_PACKAGE
-    problemMessage: "'{0}' is deprecated and shouldn't be used. {1}."
+    problemMessage: "'{0}' is deprecated and shouldn't be used. {1}"
     correctionMessage: Try replacing the use of the deprecated member with the replacement.
     hasPublishedDocs: true
     comment: |-

pkg/analyzer/test/src/diagnostics/deprecated_member_use_test.dart

@@ -265,7 +265,28 @@ void f(A a) {
   a.foo();
 }
 ''', [
-      error(HintCode.DEPRECATED_MEMBER_USE_WITH_MESSAGE, 48, 3),
+      error(HintCode.DEPRECATED_MEMBER_USE_WITH_MESSAGE, 48, 3,
+          text: "'foo' is deprecated and shouldn't be used. 0.9."),
+    ]);
+  }
+
+  test_methodInvocation_withMessage_dot() async {
+    newFile('$workspaceRootPath/aaa/lib/a.dart', r'''
+class A {
+  @Deprecated('0.9.')
+  void foo() {}
+}
+''');
+
+    await assertErrorsInCode(r'''
+import 'package:aaa/a.dart';
+
+void f(A a) {
+  a.foo();
+}
+''', [
+      error(HintCode.DEPRECATED_MEMBER_USE_WITH_MESSAGE, 48, 3,
+          text: "'foo' is deprecated and shouldn't be used. 0.9."),
     ]);
   }
 
@@ -932,7 +953,63 @@ class A {
 }
 ''', [
       error(
-          HintCode.DEPRECATED_MEMBER_USE_FROM_SAME_PACKAGE_WITH_MESSAGE, 47, 1),
+          HintCode.DEPRECATED_MEMBER_USE_FROM_SAME_PACKAGE_WITH_MESSAGE, 47, 1,
+          text: "'m' is deprecated and shouldn't be used. 0.9."),
+    ]);
+  }
+
+  test_methodInvocation_constructor_dot() async {
+    await assertErrorsInCode(r'''
+class A {
+  @Deprecated('0.9.')
+  m() {}
+  n() {m();}
+}
+''', [
+      error(
+          HintCode.DEPRECATED_MEMBER_USE_FROM_SAME_PACKAGE_WITH_MESSAGE, 48, 1,
+          text: "'m' is deprecated and shouldn't be used. 0.9."),
+    ]);
+  }
+
+  test_methodInvocation_constructor_exclamationMark() async {
+    await assertErrorsInCode(r'''
+class A {
+  @Deprecated(' Really! ')
+  m() {}
+  n() {m();}
+}
+''', [
+      error(
+          HintCode.DEPRECATED_MEMBER_USE_FROM_SAME_PACKAGE_WITH_MESSAGE, 53, 1,
+          text: "'m' is deprecated and shouldn't be used. Really!"),
+    ]);
+  }
+
+  test_methodInvocation_constructor_onlyDot() async {
+    await assertErrorsInCode(r'''
+class A {
+  @Deprecated('.')
+  m() {}
+  n() {m();}
+}
+''', [
+      error(HintCode.DEPRECATED_MEMBER_USE_FROM_SAME_PACKAGE, 45, 1,
+          text: "'m' is deprecated and shouldn't be used."),
+    ]);
+  }
+
+  test_methodInvocation_constructor_questionMark() async {
+    await assertErrorsInCode(r'''
+class A {
+  @Deprecated('Are you sure?')
+  m() {}
+  n() {m();}
+}
+''', [
+      error(
+          HintCode.DEPRECATED_MEMBER_USE_FROM_SAME_PACKAGE_WITH_MESSAGE, 57, 1,
+          text: "'m' is deprecated and shouldn't be used. Are you sure?"),
     ]);
   }
 

pkg/analyzer/tool/diagnostics/diagnostics.md

@@ -3885,7 +3885,7 @@ name: example
 
 _'{0}' is deprecated and shouldn't be used._
 
-_'{0}' is deprecated and shouldn't be used. {1}._
+_'{0}' is deprecated and shouldn't be used. {1}_
 
 #### Description
 
@@ -3912,7 +3912,7 @@ should indicate what code to use in place of the deprecated code.
 
 _'{0}' is deprecated and shouldn't be used._
 
-_'{0}' is deprecated and shouldn't be used. {1}._
+_'{0}' is deprecated and shouldn't be used. {1}_
 
 #### Description