remove analyzer/server support for the default List constructor

See: #49529

Change-Id: Id52ac534405b3552812e6bb8ce49e09c60cbdfd9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276770
Commit-Queue: Phil Quitslund <[email protected]>
Reviewed-by: Samuel Rawlins <[email protected]>

Author: pq

pkg/analysis_server/lib/src/services/correction/assist.dart

@@ -151,11 +151,6 @@ class DartAssistKind {
     DartAssistKindPriority.DEFAULT,
     'Convert to an int literal',
   );
-  static const CONVERT_TO_LIST_LITERAL = AssistKind(
-    'dart.assist.convert.toListLiteral',
-    DartAssistKindPriority.DEFAULT,
-    'Convert to list literal',
-  );
   static const CONVERT_TO_MAP_LITERAL = AssistKind(
     'dart.assist.convert.toMapLiteral',
     DartAssistKindPriority.DEFAULT,

pkg/analysis_server/lib/src/services/correction/assist_internal.dart

@@ -31,7 +31,6 @@ import 'package:analysis_server/src/services/correction/dart/convert_to_expressi
 import 'package:analysis_server/src/services/correction/dart/convert_to_field_parameter.dart';
 import 'package:analysis_server/src/services/correction/dart/convert_to_generic_function_syntax.dart';
 import 'package:analysis_server/src/services/correction/dart/convert_to_int_literal.dart';
-import 'package:analysis_server/src/services/correction/dart/convert_to_list_literal.dart';
 import 'package:analysis_server/src/services/correction/dart/convert_to_map_literal.dart';
 import 'package:analysis_server/src/services/correction/dart/convert_to_multiline_string.dart';
 import 'package:analysis_server/src/services/correction/dart/convert_to_normal_parameter.dart';
@@ -112,7 +111,6 @@ class AssistProcessor extends BaseProcessor {
     ConvertToFieldParameter.new,
     ConvertToGenericFunctionSyntax.new,
     ConvertToIntLiteral.new,
-    ConvertToListLiteral.new,
     ConvertToMapLiteral.new,
     ConvertToMultilineString.new,
     ConvertToNormalParameter.new,

pkg/analysis_server/lib/src/services/correction/dart/convert_to_list_literal.dart

@@ -341,8 +341,9 @@ CompileTimeErrorCode.CONTINUE_LABEL_ON_SWITCH:
 CompileTimeErrorCode.COULD_NOT_INFER:
   status: needsEvaluation
 CompileTimeErrorCode.DEFAULT_LIST_CONSTRUCTOR:
-  status: hasFix
-  issue: https://github.com/dart-lang/sdk/issues/48644
+  status: noFix
+  notes: |-
+    Removed in Dart 3.0.
 CompileTimeErrorCode.DEFAULT_VALUE_IN_REDIRECTING_FACTORY_CONSTRUCTOR:
   status: needsEvaluation
 CompileTimeErrorCode.DEFAULT_VALUE_ON_REQUIRED_PARAMETER:

pkg/analysis_server/lib/src/services/correction/dart/replace_with_filled.dart

@@ -518,16 +518,6 @@ class DartFixKind {
     DartFixKindPriority.IN_FILE,
     'Convert to line documentation comments everywhere in file',
   );
-  static const CONVERT_TO_LIST_LITERAL = FixKind(
-    'dart.fix.convert.toListLiteral',
-    DartFixKindPriority.DEFAULT,
-    'Convert to list literal',
-  );
-  static const CONVERT_TO_LIST_LITERAL_MULTI = FixKind(
-    'dart.fix.convert.toListLiteral.multi',
-    DartFixKindPriority.IN_FILE,
-    'Convert to list literals everywhere in file',
-  );
   static const CONVERT_TO_MAP_LITERAL = FixKind(
     'dart.fix.convert.toMapLiteral',
     DartFixKindPriority.DEFAULT,
@@ -1403,11 +1393,6 @@ class DartFixKind {
     DartFixKindPriority.IN_FILE,
     "Replace ':'s with '='s everywhere in file",
   );
-  static const REPLACE_WITH_FILLED = FixKind(
-    'dart.fix.replace.finalWithListFilled',
-    DartFixKindPriority.DEFAULT,
-    "Replace with 'List.filled'",
-  );
   static const REPLACE_FINAL_WITH_CONST = FixKind(
     'dart.fix.replace.finalWithConst',
     DartFixKindPriority.DEFAULT,

pkg/analysis_server/lib/src/services/correction/error_fix_status.yaml

@@ -62,7 +62,6 @@ import 'package:analysis_server/src/services/correction/dart/convert_to_generic_
 import 'package:analysis_server/src/services/correction/dart/convert_to_if_null.dart';
 import 'package:analysis_server/src/services/correction/dart/convert_to_initializing_formal.dart';
 import 'package:analysis_server/src/services/correction/dart/convert_to_int_literal.dart';
-import 'package:analysis_server/src/services/correction/dart/convert_to_list_literal.dart';
 import 'package:analysis_server/src/services/correction/dart/convert_to_map_literal.dart';
 import 'package:analysis_server/src/services/correction/dart/convert_to_named_arguments.dart';
 import 'package:analysis_server/src/services/correction/dart/convert_to_null_aware.dart';
@@ -186,7 +185,6 @@ import 'package:analysis_server/src/services/correction/dart/replace_with_bracke
 import 'package:analysis_server/src/services/correction/dart/replace_with_conditional_assignment.dart';
 import 'package:analysis_server/src/services/correction/dart/replace_with_eight_digit_hex.dart';
 import 'package:analysis_server/src/services/correction/dart/replace_with_extension_name.dart';
-import 'package:analysis_server/src/services/correction/dart/replace_with_filled.dart';
 import 'package:analysis_server/src/services/correction/dart/replace_with_identifier.dart';
 import 'package:analysis_server/src/services/correction/dart/replace_with_interpolation.dart';
 import 'package:analysis_server/src/services/correction/dart/replace_with_is_empty.dart';
@@ -530,7 +528,6 @@ class FixProcessor extends BaseProcessor {
       RemoveOperator.new,
     ],
     LintNames.prefer_collection_literals: [
-      ConvertToListLiteral.new,
       ConvertToMapLiteral.new,
       ConvertToSetLiteral.new,
     ],
@@ -955,10 +952,6 @@ class FixProcessor extends BaseProcessor {
     CompileTimeErrorCode.CONST_WITH_NON_TYPE: [
       ChangeTo.classOrMixin,
     ],
-    CompileTimeErrorCode.DEFAULT_LIST_CONSTRUCTOR: [
-      ConvertToListLiteral.new,
-      ReplaceWithFilled.new,
-    ],
     CompileTimeErrorCode.DEFAULT_VALUE_ON_REQUIRED_PARAMETER: [
       RemoveDefaultValue.new,
       RemoveRequired.new,
@@ -1459,7 +1452,7 @@ class FixProcessor extends BaseProcessor {
       RemoveComparison.new,
     ],
     HintCode.UNNECESSARY_QUESTION_MARK: [
-      RemoveQuestionMark.new
+      RemoveQuestionMark.new,
     ],
 //    HintCode.UNNECESSARY_TYPE_CHECK_FALSE: [
 // TODO(brianwilkerson) Add a fix to remove the type check.

pkg/analysis_server/lib/src/services/correction/fix.dart

@@ -32,7 +32,6 @@ import 'convert_to_field_parameter_test.dart' as convert_to_field_parameter;
 import 'convert_to_for_element_test.dart' as convert_to_for_element;
 import 'convert_to_if_element_test.dart' as convert_to_if_element;
 import 'convert_to_int_literal_test.dart' as convert_to_int_literal;
-import 'convert_to_list_literal_test.dart' as convert_to_list_literal;
 import 'convert_to_map_literal_test.dart' as convert_to_map_literal;
 import 'convert_to_multiline_string_test.dart' as convert_to_multiline_string;
 import 'convert_to_normal_parameter_test.dart' as convert_to_normal_parameter;
@@ -118,7 +117,6 @@ void main() {
     convert_to_for_element.main();
     convert_to_if_element.main();
     convert_to_int_literal.main();
-    convert_to_list_literal.main();
     convert_to_map_literal.main();
     convert_to_multiline_string.main();
     convert_to_normal_parameter.main();