Move runtime js files down to lib/runtime/dart

Prepare for writing all the runtime in Dart:
- Move js runtime files to lib/runtime/dart (dart_runtime.js ->
dart/_runtime.js),
- Use rest params instead of arguments slicing in a couple of places.

BUG=dart-archive/dev_compiler#310
[email protected]

Review URL: https://codereview.chromium.org/1413683006 .

Author: Olivier Chafik

pkg/dev_compiler/lib/runtime/_classes.js renamed to pkg/dev_compiler/lib/runtime/dart/_classes.js

@@ -10,12 +10,12 @@
  */
 
 // TODO(leafp): Consider splitting some of this out.
-dart_library.library('dart_runtime/_classes', null, /* Imports */[
+dart_library.library('dart/_classes', null, /* Imports */[
 ], /* Lazy Imports */[
   'dart/core',
   'dart/_interceptors',
-  'dart_runtime/_types',
-  'dart_runtime/_rtti',
+  'dart/_types',
+  'dart/_rtti',
 ], function(exports, core, _interceptors, types, rtti) {
   'use strict';
 
@@ -30,8 +30,6 @@ dart_library.library('dart_runtime/_classes', null, /* Imports */[
   const getOwnPropertyDescriptor = Object.getOwnPropertyDescriptor;
   const getOwnPropertySymbols = Object.getOwnPropertySymbols;
 
-  const slice = [].slice;
-
   /** The Symbol for storing type arguments on a specialized generic type. */
   const _mixins = Symbol('mixins');
   const _implements = Symbol('implements');
@@ -48,15 +46,14 @@ dart_library.library('dart_runtime/_classes', null, /* Imports */[
    * For each mixin, we only take its own properties, not anything from its
    * superclass (prototype).
    */
-  function mixin(base/*, ...mixins*/) {
+  function mixin(base, ...mixins) {
     // Create an initializer for the mixin, so when derived constructor calls
     // super, we can correctly initialize base and mixins.
-    let mixins = slice.call(arguments, 1);
 
     // Create a class that will hold all of the mixin methods.
     class Mixin extends base {
       // Initializer method: run mixin initializers, then the base.
-      [base.name](/*...args*/) {
+      [base.name](...args) {
         // Run mixin initializers. They cannot have arguments.
         // Run them backwards so most-derived mixin is initialized first.
         for (let i = mixins.length - 1; i >= 0; i--) {
@@ -66,7 +63,7 @@ dart_library.library('dart_runtime/_classes', null, /* Imports */[
         }
         // Run base initializer.
         let init = base.prototype[base.name];
-        if (init) init.apply(this, arguments);
+        if (init) init.apply(this, args);
       }
     }
     // Copy each mixin's methods, with later ones overwriting earlier entries.
@@ -113,11 +110,10 @@ dart_library.library('dart_runtime/_classes', null, /* Imports */[
       throwInternalError('must have at least one generic type argument');
     }
     let resultMap = new Map();
-    function makeGenericType(/*...arguments*/) {
-      if (arguments.length != length && arguments.length != 0) {
+    function makeGenericType(...args) {
+      if (args.length != length && args.length != 0) {
         throwInternalError('requires ' + length + ' or 0 type arguments');
       }
-      let args = slice.call(arguments);
       while (args.length < length) args.push(types.dynamic);
 
       let value = resultMap;
@@ -366,7 +362,7 @@ dart_library.library('dart_runtime/_classes', null, /* Imports */[
    */
   // TODO(jmesserly): essentially this gives two names to the same method.
   // This benefit is roughly equivalent call performance either way, but the
-  // cost is we need to call defineExtensionMembers any time a subclass 
+  // cost is we need to call defineExtensionMembers any time a subclass
   // overrides one of these methods.
   function defineExtensionMembers(type, methodNames) {
     let proto = type.prototype;

pkg/dev_compiler/lib/runtime/_errors.js renamed to pkg/dev_compiler/lib/runtime/dart/_errors.js

@@ -7,9 +7,9 @@
  *
  */
 
-dart_library.library('dart_runtime/_errors', null, /* Imports */[
+dart_library.library('dart/_errors', null, /* Imports */[
 ], /* Lazy Imports */[
-  'dart_runtime/_operations',
+  'dart/_operations',
   'dart/core',
   'dart/_js_helper'
 ], function(exports, operations, core, _js_helper) {

pkg/dev_compiler/lib/runtime/dart/_foreign_helper.js

@@ -1,5 +1,5 @@
 dart_library.library('dart/_foreign_helper', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core'
 ], /* Lazy imports */[
 ], function(exports, dart, core) {

pkg/dev_compiler/lib/runtime/_generators.js renamed to pkg/dev_compiler/lib/runtime/dart/_generators.js

@@ -14,9 +14,9 @@
  * Inspired by `co`: https://github.com/tj/co/blob/master/index.js, which is a
  * stepping stone for proposed ES7 async/await, and uses ES6 Promises.
  */
-dart_library.library('dart_runtime/_generators', null, /* Imports */[
+dart_library.library('dart/_generators', null, /* Imports */[
 ], /* Lazy Imports */[
-  'dart_runtime/_operations',
+  'dart/_operations',
   'dart/_js_helper',
   'dart/core',
   'dart/collection',

pkg/dev_compiler/lib/runtime/dart/_interceptors.js

@@ -1,5 +1,5 @@
 dart_library.library('dart/_interceptors', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core',
   'dart/_internal',
   'dart/collection',

pkg/dev_compiler/lib/runtime/dart/_internal.js

@@ -1,5 +1,5 @@
 dart_library.library('dart/_internal', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core',
   'dart/collection'
 ], /* Lazy imports */[

pkg/dev_compiler/lib/runtime/dart/_isolate_helper.js

@@ -1,5 +1,5 @@
 dart_library.library('dart/_isolate_helper', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core',
   'dart/_interceptors',
   'dart/_js_helper',

pkg/dev_compiler/lib/runtime/dart/_js_embedded_names.js

@@ -1,5 +1,5 @@
 dart_library.library('dart/_js_embedded_names', null, /* Imports */[
-  "dart_runtime/dart"
+  "dart/_runtime"
 ], /* Lazy imports */[
 ], function(exports, dart) {
   'use strict';

pkg/dev_compiler/lib/runtime/dart/_js_helper.js

@@ -1,5 +1,5 @@
 dart_library.library('dart/_js_helper', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core',
   'dart/collection',
   'dart/_interceptors',

pkg/dev_compiler/lib/runtime/dart/_js_mirrors.js

@@ -1,5 +1,5 @@
 dart_library.library('dart/_js_mirrors', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/_internal',
   'dart/core',
   'dart/mirrors'

pkg/dev_compiler/lib/runtime/dart/_js_primitives.js

@@ -1,5 +1,5 @@
 dart_library.library('dart/_js_primitives', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core'
 ], /* Lazy imports */[
 ], function(exports, dart, core) {

pkg/dev_compiler/lib/runtime/dart/_native_typed_data.js

@@ -1,5 +1,5 @@
 dart_library.library('dart/_native_typed_data', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core',
   'dart/typed_data',
   'dart/_js_helper',

pkg/dev_compiler/lib/runtime/_operations.js renamed to pkg/dev_compiler/lib/runtime/dart/_operations.js

@@ -5,16 +5,16 @@
 /* This library defines runtime operations on objects used by the code
  * generator.
  */
-dart_library.library('dart_runtime/_operations', null, /* Imports */[
+dart_library.library('dart/_operations', null, /* Imports */[
 ], /* Lazy Imports */[
   'dart/async',
   'dart/collection',
   'dart/core',
   'dart/_js_helper',
-  'dart_runtime/_classes',
-  'dart_runtime/_errors',
-  'dart_runtime/_rtti',
-  'dart_runtime/_types'
+  'dart/_classes',
+  'dart/_errors',
+  'dart/_rtti',
+  'dart/_types'
 ], function(exports, async, collection, core, _js_helper, classes, errors, rtti,
             types) {
   'use strict';
@@ -25,8 +25,6 @@ dart_library.library('dart_runtime/_operations', null, /* Imports */[
   const getOwnPropertyNames = Object.getOwnPropertyNames;
   const hasOwnProperty = Object.prototype.hasOwnProperty;
 
-  const slice = [].slice;
-
   function _canonicalFieldName(obj, name, args, displayName) {
     name = classes.canonicalMember(obj, name);
     if (name) return name;
@@ -143,8 +141,7 @@ dart_library.library('dart_runtime/_operations', null, /* Imports */[
     throwNoSuchMethod(obj, name, args, f);
   }
 
-  function dcall(f/*, ...args*/) {
-    let args = slice.call(arguments, 1);
+  function dcall(f, ...args) {
     let ftype = rtti.read(f);
     return checkAndCall(f, ftype, void 0, args, 'call');
   }
@@ -158,8 +155,8 @@ dart_library.library('dart_runtime/_operations', null, /* Imports */[
     return checkAndCall(f, ftype, obj, args, displayName);
   }
 
-  function dsend(obj, method/*, ...args*/) {
-    return callMethod(obj, method, slice.call(arguments, 2), method);
+  function dsend(obj, method, ...args) {
+    return callMethod(obj, method, args, method);
   }
   exports.dsend = dsend;
 
@@ -335,8 +332,7 @@ dart_library.library('dart_runtime/_operations', null, /* Imports */[
    * Will call each successive callback, unless one returns null, which stops
    * the sequence.
    */
-  function nullSafe(obj /*, ...callbacks*/) {
-    let callbacks = slice.call(arguments, 1);
+  function nullSafe(obj, ...callbacks) {
     if (obj == null) return obj;
     for (const callback of callbacks) {
       obj = callback(obj);

pkg/dev_compiler/lib/runtime/_rtti.js renamed to pkg/dev_compiler/lib/runtime/dart/_rtti.js

@@ -6,19 +6,17 @@
  * runtime types.
 */
 
-dart_library.library('dart_runtime/_rtti', null, /* Imports */[
+dart_library.library('dart/_rtti', null, /* Imports */[
 ], /* Lazy Imports */[
   'dart/core',
-  'dart_runtime/_types'
+  'dart/_types'
 ], function(exports, core, types) {
   'use strict';
 
   const defineLazyProperty = dart_utils.defineLazyProperty;
 
   const defineProperty = Object.defineProperty;
 
-  const slice = [].slice;
-
   /**
    * Runtime type information.  This module defines the mapping from
    * runtime objects to their runtime type information.  See the types
@@ -63,22 +61,20 @@ dart_library.library('dart_runtime/_rtti', null, /* Imports */[
    * Note that since we are producing a type for a concrete function,
    * it is sound to use the definite arrow type.
    */
-  function fn(closure/* ...args*/) {
+  function fn(closure, ...args) {
     // Closure and a lazy type constructor
-    if (arguments.length == 2) {
-      defineLazyProperty(closure, _runtimeType, {get : arguments[1]});
+    if (args.length == 1) {
+      defineLazyProperty(closure, _runtimeType, {get : args[0]});
       return closure;
     }
     let t;
-    if (arguments.length == 1) {
+    if (args.length == 0) {
       // No type arguments, it's all dynamic
-      let len = closure.length;
-      let args = Array.apply(null, new Array(len)).map(() => types.dynamic);
-      t = types.definiteFunctionType(types.dynamic, args);
+      t = types.definiteFunctionType(
+        types.dynamic, Array(closure.length).fill(types.dynamic));
     } else {
       // We're passed the piecewise components of the function type,
       // construct it.
-      let args = slice.call(arguments, 1);
       t = types.definiteFunctionType.apply(null, args);
     }
     tag(closure, t);
@@ -117,8 +113,7 @@ dart_library.library('dart_runtime/_rtti', null, /* Imports */[
 
   function getFunctionType(obj) {
     // TODO(vsm): Encode this properly on the function for Dart-generated code.
-    let args =
-      Array.apply(null, new Array(obj.length)).map(() => types.dynamic);
+    let args = Array(obj.length).fill(types.dynamic);
     return types.definiteFunctionType(types.bottom, args);
   }
 
@@ -153,7 +148,7 @@ dart_library.library('dart_runtime/_rtti', null, /* Imports */[
   }
   exports.LazyTagged = LazyTagged;
 
-  function read(value) { 
+  function read(value) {
     return value[_runtimeType];
   }
   exports.read = read;

pkg/dev_compiler/lib/runtime/dart_runtime.js renamed to pkg/dev_compiler/lib/runtime/dart/_runtime.js

@@ -2,13 +2,13 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-dart_library.library('dart_runtime/dart', null, /* Imports */[
-  'dart_runtime/_classes',
-  'dart_runtime/_errors',
-  'dart_runtime/_generators',
-  'dart_runtime/_operations',
-  'dart_runtime/_rtti',
-  'dart_runtime/_types',
+dart_library.library('dart/_runtime', null, /* Imports */[
+  'dart/_classes',
+  'dart/_errors',
+  'dart/_generators',
+  'dart/_operations',
+  'dart/_rtti',
+  'dart/_types',
 ], /* Lazy Imports */[
   'dart/_js_helper'
 ], function(exports, classes, errors, generators, operations, rtti, types,

pkg/dev_compiler/lib/runtime/_types.js renamed to pkg/dev_compiler/lib/runtime/dart/_types.js

@@ -5,11 +5,11 @@
 /* This library defines the representation of runtime types.
 */
 
-dart_library.library('dart_runtime/_types', null, /* Imports */[
+dart_library.library('dart/_types', null, /* Imports */[
 ], /* Lazy Imports */[
   'dart/core',
-  'dart_runtime/_classes',
-  'dart_runtime/_rtti'
+  'dart/_classes',
+  'dart/_rtti'
 ], function(exports, core, classes, rtti) {
   'use strict';
 

pkg/dev_compiler/lib/runtime/dart/async.js

@@ -1,5 +1,5 @@
 dart_library.library('dart/async', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core',
   'dart/_internal',
   'dart/collection'

pkg/dev_compiler/lib/runtime/dart/collection.js

@@ -1,5 +1,5 @@
 dart_library.library('dart/collection', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core'
 ], /* Lazy imports */[
   'dart/_internal',

pkg/dev_compiler/lib/runtime/dart/convert.js

@@ -1,5 +1,5 @@
 dart_library.library('dart/convert', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core',
   'dart/async',
   'dart/typed_data',

pkg/dev_compiler/lib/runtime/dart/core.js

@@ -1,5 +1,5 @@
 dart_library.library('dart/core', null, /* Imports */[
-  "dart_runtime/dart"
+  "dart/_runtime"
 ], /* Lazy imports */[
   'dart/_js_helper',
   'dart/_internal',

pkg/dev_compiler/lib/runtime/dart/isolate.js

@@ -1,5 +1,5 @@
 dart_library.library('dart/isolate', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core',
   'dart/async'
 ], /* Lazy imports */[

pkg/dev_compiler/lib/runtime/dart/js.js

@@ -1,5 +1,5 @@
 dart_library.library('dart/js', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core',
   'dart/collection',
   'dart/_js_helper'

pkg/dev_compiler/lib/runtime/dart/math.js

@@ -1,5 +1,5 @@
 dart_library.library('dart/math', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core'
 ], /* Lazy imports */[
   'dart/_js_helper'

pkg/dev_compiler/lib/runtime/dart/mirrors.js

@@ -1,5 +1,5 @@
 dart_library.library('dart/mirrors', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core'
 ], /* Lazy imports */[
   'dart/_js_mirrors'

pkg/dev_compiler/lib/runtime/dart/typed_data.js

@@ -1,5 +1,5 @@
 dart_library.library('dart/typed_data', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core'
 ], /* Lazy imports */[
   'dart/_native_typed_data'