[cfe] Add test for dynamic access in CFE/kernel code

Change-Id: I9cd5aec2bd9b455a099503ca3c55f61659145869
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171726
Reviewed-by: Dmitry Stefantsov <[email protected]>
Commit-Queue: Johnni Winther <[email protected]>

Author: johnniwinther

pkg/front_end/lib/src/base/processed_options.dart

@@ -561,8 +561,7 @@ class ProcessedOptions {
             templateCantReadFile.withArguments(uri, e.message), Severity.error);
       }
     } catch (e) {
-      Message message =
-          templateExceptionReadingFile.withArguments(uri, e.message);
+      Message message = templateExceptionReadingFile.withArguments(uri, '$e');
       reportWithoutLocation(message, Severity.error);
       // We throw a new exception to ensure that the message include the uri
       // that led to the exception. Exceptions in Uri don't include the

pkg/front_end/lib/src/fasta/builder/function_type_builder.dart

@@ -59,13 +59,13 @@ class FunctionTypeBuilder extends TypeBuilder {
     buffer.write("(");
     if (formals != null) {
       bool isFirst = true;
-      for (dynamic t in formals) {
+      for (FormalParameterBuilder t in formals) {
         if (!isFirst) {
           buffer.write(", ");
         } else {
           isFirst = false;
         }
-        buffer.write(t?.fullNameForErrors);
+        buffer.write(t.fullNameForErrors);
       }
     }
     buffer.write(") ->");

pkg/front_end/lib/src/fasta/command_line_reporting.dart

@@ -24,7 +24,7 @@ import 'package:_fe_analyzer_shared/src/util/colors.dart'
 import 'package:_fe_analyzer_shared/src/util/relativize.dart'
     show isWindows, relativizeUri;
 
-import 'package:kernel/ast.dart' show Location, TreeNode;
+import 'package:kernel/ast.dart' show Location, Source, TreeNode;
 
 import '../compute_platform_binaries_location.dart' show translateSdk;
 
@@ -43,7 +43,8 @@ const bool hideWarnings = false;
 /// Formats [message] as a string that is suitable for output from a
 /// command-line tool. This includes source snippets and different colors based
 /// on [severity].
-String format(LocatedMessage message, Severity severity, {Location location}) {
+String format(LocatedMessage message, Severity severity,
+    {Location location, Map<Uri, Source> uriToSource}) {
   try {
     int length = message.length;
     if (length < 1) {
@@ -85,7 +86,7 @@ String format(LocatedMessage message, Severity severity, {Location location}) {
       if (location?.line == TreeNode.noOffset) {
         location = null;
       }
-      String sourceLine = getSourceLine(location);
+      String sourceLine = getSourceLine(location, uriToSource);
       return formatErrorMessage(
           sourceLine, location, length, path, messageText);
     } else {

pkg/front_end/lib/src/fasta/messages.dart

@@ -4,7 +4,8 @@
 
 library fasta.messages;
 
-import 'package:kernel/ast.dart' show Library, Location, Component, TreeNode;
+import 'package:kernel/ast.dart'
+    show Library, Location, Component, Source, TreeNode;
 
 import 'compiler_context.dart' show CompilerContext;
 
@@ -21,10 +22,10 @@ Location getLocationFromUri(Uri uri, int charOffset) {
   return getLocation(uri, charOffset);
 }
 
-String getSourceLine(Location location) {
+String getSourceLine(Location location, [Map<Uri, Source> uriToSource]) {
   if (location == null) return null;
-  return CompilerContext.current.uriToSource[location.file]
-      ?.getTextLine(location.line);
+  uriToSource ??= CompilerContext.current.uriToSource;
+  return uriToSource[location.file]?.getTextLine(location.line);
 }
 
 Location getLocationFromNode(TreeNode node) {

pkg/front_end/test/spell_checking_list_tests.txt

@@ -126,6 +126,7 @@ compilations
 compiler's
 complement
 completers
+complicated
 confidence
 confident
 confirm
@@ -400,6 +401,7 @@ linebreaks
 lints
 linux
 listening
+listing
 literal2
 ln
 local1a
@@ -463,6 +465,7 @@ negatable
 newworld
 nil
 ninja
+noisy
 nondefault
 nonexisting
 noo