Skip to content

Commit a9fc9f7

Browse files
Clement Skaucommit-bot@chromium.org
Clement Skau
authored andcommitted
[SDK] Fixes run_appended_aotsnapshot_test on Windows.
Bug: #38974 Change-Id: I5fafb29252f20a536b5543d309ddeb4ccd3421ec Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122145 Auto-Submit: Clement Skau <[email protected]> Commit-Queue: Daco Harkes <[email protected]> Reviewed-by: Daco Harkes <[email protected]>
1 parent 22e249d commit a9fc9f7

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

runtime/tests/vm/dart/run_appended_aot_snapshot_test.dart

+3-2
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ Future<void> main(List<String> args) async {
6363
Map<String, String> environment = {'PATH': tmp};
6464
final runResult = await runBinary(
6565
'run appended aot snapshot from PATH', exeName, ['--child'],
66-
environment: environment);
66+
environment: environment, runInShell: true);
6767
expectOutput('Hello, Appended AOT', runResult);
6868
}
6969

@@ -76,7 +76,8 @@ Future<void> main(List<String> args) async {
7676
'run appended aot snapshot without extension',
7777
exeNameWithoutExt,
7878
['--child'],
79-
environment: environment);
79+
environment: environment,
80+
runInShell: true);
8081
expectOutput('Hello, Appended AOT', runResult);
8182
}
8283
});

runtime/tests/vm/dart/snapshot_test_helper.dart

+3-3
Original file line numberDiff line numberDiff line change
@@ -73,10 +73,10 @@ Future<Result> runGenSnapshot(String prefix, List<String> arguments) {
7373
}
7474

7575
Future<Result> runBinary(String prefix, String binary, List<String> arguments,
76-
{Map<String, String> environment}) async {
76+
{Map<String, String> environment, bool runInShell: false}) async {
7777
print("+ $binary " + arguments.join(" "));
78-
final processResult =
79-
await Process.run(binary, arguments, environment: environment);
78+
final processResult = await Process.run(binary, arguments,
79+
environment: environment, runInShell: runInShell);
8080
final result =
8181
new Result('[$prefix] ${binary} ${arguments.join(' ')}', processResult);
8282

0 commit comments

Comments
 (0)