Skip to content

Commit ac77af1

Browse files
rmacnak-googleCommit Queue
authored and
Commit Queue
committed
Group the GC tests into a common directory.
The makes it possible to run just these tests with `test.py vm/gc/`. Change-Id: Ied4aa0b2fb045c19b1aced68f58a1ef195a5df8a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/311145 Reviewed-by: Alexander Aprelev <[email protected]> Commit-Queue: Ryan Macnak <[email protected]>
1 parent 41bb44e commit ac77af1

File tree

55 files changed

+22
-41
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

55 files changed

+22
-41
lines changed

runtime/tests/concurrency/stress_test_list.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@
9595
"../vm/dart/single_target_and_method_extractors2_test.dart",
9696
"../vm/dart/single_target_and_method_extractors_test.dart",
9797
"../vm/dart/slow_path_shared_stub_test.dart",
98-
"../vm/dart/splay_test.dart",
98+
"../vm/dart/gc/splay_test.dart",
9999
"../vm/dart/stack_overflow_shared_test.dart",
100100
"../vm/dart/stacktrace_mixin_application_test.dart",
101101
"../vm/dart/strict_null_safety_checks_in_weak_mode_test.dart",
@@ -3201,7 +3201,6 @@
32013201
"../../../tests/standalone/double_temp_test.dart",
32023202
"../../../tests/standalone/double_to_int_test.dart",
32033203
"../../../tests/standalone/float_array_test.dart",
3204-
"../../../tests/standalone/fragmentation_typed_data_test.dart",
32053204
"../../../tests/standalone/int_array_load_elimination_test.dart",
32063205
"../../../tests/standalone/int_array_test.dart",
32073206
"../../../tests/standalone/int_list_test.dart",
@@ -3475,7 +3474,7 @@
34753474
"../vm/dart_2/single_target_and_method_extractors2_test.dart",
34763475
"../vm/dart_2/single_target_and_method_extractors_test.dart",
34773476
"../vm/dart_2/slow_path_shared_stub_test.dart",
3478-
"../vm/dart_2/splay_test.dart",
3477+
"../vm/dart_2/gc/splay_test.dart",
34793478
"../vm/dart_2/stack_overflow_shared_test.dart",
34803479
"../vm/dart_2/stacktrace_mixin_application_test.dart",
34813480
"../vm/dart_2/switchable_call_monomorphic_regression_42517_test.dart",

runtime/tests/vm/dart/appjit_determinism_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
import 'dart:async';
88
import 'snapshot_test_helper.dart';
9-
import 'splay_test.dart';
9+
import 'gc/splay_test.dart';
1010

1111
int fib(int n) {
1212
if (n <= 1) return 1;

runtime/tests/vm/dart/deferred_isolate_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import 'dart:async';
88
import 'dart:isolate';
99
import 'package:expect/expect.dart';
1010

11-
import "splay_test.dart" deferred as splay;
11+
import "gc/splay_test.dart" deferred as splay;
1212

1313
worker(SendPort sendPort) {
1414
Expect.throws(() => splay.main(),

runtime/tests/vm/dart/deferred_loading_and_weak_serialization_references_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
// VMOptions=--no_retain_function_objects
99
// VMOptions=--dwarf_stack_traces
1010

11-
import "splay_test.dart" deferred as splay; // Some non-trivial code.
11+
import "gc/splay_test.dart" deferred as splay; // Some non-trivial code.
1212

1313
main() async {
1414
await splay.loadLibrary();

runtime/tests/vm/dart/deferred_loading_call_modes_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5-
import "splay_test.dart" deferred as splay; // Some non-trivial code.
5+
import "gc/splay_test.dart" deferred as splay; // Some non-trivial code.
66

77
main() async {
88
await splay.loadLibrary();

runtime/tests/vm/dart/split_aot_kernel_generation_test.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5-
// OtherResources=splay_test.dart splay_common.dart
5+
// OtherResources=gc/splay_test.dart gc/splay_common.dart
66

77
// Tests AOT kernel generation split into 2 steps using '--from-dill' option.
88

@@ -44,5 +44,5 @@ Future<void> runSplitAOTKernelGenerationTest(Uri testScriptUri) async {
4444

4545
main() async {
4646
await runSplitAOTKernelGenerationTest(
47-
Platform.script.resolve('splay_test.dart'));
47+
Platform.script.resolve('gc/splay_test.dart'));
4848
}

runtime/tests/vm/dart_2/appjit_determinism_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
import 'dart:async';
1010
import 'snapshot_test_helper.dart';
11-
import 'splay_test.dart';
11+
import 'gc/splay_test.dart';
1212

1313
int fib(int n) {
1414
if (n <= 1) return 1;

runtime/tests/vm/dart_2/deferred_isolate_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
import 'dart:isolate';
1010
import 'package:expect/expect.dart';
1111

12-
import "splay_test.dart" deferred as splay;
12+
import "gc/splay_test.dart" deferred as splay;
1313

1414
worker(SendPort sendPort) {
1515
Expect.throws(() => splay.main(),

runtime/tests/vm/dart_2/deferred_loading_and_weak_serialization_references_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
// VMOptions=--no_retain_function_objects
1111
// VMOptions=--dwarf_stack_traces
1212

13-
import "splay_test.dart" deferred as splay; // Some non-trivial code.
13+
import "gc/splay_test.dart" deferred as splay; // Some non-trivial code.
1414

1515
main() async {
1616
await splay.loadLibrary();

runtime/tests/vm/dart_2/deferred_loading_call_modes_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
// @dart = 2.9
66

7-
import "splay_test.dart" deferred as splay; // Some non-trivial code.
7+
import "gc/splay_test.dart" deferred as splay; // Some non-trivial code.
88

99
main() async {
1010
await splay.loadLibrary();

runtime/tests/vm/dart_2/split_aot_kernel_generation_test.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
// @dart = 2.9
66

7-
// OtherResources=splay_test.dart splay_common.dart
7+
// OtherResources=gc/splay_test.dart gc/splay_common.dart
88

99
// Tests AOT kernel generation split into 2 steps using '--from-dill' option.
1010

@@ -46,5 +46,5 @@ Future<void> runSplitAOTKernelGenerationTest(Uri testScriptUri) async {
4646

4747
main() async {
4848
await runSplitAOTKernelGenerationTest(
49-
Platform.script.resolve('splay_test.dart'));
49+
Platform.script.resolve('gc/splay_test.dart'));
5050
}

runtime/tests/vm/vm.status

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,9 @@ dart_2/null_safety_autodetection_in_kernel_compiler_test: SkipSlow # gen_kernel
8787
[ $builder_tag == tsan ]
8888
dart/analyze_snapshot_binary_test: SkipSlow
8989
dart/appjit_cha_deopt_test: SkipSlow
90+
dart/gc/fragmentation*: Skip # Uses too much memory with TSAN overhead and kills bot
91+
dart/gc/out_of_memory*: Skip # Uses too much memory with TSAN overhead and kills bot
92+
dart/gc/scavenger_abort_test: SkipSlow
9093
dart/hash_map_probes_limit_test: SkipSlow # Test includes large program compilation.
9194
dart/regress_40462_test: SkipSlow
9295
dart/regress_40753_test: Skip # This test crashes on the bot, but not locally, and infrastructure repeatedly fails to locate its coredump.
@@ -98,6 +101,9 @@ dart/v8_snapshot_profile_writer_test: SkipSlow
98101
dart/weak_canonical_string_table_test: Pass, Slow # This test can take a longer time to complete.
99102
dart_2/analyze_snapshot_binary_test: SkipSlow
100103
dart_2/appjit_cha_deopt_test: SkipSlow
104+
dart_2/gc/fragmentation*: Skip # Uses too much memory with TSAN overhead and kills bot
105+
dart_2/gc/out_of_memory*: Skip # Uses too much memory with TSAN overhead and kills bot
106+
dart_2/gc/scavenger_abort_test: SkipSlow
101107
dart_2/hash_map_probes_limit_test: SkipSlow # Test includes large program compilation.
102108
dart_2/regress_40462_test: SkipSlow
103109
dart_2/regress_40753_test: Skip # This test crashes on the bot, but not locally, and infrastructure repeatedly fails to locate its coredump.
@@ -143,10 +149,8 @@ dart_2/snapshot_depfile_test: SkipByDesign # Test needs to run from source
143149
dart/await_type_check_with_dynamic_loading_test: SkipByDesign # Uses dart:mirrors.
144150
dart/finalizer/finalizer_isolate_groups_run_gc_test: SkipByDesign # Isolate.spawnUri is not supported in AOT.
145151
dart/redirection_type_shuffling_test: SkipByDesign # Uses dart:mirrors.
146-
dart/scavenger_abort_test: SkipSlow
147152
dart/v8_snapshot_profile_writer_test: Pass, Slow # Can be slow due to re-invoking the precompiler.
148153
dart_2/redirection_type_shuffling_test: SkipByDesign # Uses dart:mirrors.
149-
dart_2/scavenger_abort_test: SkipSlow
150154
dart_2/v8_snapshot_profile_writer_test: Pass, Slow # Can be slow due to re-invoking the precompiler.
151155

152156
[ $compiler != dartkp ]
@@ -260,21 +264,21 @@ cc/Profiler_ToggleRecordAllocation: SkipByDesign
260264
cc/Profiler_TrivialRecordAllocation: SkipByDesign
261265
cc/Profiler_TypedArrayAllocation: SkipByDesign
262266
cc/Service_Profile: SkipByDesign
267+
dart/gc/splay_c_finalizer_test: SkipByDesign # No FFI on simulators
263268
dart/isolates/dart_api_create_lightweight_isolate_test: SkipByDesign # https://dartbug.com/37299 Test uses dart:ffi which is not supported on simulators.
264269
dart/isolates/thread_pool_test: SkipByDesign # https://dartbug.com/37299 Test uses dart:ffi which is not supported on simulators.
265270
dart/regress_41971_test: SkipByDesign # https://dartbug.com/37299 dart:ffi is not supported on simulator
266271
dart/regress_b_216834909_test: SkipByDesign # No FFI on simulators
267272
dart/sdk_hash_test: SkipSlow # gen_kernel is slow to run on simarm
268-
dart/splay_c_finalizer_test: SkipByDesign # No FFI on simulators
269273
dart/unboxed_param_args_descriptor_test: SkipByDesign # https://dartbug.com/37299 FFI helper not supported on simulator
270274
dart/unboxed_param_tear_off_test: SkipByDesign # https://dartbug.com/37299 FFI helper not supported on simulator
271275
dart/unboxed_param_test: SkipByDesign # https://dartbug.com/37299 FFI helper not supported on simulator
276+
dart_2/gc/splay_c_finalizer_test: SkipByDesign # No FFI on simulators
272277
dart_2/isolates/dart_api_create_lightweight_isolate_test: SkipByDesign # https://dartbug.com/37299 Test uses dart:ffi which is not supported on simulators.
273278
dart_2/isolates/thread_pool_test: SkipByDesign # https://dartbug.com/37299 Test uses dart:ffi which is not supported on simulators.
274279
dart_2/regress_41971_test: SkipByDesign # https://dartbug.com/37299 dart:ffi is not supported on simulator
275280
dart_2/regress_b_216834909_test: SkipByDesign # No FFI on simulators
276281
dart_2/sdk_hash_test: SkipSlow # gen_kernel is slow to run on simarm
277-
dart_2/splay_c_finalizer_test: SkipByDesign # No FFI on simulators
278282
dart_2/unboxed_param_args_descriptor_test: SkipByDesign # https://dartbug.com/37299 FFI helper not supported on simulator
279283
dart_2/unboxed_param_tear_off_test: SkipByDesign # https://dartbug.com/37299 FFI helper not supported on simulator
280284
dart_2/unboxed_param_test: SkipByDesign # https://dartbug.com/37299 FFI helper not supported on simulator
@@ -522,7 +526,6 @@ dart/print_flow_graph_determinism_test: SkipSlow
522526
dart/slow_path_shared_stub_test: SkipSlow # Too slow with --shared-slow-path-triggers-gc flag and not relevant outside precompiled.
523527
dart/spawn_infinite_loop_test: Skip # We can shutdown an isolate before it reloads.
524528
dart/spawn_shutdown_test: Skip # We can shutdown an isolate before it reloads.
525-
dart/splay_test: SkipSlow
526529
dart/stack_overflow_shared_test: SkipSlow # Too slow with --shared-slow-path-triggers-gc flag and not relevant outside precompiled.
527530
dart_2/appjit*: SkipByDesign # Cannot reload with URI pointing to app snapshot.
528531
dart_2/disassemble_determinism_test: SkipSlow # Runs expensive fibonacci(32) computation in 2 subprocesses
@@ -533,7 +536,6 @@ dart_2/print_flow_graph_determinism_test: SkipSlow
533536
dart_2/slow_path_shared_stub_test: SkipSlow # Too slow with --shared-slow-path-triggers-gc flag and not relevant outside precompiled.
534537
dart_2/spawn_infinite_loop_test: Skip # We can shutdown an isolate before it reloads.
535538
dart_2/spawn_shutdown_test: Skip # We can shutdown an isolate before it reloads.
536-
dart_2/splay_test: SkipSlow
537539
dart_2/stack_overflow_shared_test: SkipSlow # Too slow with --shared-slow-path-triggers-gc flag and not relevant outside precompiled.
538540

539541
[ $hot_reload || $hot_reload_rollback || $compiler != dartk && $compiler != dartkp ]

tests/standalone/standalone.status

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -105,10 +105,6 @@ io/raw_secure_server_socket_test: Crash
105105
io/raw_server_socket_cancel_test: Skip # Issue 28182 # This test sometimes hangs on Mac.
106106
io/socket_many_connections_test: Skip # This test fails with "Too many open files" on the Mac OS buildbot. This is expected as MacOS by default runs with a very low number of allowed open files ('ulimit -n' says something like 256).
107107

108-
[ $arch == arm || $arch == arm64 || $runtime != vm || $system == android ]
109-
fragmentation_test: SkipSlow
110-
fragmentation_typed_data_test: SkipSlow
111-
112108
[ $compiler == dart2js || $compiler == ddc ]
113109
*: SkipByDesign
114110

tests/standalone/standalone_kernel.status

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,8 @@
44
# Sections in this file should contain "$compiler == dartk" or
55
# "$compiler == dartkp".
66

7-
fragmentation_test: Pass, Slow # GC heavy
8-
fragmentation_typed_data_test: Pass, Slow # GC heavy
97
io/process_sync_test: Pass, Slow # Spawns synchronously subprocesses in sequence.
108

11-
[ $builder_tag == tsan ]
12-
fragmentation_test: Skip # This test crashes on the bot, but not locally, and infrastructure repeatedly fails to locate its coredump.
13-
fragmentation_typed_data_test: Skip # This test crashes on the bot, but not locally, and infrastructure repeatedly fails to locate its coredump.
14-
159
[ $system == android ]
1610
entrypoints_verification_test: Skip # Requires shared objects which the test script doesn't "adb push".
1711
io/http_ban_http_embedder_test: Skip # Requires http server bound to non-loopback; not provided by system.

tests/standalone_2/standalone_2.status

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -105,10 +105,6 @@ io/raw_secure_server_socket_test: Crash
105105
io/raw_server_socket_cancel_test: Skip # Issue 28182 # This test sometimes hangs on Mac.
106106
io/socket_many_connections_test: Skip # This test fails with "Too many open files" on the Mac OS buildbot. This is expected as MacOS by default runs with a very low number of allowed open files ('ulimit -n' says something like 256).
107107

108-
[ $arch == arm || $arch == arm64 || $runtime != vm || $system == android ]
109-
fragmentation_test: SkipSlow
110-
fragmentation_typed_data_test: SkipSlow
111-
112108
[ $compiler == dart2js || $compiler == ddc ]
113109
*: SkipByDesign
114110

tests/standalone_2/standalone_2_kernel.status

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,8 @@
44
# Sections in this file should contain "$compiler == dartk" or
55
# "$compiler == dartkp".
66

7-
fragmentation_test: Pass, Slow # GC heavy
8-
fragmentation_typed_data_test: Pass, Slow # GC heavy
97
io/process_sync_test: Pass, Slow # Spawns synchronously subprocesses in sequence.
108

11-
[ $builder_tag == tsan ]
12-
fragmentation_test: Skip # This test crashes on the bot, but not locally, and infrastructure repeatedly fails to locate its coredump.
13-
fragmentation_typed_data_test: Skip # This test crashes on the bot, but not locally, and infrastructure repeatedly fails to locate its coredump.
14-
159
[ $system == android ]
1610
entrypoints_verification_test: Skip # Requires shared objects which the test script doesn't "adb push".
1711
io/http_ban_http_embedder_test: Skip # Requires http server bound to non-loopback; not provided by system.

0 commit comments

Comments
 (0)