Skip to content

Commit af4aa98

Browse files
liamappelbecommit-bot@chromium.org
authored andcommitted
Return 0 from run_abi_tests.py, regardless of whethere there are diffs
Change-Id: I3bc656ecfa6979e9fcd544f8a43840acf621a75b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106880 Reviewed-by: Alexander Thomas <[email protected]> Commit-Queue: Liam Appelbe <[email protected]>
1 parent 089a435 commit af4aa98

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

tools/run_abi_tests.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,6 @@ def makeLog(diffs, results, logRecords):
150150
def diffAllResults(tests):
151151
allResults = readAllTestFiles(tests, lambda test: test.resultFile)
152152
allLogs = readAllTestFiles(tests, lambda test: test.logFile)
153-
anyDiff = False
154153
logDir = os.path.join(outDir, 'logs')
155154
makeDirs(logDir)
156155
resultFileName = os.path.join(logDir, 'results.json')
@@ -163,14 +162,13 @@ def diffAllResults(tests):
163162
if diffs:
164163
logRecords = allLogs[name] if name in allLogs else []
165164
logFile.write(json.dumps(makeLog(diffs, results, logRecords)) + '\n')
166-
anyDiff = True
167-
return anyDiff
168165

169166

170167
def main():
171168
tests = buildAllTests()
172169
runAllTests(tests)
173-
return 1 if diffAllResults(tests) else 0
170+
diffAllResults(tests)
171+
return 0
174172

175173

176174
if __name__ == '__main__':

0 commit comments

Comments
 (0)