Converted Observatory function-view element

[email protected]

Review URL: https://codereview.chromium.org/2291823002 .

Author: B3rn475

runtime/observatory/lib/elements.dart

@@ -7,7 +7,6 @@ export 'package:observatory/src/elements/class_view.dart';
 export 'package:observatory/src/elements/code_view.dart';
 export 'package:observatory/src/elements/debugger.dart';
 export 'package:observatory/src/elements/eval_link.dart';
-export 'package:observatory/src/elements/function_view.dart';
 export 'package:observatory/src/elements/instance_view.dart';
 export 'package:observatory/src/elements/isolate_reconnect.dart';
 export 'package:observatory/src/elements/isolate_summary.dart';
@@ -54,6 +53,7 @@ import 'package:observatory/src/elements/field_view.dart';
 import 'package:observatory/src/elements/flag_list.dart';
 import 'package:observatory/src/elements/function_ref.dart';
 import 'package:observatory/src/elements/function_ref_wrapper.dart';
+import 'package:observatory/src/elements/function_view.dart';
 import 'package:observatory/src/elements/general_error.dart';
 import 'package:observatory/src/elements/heap_map.dart';
 import 'package:observatory/src/elements/heap_snapshot.dart';
@@ -139,6 +139,7 @@ export 'package:observatory/src/elements/error_view.dart';
 export 'package:observatory/src/elements/eval_box.dart';
 export 'package:observatory/src/elements/field_ref.dart';
 export 'package:observatory/src/elements/field_view.dart';
+export 'package:observatory/src/elements/function_view.dart';
 export 'package:observatory/src/elements/flag_list.dart';
 export 'package:observatory/src/elements/function_ref.dart';
 export 'package:observatory/src/elements/general_error.dart';
@@ -217,6 +218,7 @@ Future initElements() async {
   FlagListElement.tag.ensureRegistration();
   FunctionRefElement.tag.ensureRegistration();
   FunctionRefElementWrapper.tag.ensureRegistration();
+  FunctionViewElement.tag.ensureRegistration();
   GeneralErrorElement.tag.ensureRegistration();
   HeapMapElement.tag.ensureRegistration();
   HeapSnapshotElement.tag.ensureRegistration();

runtime/observatory/lib/elements.html

@@ -4,7 +4,6 @@
 <link rel="import" href="src/elements/code_view.html">
 <link rel="import" href="src/elements/debugger.html">
 <link rel="import" href="src/elements/eval_link.html">
-<link rel="import" href="src/elements/function_view.html">
 <link rel="import" href="src/elements/instance_view.html">
 <link rel="import" href="src/elements/isolate_summary.html">
 <link rel="import" href="src/elements/isolate_view.html">

runtime/observatory/lib/models.dart

@@ -57,6 +57,7 @@ part 'src/models/repositories/eval.dart';
 part 'src/models/repositories/event.dart';
 part 'src/models/repositories/field.dart';
 part 'src/models/repositories/flag.dart';
+part 'src/models/repositories/function.dart';
 part 'src/models/repositories/heap_snapshot.dart';
 part 'src/models/repositories/icdata.dart';
 part 'src/models/repositories/inbound_references.dart';

runtime/observatory/lib/repositories.dart

@@ -22,6 +22,7 @@ part 'src/repositories/eval.dart';
 part 'src/repositories/event.dart';
 part 'src/repositories/field.dart';
 part 'src/repositories/flag.dart';
+part 'src/repositories/function.dart';
 part 'src/repositories/heap_snapshot.dart';
 part 'src/repositories/icdata.dart';
 part 'src/repositories/inbound_references.dart';

runtime/observatory/lib/src/app/page.dart

@@ -9,6 +9,7 @@ AllocationProfileRepository _allocationProfileRepository
 ClassRepository _classRepository = new ClassRepository();
 ContextRepository _contextRepository = new ContextRepository();
 FieldRepository _fieldRepository = new FieldRepository();
+FunctionRepository _functionRepository = new FunctionRepository();
 HeapSnapshotRepository _heapSnapshotRepository
     = new HeapSnapshotRepository();
 ICDataRepository _icdataRepository = new ICDataRepository();
@@ -225,6 +226,20 @@ class InspectPage extends MatchingPage {
                              _instanceRepository,
                              queue: app.queue)
       ];
+    } else if (obj is ServiceFunction) {
+      container.children = [
+        new FunctionViewElement(app.vm, obj.isolate, obj, app.events,
+                                app.notifications,
+                                _functionRepository,
+                                _classRepository,
+                                _retainedSizeRepository,
+                                _reachableSizeRepository,
+                                _inboundReferencesRepository,
+                                _retainingPathRepository,
+                                _scriptRepository,
+                                _instanceRepository,
+                                queue: app.queue)
+      ];
     } else if (obj is ICData) {
       container.children = [
         new ICDataViewElement(app.vm, obj.isolate, obj, app.events,

runtime/observatory/lib/src/elements/field_view.dart

@@ -41,6 +41,7 @@ class FieldViewElement extends HtmlElement implements Renderable {
                                               NavRefreshElement.tag,
                                               NavNotifyElement.tag,
                                               ObjectCommonElement.tag,
+                                              ScriptInsetElement.tag,
                                               SourceLinkElement.tag,
                                               ViewFooterElement.tag
                                             ]);
@@ -283,10 +284,10 @@ class FieldViewElement extends HtmlElement implements Renderable {
 
   Future _refresh() async {
     _field = await _fields.get(_isolate, _field.id);
-    if (field.dartOwner is M.LibraryRef) {
-      _library = field.dartOwner;
-    } else if (field.dartOwner is M.ClassRef) {
-      _library = (await _classes.get(_isolate, field.dartOwner.id)).library;
+    if (_field.dartOwner is M.LibraryRef) {
+      _library = _field.dartOwner;
+    } else if (_field.dartOwner is M.ClassRef) {
+      _library = (await _classes.get(_isolate, _field.dartOwner.id)).library;
     }
     _r.dirty();
   }