[DAS] Fixes instance members completion on dart docs

[email protected]

Fixes: #59724
Change-Id: I1e80e62e553c5411ee69d58dbe941b61bc575a81
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411361
Reviewed-by: Keerti Parthasarathy <[email protected]>
Commit-Queue: Samuel Rawlins <[email protected]>
Auto-Submit: Felipe Morschel <[email protected]>
Reviewed-by: Samuel Rawlins <[email protected]>

Author: FMorschel

pkg/analysis_server/lib/src/services/completion/dart/in_scope_completion_pass.dart

@@ -2265,12 +2265,20 @@ class InScopeCompletionPass extends SimpleAstVisitor<void> {
               mustBeAssignable: mustBeAssignable,
             ).addDeclarationsThroughImportPrefix(element);
           } else {
-            declarationHelper(
+            var helper = declarationHelper(
               mustBeAssignable: mustBeAssignable,
               preferNonInvocation:
                   element is InterfaceElement2 &&
                   state.request.shouldSuggestTearOff(element),
-            ).addStaticMembersOfElement(element);
+            );
+            if (node.parent is CommentReference) {
+              if (element is InterfaceElement2) {
+                helper.addInstanceMembersOfType(element.thisType);
+              } else if (element is ExtensionElement2) {
+                helper.addMembersFromExtensionElement(element);
+              }
+            }
+            helper.addStaticMembersOfElement(element);
           }
         }
       }

pkg/analysis_server/test/services/completion/dart/location/dart_doc_test.dart

@@ -123,7 +123,6 @@ suggestions
 ''');
   }
 
-  @FailingTest(issue: 'https://github.com/dart-lang/sdk/issues/59724')
   Future<void> test_field2() async {
     allowedIdentifiers = const {'myField'};
     await computeSuggestions('''
@@ -175,6 +174,44 @@ suggestions
 ''');
   }
 
+  Future<void> test_getter2() async {
+    allowedIdentifiers = const {'myGetter'};
+    await computeSuggestions('''
+/// This is unrelated but should suggest name [MyExtension1.myG^].
+var myVariable = 0;
+
+extension MyExtension1 {
+  int get myGetter => 0;
+}
+''');
+    assertResponse(r'''
+replacement
+  left: 3
+suggestions
+  myGetter
+    kind: getter
+''');
+  }
+
+  Future<void> test_getter3() async {
+    allowedIdentifiers = const {'myGetter'};
+    await computeSuggestions('''
+/// This is unrelated but should suggest name [MyExtensionType1.myG^].
+var myVariable = 0;
+
+extension type MyExtensionType1(int i) {
+  int get myGetter => 0;
+}
+''');
+    assertResponse(r'''
+replacement
+  left: 3
+suggestions
+  myGetter
+    kind: getter
+''');
+  }
+
   Future<void> test_importPrefix() async {
     allowedIdentifiers = const {'async'};
     await computeSuggestions('''