Fix handling of closures containing type promotions in variables with inferred types.

Promotion analysis requires the localVariableInfo data structures to
be set; these are set by the VariableResolverVisitor.  So we need to
ensure that this visitor runs prior to type inference.

Change-Id: I579301beb101f32a1965f9eb8f07b1196d232b8e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95422
Reviewed-by: Konstantin Shcheglov <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Paul Berry <[email protected]>

Author: stereotype441

pkg/analyzer/lib/src/summary/link.dart

@@ -2542,7 +2542,9 @@ class ExprTypeComputer {
     expression = container.expression;
     if (_linker.getAst != null) {
       expression.accept(_typeResolverVisitor);
-      expression.accept(_variableResolverVisitor);
+    }
+    expression.accept(_variableResolverVisitor);
+    if (_linker.getAst != null) {
       expression.accept(_partialResolverVisitor);
     }
     expression.accept(_resolverVisitor);

pkg/analyzer/test/generated/non_error_resolver.dart

@@ -907,6 +907,19 @@ class E {}''');
     expect(classC.documentationComment, isNotNull);
   }
 
+  test_closure_in_type_inferred_variable_in_other_lib() async {
+    Source source = addSource('''
+import 'other.dart';
+var x = y;
+    ''');
+    addNamedSource('/other.dart', '''
+var y = (Object x) => x is int && x.isEven;
+''');
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
+    verify([source]);
+  }
+
   test_concreteClassWithAbstractMember() async {
     Source source = addSource(r'''
 abstract class A {

pkg/analyzer/test/util/ast_type_matchers.dart

@@ -111,14 +111,14 @@ const isFieldDeclaration = const TypeMatcher<FieldDeclaration>();
 
 const isFieldFormalParameter = const TypeMatcher<FieldFormalParameter>();
 
-final Matcher isForEachStatement = predicate(
+final isForEachStatement = predicate(
     (Object o) => o is ForStatement2 && o.forLoopParts is ForEachParts);
 
 const isFormalParameter = const TypeMatcher<FormalParameter>();
 
 const isFormalParameterList = const TypeMatcher<FormalParameterList>();
 
-final Matcher isForStatement =
+final isForStatement =
     predicate((Object o) => o is ForStatement2 && o.forLoopParts is ForParts);
 
 const isFunctionBody = const TypeMatcher<FunctionBody>();
@@ -181,8 +181,7 @@ const isListLiteral = const TypeMatcher<ListLiteral>();
 
 const isLiteral = const TypeMatcher<Literal>();
 
-final Matcher isMapLiteral =
-    predicate((Object o) => o is SetOrMapLiteral && o.isMap);
+final isMapLiteral = predicate((Object o) => o is SetOrMapLiteral && o.isMap);
 
 const isMapLiteralEntry = const TypeMatcher<MapLiteralEntry>();
 
@@ -237,8 +236,7 @@ const isReturnStatement = const TypeMatcher<ReturnStatement>();
 
 const isScriptTag = const TypeMatcher<ScriptTag>();
 
-final Matcher isSetLiteral =
-    predicate((Object o) => o is SetOrMapLiteral && o.isSet);
+final isSetLiteral = predicate((Object o) => o is SetOrMapLiteral && o.isSet);
 
 const isShowCombinator = const TypeMatcher<ShowCombinator>();