Skip to content

Commit ba8db19

Browse files
sstricklCommit Queue
authored and
Commit Queue
committed
Revert "[native_stack_traces] Remove initial spaces check in stack trace lines."
This reverts commit ae4ee87. Reason for revert: Broke integration tests on precompiled bots. Original change's description: > [native_stack_traces] Remove initial spaces check in stack trace lines. > > The strictness of the old "check for four spaces" was causing failures > in `flutter symbolize`, and there's no reason to check how much initial > whitespace we got prior to the line contents anyway. > > TEST=pkg/native_stack_traces/test/convert/regress_262474517_test > > Change-Id: I6a6e31732cb2a5b5d40a088b9a04877052726be2 > Bug: b/262474517 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276905 > Reviewed-by: Daco Harkes <[email protected]> > Commit-Queue: Tess Strickland <[email protected]> [email protected],[email protected],[email protected] Change-Id: I83bfa2d09570d8ae4d244b987bd5acf855e57306 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/262474517 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/277000 Commit-Queue: Alexander Markov <[email protected]> Auto-Submit: Tess Strickland <[email protected]> Reviewed-by: Alexander Markov <[email protected]>
1 parent 81f0959 commit ba8db19

File tree

5 files changed

+4
-48
lines changed

5 files changed

+4
-48
lines changed

pkg/native_stack_traces/CHANGELOG.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,3 @@
1-
## 0.5.4
2-
3-
- Relaxed requirement for spaces before non-symbolic stack trace line.
4-
51
## 0.5.3
62

73
- Exported more ELF utilities for use in Dart tests.

pkg/native_stack_traces/lib/src/convert.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -125,9 +125,9 @@ const _symbolOffsetREString = r'(?<symbol>' +
125125
constants.isolateSymbolName +
126126
r')\+(?<offset>(?:0x)?[\da-f]+)';
127127
final _symbolOffsetRE = RegExp(_symbolOffsetREString);
128-
final _traceLineRE =
129-
RegExp(r'#(\d+) abs (?<absolute>[\da-f]+)(?: virt (?<virtual>[\da-f]+))? '
130-
r'(?<rest>.*)$');
128+
final _traceLineRE = RegExp(
129+
r' #(\d+) abs (?<absolute>[\da-f]+)(?: virt (?<virtual>[\da-f]+))? '
130+
r'(?<rest>.*)$');
131131

132132
/// Parses strings of the format <static symbol>+<integer offset>, where
133133
/// <static symbol> is one of the static symbols used for Dart instruction

pkg/native_stack_traces/pubspec.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: native_stack_traces
2-
version: 0.5.4
2+
version: 0.5.3
33
description: Utilities for working with non-symbolic stack traces.
44
repository: https://github.com/dart-lang/sdk/tree/main/pkg/native_stack_traces
55

@@ -19,4 +19,3 @@ dependencies:
1919
# See also https://dart.dev/tools/pub/dependencies.
2020
dev_dependencies:
2121
lints: any
22-
test: any

pkg/native_stack_traces/test/convert/regress_262474517_test.dart

Lines changed: 0 additions & 33 deletions
This file was deleted.

pkg/native_stack_traces/testcases/convert/regress_262474517_trace.txt

Lines changed: 0 additions & 6 deletions
This file was deleted.

0 commit comments

Comments
 (0)