Skip to content

Commit bf26f76

Browse files
athomascommit-bot@chromium.org
authored andcommitted
[infra] Ensure that core dump upload triggers on main builders
https://crrev.com/c/1296514 will add --output_directory to non-shards as well. BUILDBOT_BUILDERNAME is not set on shards and a more reliable indication that this is a main bot that should gsutil upload core dumps. Change-Id: Ic6cddc4937b8e83d2e15da4acd90c193e412773b Reviewed-on: https://dart-review.googlesource.com/c/81362 Reviewed-by: Jonas Termansen <[email protected]> Commit-Queue: Alexander Thomas <[email protected]>
1 parent cdf6dde commit bf26f76

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

tools/utils.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -830,10 +830,11 @@ def _archive(self, crashes):
830830
files.add(core)
831831
else:
832832
missing.append(crash)
833-
if self._output_directory is None:
833+
if (self._output_directory is None
834+
or os.environ.containsKey('BUILDBOT_BUILDERNAME')):
834835
self._upload(files)
835836
else:
836-
# --output_directory is specified, copy the dump to the output_directory instead
837+
# This is a sharded test run: copy the dump to the output_directory
837838
self._copy(files)
838839

839840
if missing:

0 commit comments

Comments
 (0)