[kernel] Remove nodes used for the old 'extension-types' experiment

This removes ExtensionType, ExtensionTypeShowHideClause and
CallSiteAccessKind from package:kernel which where only used by the now
removed 'extension-types' experiment.

A follow-up CL will rename InlineClass/InlineType to
ExtensionTypeDeclaration/ExtensionType to match the names of the
Extension Type feature currently being implemented.

TEST=existing

Change-Id: I58d2e8b0a92ac61329ee161cc6884a2c0e6f87ae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/316420
Reviewed-by: Chloe Stefantsova <[email protected]>
Commit-Queue: Johnni Winther <[email protected]>
Reviewed-by: Sigmund Cherem <[email protected]>
Reviewed-by: Alexander Markov <[email protected]>

Author: johnniwinther

pkg/compiler/lib/src/ir/util.dart

@@ -240,11 +240,6 @@ class _FreeVariableVisitor implements ir.DartTypeVisitor<bool> {
     return visitList(node.typeArguments);
   }
 
-  @override
-  bool visitExtensionType(ir.ExtensionType node) {
-    return visitList(node.typeArguments);
-  }
-
   @override
   bool visitInlineType(ir.InlineType node) {
     return visit(node.instantiatedRepresentationType);

pkg/compiler/test/helpers/ir_types.dart

@@ -121,12 +121,6 @@ class TypeTextVisitor implements ir.DartTypeVisitor1<void, StringBuffer> {
     _writeTypeArguments(node.typeArguments, sb);
   }
 
-  @override
-  void visitExtensionType(ir.ExtensionType node, StringBuffer sb) {
-    sb.write(node.extension.name);
-    _writeTypeArguments(node.typeArguments, sb);
-  }
-
   @override
   void visitInlineType(ir.InlineType node, StringBuffer sb) {
     writeType(node.instantiatedRepresentationType, sb);

pkg/dev_compiler/lib/src/kernel/compiler.dart

@@ -3372,10 +3372,6 @@ class ProgramCompiler extends ComputeOnceConstantVisitor<js_ast.Expression>
   js_ast.Expression visitInterfaceType(InterfaceType type) =>
       _emitInterfaceType(type);
 
-  @override
-  js_ast.Expression visitExtensionType(ExtensionType type) =>
-      type.onType.accept(this);
-
   @override
   js_ast.Expression visitInlineType(InlineType type) =>
       type.instantiatedRepresentationType.accept(this);

pkg/dev_compiler/lib/src/kernel/type_recipe_generator.dart

@@ -420,9 +420,6 @@ class _TypeRecipeVisitor extends DartTypeVisitor<String> {
   String visitNullType(NullType node) =>
       interfaceTypeRecipe(_coreTypes.deprecatedNullClass);
 
-  @override
-  String visitExtensionType(ExtensionType node) => defaultDartType(node);
-
   @override
   String visitIntersectionType(IntersectionType node) =>
       visitTypeParameterType(node.left);

pkg/front_end/lib/src/fasta/kernel/constant_evaluator.dart

@@ -6205,12 +6205,6 @@ class IsInstantiatedVisitor implements DartTypeVisitor<bool> {
         node.named.every((p) => p.type.accept(this));
   }
 
-  @override
-  bool visitExtensionType(ExtensionType node) {
-    return node.typeArguments
-        .every((DartType typeArgument) => typeArgument.accept(this));
-  }
-
   @override
   bool visitInlineType(InlineType node) {
     return node.typeArguments

pkg/front_end/lib/src/fasta/kernel/exhaustiveness.dart

@@ -653,11 +653,6 @@ class ExhaustiveDartTypeVisitor implements DartTypeVisitor1<bool, CoreTypes> {
     return false;
   }
 
-  @override
-  bool visitExtensionType(ExtensionType type, CoreTypes coreTypes) {
-    return false;
-  }
-
   @override
   bool visitFunctionType(FunctionType type, CoreTypes coreTypes) {
     return false;

pkg/front_end/lib/src/fasta/kernel/invalid_type.dart

@@ -24,11 +24,6 @@ class _InvalidTypeFinder implements DartTypeVisitor1<bool, Set<TypedefType>> {
   bool defaultDartType(DartType node, Set<TypedefType> visitedTypedefs) {
     if (node is UnknownType) {
       return false;
-    } else if (node is ExtensionType) {
-      for (DartType typeArgument in node.typeArguments) {
-        if (typeArgument.accept1(this, visitedTypedefs)) return true;
-      }
-      return false;
     } else {
       throw new StateError("Unhandled type ${node.runtimeType}.");
     }
@@ -54,15 +49,6 @@ class _InvalidTypeFinder implements DartTypeVisitor1<bool, Set<TypedefType>> {
     return false;
   }
 
-  @override
-  bool visitExtensionType(
-      ExtensionType node, Set<TypedefType> visitedTypedefs) {
-    for (DartType typeArgument in node.typeArguments) {
-      if (typeArgument.accept1(this, visitedTypedefs)) return true;
-    }
-    return false;
-  }
-
   @override
   bool visitInlineType(InlineType node, Set<TypedefType> visitedTypedefs) {
     for (DartType typeArgument in node.typeArguments) {

pkg/front_end/lib/src/fasta/kernel/type_algorithms.dart

@@ -1170,11 +1170,6 @@ class TypeVariableSearch implements DartTypeVisitor<bool> {
     return anyTypeVariables(node.typeArguments);
   }
 
-  @override
-  bool visitExtensionType(ExtensionType node) {
-    return anyTypeVariables(node.typeArguments);
-  }
-
   @override
   bool visitInlineType(InlineType node) {
     return anyTypeVariables(node.typeArguments);

pkg/front_end/lib/src/fasta/kernel/type_builder_computer.dart

@@ -108,11 +108,6 @@ class TypeBuilderComputer implements DartTypeVisitor<TypeBuilder> {
         arguments: arguments);
   }
 
-  @override
-  TypeBuilder visitExtensionType(ExtensionType node) {
-    throw "Not implemented";
-  }
-
   @override
   TypeBuilder visitInlineType(InlineType node) {
     throw "Not implemented";

pkg/front_end/lib/src/fasta/kernel/type_labeler.dart

@@ -261,29 +261,6 @@ class TypeLabeler implements DartTypeVisitor<void>, ConstantVisitor<void> {
     addNullability(node.declaredNullability);
   }
 
-  @override
-  void visitExtensionType(ExtensionType node) {
-    // TODO(johnniwinther): Ensure enclosing libraries on extensions earlier
-    // in the compiler to ensure types in error messages have context.
-    Library? enclosingLibrary = node.extension.parent as Library?;
-    result.add(nameForEntity(
-        node.extension,
-        node.extension.name,
-        enclosingLibrary?.importUri ?? unknownUri,
-        enclosingLibrary?.fileUri ?? unknownUri));
-    if (node.typeArguments.isNotEmpty) {
-      result.add("<");
-      bool first = true;
-      for (DartType typeArg in node.typeArguments) {
-        if (!first) result.add(", ");
-        typeArg.accept(this);
-        first = false;
-      }
-      result.add(">");
-    }
-    addNullability(node.declaredNullability);
-  }
-
   @override
   void visitInlineType(InlineType node) {
     // TODO(johnniwinther): Ensure enclosing libraries on extensions earlier

pkg/front_end/lib/src/fasta/source/source_extension_builder.dart

@@ -17,7 +17,6 @@ import '../fasta_codes.dart'
         messagePatchDeclarationOrigin,
         noLength;
 import '../kernel/body_builder_context.dart';
-import '../operator.dart';
 import '../problems.dart';
 import '../scope.dart';
 import 'name_scheme.dart';
@@ -192,41 +191,3 @@ class SourceExtensionBuilder extends ExtensionBuilderImpl
     }
   }
 }
-
-class ExtensionTypeShowHideClauseBuilder {
-  final List<TypeBuilder> shownSupertypes;
-  final List<String> shownGetters;
-  final List<String> shownSetters;
-  final List<String> shownMembersOrTypes;
-  final List<Operator> shownOperators;
-
-  final List<TypeBuilder> hiddenSupertypes;
-  final List<String> hiddenGetters;
-  final List<String> hiddenSetters;
-  final List<String> hiddenMembersOrTypes;
-  final List<Operator> hiddenOperators;
-
-  ExtensionTypeShowHideClauseBuilder(
-      {required this.shownSupertypes,
-      required this.shownGetters,
-      required this.shownSetters,
-      required this.shownMembersOrTypes,
-      required this.shownOperators,
-      required this.hiddenSupertypes,
-      required this.hiddenGetters,
-      required this.hiddenSetters,
-      required this.hiddenMembersOrTypes,
-      required this.hiddenOperators});
-
-  void buildAndStoreTypes(Extension extension, LibraryBuilder libraryBuilder) {
-    List<Supertype> builtShownSupertypes =
-        shownSupertypes.map((t) => t.buildSupertype(libraryBuilder)!).toList();
-    List<Supertype> builtHiddenSupertypes =
-        hiddenSupertypes.map((t) => t.buildSupertype(libraryBuilder)!).toList();
-    ExtensionTypeShowHideClause showHideClause =
-        extension.showHideClause ?? new ExtensionTypeShowHideClause();
-    showHideClause.shownSupertypes.addAll(builtShownSupertypes);
-    showHideClause.hiddenSupertypes.addAll(builtHiddenSupertypes);
-    extension.showHideClause ??= showHideClause;
-  }
-}

pkg/front_end/lib/src/fasta/type_inference/external_ast_helper.dart

@@ -32,9 +32,8 @@ StaticInvocation createStaticInvocation(Procedure target, Arguments arguments,
 InstanceInvocation createOperatorInvocation(InferenceVisitorBase base,
     DartType leftType, Expression left, Name operatorName, Expression right,
     {required int fileOffset}) {
-  ObjectAccessTarget target = base.findInterfaceMember(
-      leftType, operatorName, fileOffset,
-      callSiteAccessKind: CallSiteAccessKind.operatorInvocation);
+  ObjectAccessTarget target = base
+      .findInterfaceMember(leftType, operatorName, fileOffset, isSetter: false);
   return new InstanceInvocation(InstanceAccessKind.Instance, left, operatorName,
       createArguments([right], fileOffset: fileOffset),
       functionType: target.getFunctionType(base),
@@ -47,9 +46,8 @@ InstanceInvocation createOperatorInvocation(InferenceVisitorBase base,
 InstanceGet createInstanceGet(InferenceVisitorBase base, DartType receiverType,
     Expression receiver, Name name,
     {required int fileOffset}) {
-  ObjectAccessTarget target = base.findInterfaceMember(
-      receiverType, name, fileOffset,
-      callSiteAccessKind: CallSiteAccessKind.getterInvocation);
+  ObjectAccessTarget target =
+      base.findInterfaceMember(receiverType, name, fileOffset, isSetter: false);
   Member? member = target.member;
   assert(member is Field || member is Procedure && member.isGetter);
   return new InstanceGet(InstanceAccessKind.Instance, receiver, name,
@@ -66,9 +64,8 @@ InstanceInvocation createInstanceInvocation(
     Name name,
     List<Expression> positionalArguments,
     {required int fileOffset}) {
-  ObjectAccessTarget target = base.findInterfaceMember(
-      receiverType, name, fileOffset,
-      callSiteAccessKind: CallSiteAccessKind.methodInvocation);
+  ObjectAccessTarget target =
+      base.findInterfaceMember(receiverType, name, fileOffset, isSetter: false);
   return new InstanceInvocation(InstanceAccessKind.Instance, receiver, name,
       createArguments(positionalArguments, fileOffset: fileOffset),
       functionType: target.getFunctionType(base),
@@ -80,9 +77,8 @@ InstanceInvocation createInstanceInvocation(
 EqualsCall createEqualsCall(InferenceVisitorBase base, DartType leftType,
     Expression left, Expression right,
     {required int fileOffset}) {
-  ObjectAccessTarget target = base.findInterfaceMember(
-      leftType, equalsName, fileOffset,
-      callSiteAccessKind: CallSiteAccessKind.operatorInvocation);
+  ObjectAccessTarget target = base
+      .findInterfaceMember(leftType, equalsName, fileOffset, isSetter: false);
   return new EqualsCall(left, right,
       functionType: target.getFunctionType(base),
       interfaceTarget: target.member as Procedure)

pkg/front_end/lib/src/fasta/type_inference/for_in.dart

@@ -106,9 +106,7 @@ class PropertyForInVariable implements ForInVariable {
     DartType receiverType = receiverResult.inferredType;
     ObjectAccessTarget writeTarget = visitor.findInterfaceMember(
         receiverType, propertySet.name, propertySet.fileOffset,
-        callSiteAccessKind: CallSiteAccessKind.setterInvocation,
-        instrumented: true,
-        includeExtensionMethods: true);
+        isSetter: true, instrumented: true, includeExtensionMethods: true);
     DartType elementType = _writeType = writeTarget.getSetterType(visitor);
     Expression? error = visitor.reportMissingInterfaceMember(
         writeTarget,
@@ -164,8 +162,7 @@ class AbstractSuperPropertyForInVariable implements ForInVariable {
     DartType receiverType = visitor.thisType!;
     ObjectAccessTarget writeTarget = visitor.findInterfaceMember(
         receiverType, superPropertySet.name, superPropertySet.fileOffset,
-        callSiteAccessKind: CallSiteAccessKind.setterInvocation,
-        instrumented: true);
+        isSetter: true, instrumented: true);
     assert(writeTarget.isInstanceMember || writeTarget.isObjectMember);
     return _writeType = writeTarget.getSetterType(visitor);
   }
@@ -202,8 +199,7 @@ class SuperPropertyForInVariable implements ForInVariable {
     DartType receiverType = visitor.thisType!;
     ObjectAccessTarget writeTarget = visitor.findInterfaceMember(
         receiverType, superPropertySet.name, superPropertySet.fileOffset,
-        callSiteAccessKind: CallSiteAccessKind.setterInvocation,
-        instrumented: true);
+        isSetter: true, instrumented: true);
     assert(writeTarget.isInstanceMember || writeTarget.isObjectMember);
     return _writeType = writeTarget.getSetterType(visitor);
   }