[parser] Add comments to calls

Change-Id: Ide38846a6ff93c0bb7714ad89cc2f14accb0ed20
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263126
Commit-Queue: Jens Johansen <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>

Author: jensjoha

pkg/_fe_analyzer_shared/lib/src/parser/parser_impl.dart

@@ -1266,7 +1266,7 @@ class Parser {
               // Insert missing 'Function' below.
               reportRecoverableError(endGroup,
                   missingParameterMessage(MemberKind.FunctionTypeAlias));
-              rewriter.insertParens(endGroup, /*includeIdentifier =*/ false);
+              rewriter.insertParens(endGroup, /* includeIdentifier = */ false);
               recover = true;
             } else if (optional('(', endGroup.next!) &&
                 endGroup.next!.endGroup != null &&
@@ -2856,7 +2856,7 @@ class Parser {
           } else {
             token = IdentifierContext.extensionShowHideElementMemberOrType
                 .ensureIdentifier(token.next!, this);
-            listener.handleShowHideIdentifier(null, token);
+            listener.handleShowHideIdentifier(/* modifier = */ null, token);
           }
         }
         ++elementCount;
@@ -4447,7 +4447,7 @@ class Parser {
               codes.templateExperimentNotEnabled
                   .withArguments("triple-shift", "2.14"));
           operator = rewriter.replaceNextTokensWithSyntheticToken(
-              name, 2, TokenType.GT_GT_GT);
+              name, /* count = */ 2, TokenType.GT_GT_GT);
         }
       }
     }
@@ -5520,7 +5520,7 @@ class Parser {
                     .withArguments("triple-shift", "2.14"));
             assert(next == operator);
             next = rewriter.replaceNextTokensWithSyntheticToken(
-                token, 2, TokenType.GT_GT_GT_EQ);
+                token, /* count = */ 2, TokenType.GT_GT_GT_EQ);
             operator = next;
           }
           token = optional('throw', next.next!)
@@ -5615,7 +5615,7 @@ class Parser {
                       .withArguments("triple-shift", "2.14"));
               assert(next == operator);
               next = rewriter.replaceNextTokensWithSyntheticToken(
-                  token, 2, TokenType.GT_GT_GT);
+                  token, /* count = */ 2, TokenType.GT_GT_GT);
               operator = next;
             }
           }
@@ -5646,7 +5646,7 @@ class Parser {
     if (!enteredLoop && _recoverAtPrecedenceLevel && !_currentlyRecovering) {
       // Attempt recovery
       if (_attemptPrecedenceLevelRecovery(
-          token, precedence, /*currentLevel = */ -1, allowCascades, typeArg)) {
+          token, precedence, /* currentLevel = */ -1, allowCascades, typeArg)) {
         return _parsePrecedenceExpressionLoop(
             precedence, allowCascades, typeArg, token);
       }
@@ -6121,7 +6121,8 @@ class Parser {
     }
     bool old = mayParseFunctionExpressions;
     mayParseFunctionExpressions = true;
-    token = parseParenthesizedExpressionOrRecordLiteral(token, null);
+    token = parseParenthesizedExpressionOrRecordLiteral(
+        token, /* constKeywordForRecord = */ null);
     mayParseFunctionExpressions = old;
     return token;
   }
@@ -6243,7 +6244,7 @@ class Parser {
       listener.handleParenthesizedCondition(begin, case_);
     } else {
       token = ensureCloseParen(token, begin);
-      listener.handleParenthesizedCondition(begin, null);
+      listener.handleParenthesizedCondition(begin, /* case_ = */ null);
     }
     assert(optional(')', token));
     return token;
@@ -9293,7 +9294,7 @@ class Parser {
     // grammar
     token = parsePrecedenceExpression(
         token, SELECTOR_PRECEDENCE, /* allowCascades = */ false);
-    listener.handleConstantPattern(null);
+    listener.handleConstantPattern(/* constKeyword = */ null);
     return token;
   }
 

pkg/_fe_analyzer_shared/lib/src/parser/parser_main.dart

@@ -33,7 +33,7 @@ class DebugListener extends Listener {
 mainEntryPoint(List<String> arguments) async {
   for (String argument in arguments) {
     if (argument.startsWith("@")) {
-      Uri uri = Uri.base.resolve(argument.substring(/* startIndex = */ 1));
+      Uri uri = Uri.base.resolve(argument.substring(/* start = */ 1));
       await for (String file in new File.fromUri(uri)
           .openRead()
           .cast<List<int>>()

pkg/_fe_analyzer_shared/lib/src/parser/quote.dart

@@ -130,7 +130,7 @@ String unescapeLastStringPart(String last, Quote quote, Object location,
     bool isLastQuoteSynthetic, UnescapeErrorListener listener) {
   int end = last.length - (isLastQuoteSynthetic ? 0 : lastQuoteLength(quote));
   return unescape(
-      last.substring(/* startIndex = */ 0, end), quote, location, listener);
+      last.substring(/* start = */ 0, end), quote, location, listener);
 }
 
 String unescapeString(

pkg/_fe_analyzer_shared/lib/src/parser/stack_listener.dart

@@ -261,7 +261,7 @@ abstract class StackListener extends Listener {
       String s = "  $o";
       int index = s.indexOf("\n");
       if (index != -1) {
-        s = s.substring(/* startIndex = */ 0, index) + "...";
+        s = s.substring(/* start = */ 0, index) + "...";
       }
       print(s);
     }

pkg/_fe_analyzer_shared/lib/src/parser/type_info.dart

@@ -403,7 +403,7 @@ TypeParamOrArgInfo computeTypeParamOrArg(Token token,
   } else if (optional('(', next)) {
     bool recordType = false;
     if (isPossibleRecordType(next)) {
-      TypeInfo type = computeType(beginGroup, false);
+      TypeInfo type = computeType(beginGroup, /* required = */ false);
       if (type is ComplexTypeInfo &&
           (type.recordType || type.gftReturnTypeHasRecordType) &&
           !type.recovered) {

pkg/_fe_analyzer_shared/lib/src/parser/type_info_impl.dart

@@ -600,9 +600,11 @@ class ComplexTypeInfo implements TypeInfo {
       // generate the full type.
       noType.parseType(token, parser);
     } else if (recordType) {
-      token = parser.parseRecordType(start, token, beforeQuestionMark != null);
+      token = parser.parseRecordType(start, token,
+          /* questionMarkPartOfType = */ beforeQuestionMark != null);
     } else if (gftReturnTypeHasRecordType) {
-      token = parser.parseRecordType(start, token, true);
+      token = parser.parseRecordType(
+          start, token, /* questionMarkPartOfType = */ true);
     } else {
       Token typeRefOrPrefix = token.next!;
       if (optional('void', typeRefOrPrefix)) {

pkg/_fe_analyzer_shared/lib/src/scanner/string_canonicalizer.dart

@@ -18,7 +18,8 @@ abstract class Node {
 class StringNode extends Node {
   StringNode(super.payload, super.next);
 
-  int get hash => StringCanonicalizer.hashString(payload, 0, payload.length);
+  int get hash =>
+      StringCanonicalizer.hashString(payload, /* start = */ 0, payload.length);
 }
 
 class Utf8Node extends Node {
@@ -163,7 +164,8 @@ class StringCanonicalizer {
 
   String canonicalizeString(String data) {
     if (_count > _size) rehash();
-    final int index = hashString(data, 0, data.length) & (_size - 1);
+    final int index =
+        hashString(data, /* start = */ 0, data.length) & (_size - 1);
     Node? s = _nodes[index];
     Node? t = s;
     while (t != null) {