[cfe] Remove agnostic mode

The agnostic mode was added to allow the platform dill embedded in
the VM to support both weak and strong mode. Since weak mode is no
longer supported in the VM, the agnostic mode can new be deleted.

All uses of the agnostic in Dart and Flutter have been removed prior
to this change.

Change-Id: Iff0f69d9cd64e887e01cd7e7d336a97761bd6d4b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366801
Reviewed-by: Alexander Thomas <[email protected]>
Commit-Queue: Johnni Winther <[email protected]>
Reviewed-by: Jens Johansen <[email protected]>

Author: johnniwinther

build/rbe/rewrapper_dart.py

@@ -475,7 +475,6 @@ def parse_compile_platform(self):
                     '--no-defines',
                     '--nnbd-strong',
                     '--nnbd-weak',
-                    '--nnbd-agnostic',
                     '--exclude-source',
             ]:
                 pass

pkg/_fe_analyzer_shared/lib/src/messages/codes_generated.dart

@@ -241,28 +241,6 @@ Message _withArgumentsAccessError(String name) {
   );
 }
 
-// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
-const Code<Null> codeAgnosticWithStrongDillLibrary =
-    messageAgnosticWithStrongDillLibrary;
-
-// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
-const MessageCode messageAgnosticWithStrongDillLibrary = const MessageCode(
-  "AgnosticWithStrongDillLibrary",
-  problemMessage:
-      r"""Loaded library is compiled with sound null safety and cannot be used in compilation for agnostic null safety.""",
-);
-
-// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
-const Code<Null> codeAgnosticWithWeakDillLibrary =
-    messageAgnosticWithWeakDillLibrary;
-
-// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
-const MessageCode messageAgnosticWithWeakDillLibrary = const MessageCode(
-  "AgnosticWithWeakDillLibrary",
-  problemMessage:
-      r"""Loaded library is compiled with unsound null safety and cannot be used in compilation for agnostic null safety.""",
-);
-
 // DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
 const Code<Null> codeAmbiguousExtensionCause = messageAmbiguousExtensionCause;
 
@@ -12913,15 +12891,6 @@ const MessageCode messageNoUnnamedConstructorInObject = const MessageCode(
   problemMessage: r"""'Object' has no unnamed constructor.""",
 );
 
-// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
-const Code<Null> codeNonAgnosticConstant = messageNonAgnosticConstant;
-
-// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
-const MessageCode messageNonAgnosticConstant = const MessageCode(
-  "NonAgnosticConstant",
-  problemMessage: r"""Constant value is not strong/weak mode agnostic.""",
-);
-
 // DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
 const Template<Message Function(String character, int codePoint)>
     templateNonAsciiIdentifier =

pkg/front_end/lib/src/api_prototype/compiler_options.dart

@@ -256,8 +256,7 @@ class CompilerOptions {
   /// Whether to write a file (e.g. a dill file) when reporting a crash.
   bool writeFileOnCrashReport = true;
 
-  /// Whether nnbd weak, strong or agnostic mode is used if experiment
-  /// 'non-nullable' is enabled.
+  /// Whether nnbd weak or strong mode is used.
   NnbdMode nnbdMode = NnbdMode.Strong;
 
   /// The current sdk version string, e.g. "2.6.0-edge.sha1hash".

pkg/front_end/lib/src/base/command_line_options.dart

@@ -9,7 +9,6 @@ import 'package:kernel/target/targets.dart';
 class Flags {
   // TODO(johnniwinther): What is the right name for this?
   static const String nnbdStrongMode = "--nnbd-strong";
-  static const String nnbdAgnosticMode = "--nnbd-agnostic";
   static const String nnbdWeakMode = "--nnbd-weak";
 
   static const String forceLateLowering = "--force-late-lowering";
@@ -115,8 +114,6 @@ class Options {
       const Option(Flags.nnbdWeakMode, const BoolValue(false));
   static const Option<bool> nnbdStrongMode =
       const Option(Flags.nnbdStrongMode, const BoolValue(false));
-  static const Option<bool> nnbdAgnosticMode =
-      const Option(Flags.nnbdAgnosticMode, const BoolValue(false));
   static const Option<String> target = const Option(
       Flags.target, const StringValue(defaultValue: 'vm'),
       aliases: ["-t"]);

pkg/front_end/lib/src/base/nnbd_mode.dart

@@ -5,5 +5,4 @@
 enum NnbdMode {
   Strong,
   Weak,
-  Agnostic,
 }

pkg/front_end/lib/src/base/processed_options.dart

@@ -298,7 +298,6 @@ class ProcessedOptions {
               messageCompilingWithoutSoundNullSafety.severity);
           break;
         case NnbdMode.Strong:
-        case NnbdMode.Agnostic:
           break;
       }
     }
@@ -430,8 +429,7 @@ class ProcessedOptions {
           '${component.libraries.join('\n')}');
     }
     if (nnbdMode == NnbdMode.Strong &&
-        !(component.mode == NonNullableByDefaultCompiledMode.Strong ||
-            component.mode == NonNullableByDefaultCompiledMode.Agnostic)) {
+        component.mode != NonNullableByDefaultCompiledMode.Strong) {
       throw new FormatException(
           'Provided .dill file for the following libraries does not '
           'support sound null safety:\n'

pkg/front_end/lib/src/compute_platform_binaries_location.dart

@@ -34,30 +34,21 @@ String? computePlatformDillName(
           return 'ddc_outline_unsound.dill';
         //TODO(johnniwinther): Support using the full dill.
         //return 'ddc_platform_unsound.dill';
-        case NnbdMode.Agnostic:
-          break;
       }
-      break;
     case 'dart2js':
       switch (nnbdMode) {
         case NnbdMode.Strong:
           return 'dart2js_platform.dill';
         case NnbdMode.Weak:
           return 'dart2js_platform_unsound.dill';
-        case NnbdMode.Agnostic:
-          break;
       }
-      break;
     case 'dart2js_server':
       switch (nnbdMode) {
         case NnbdMode.Strong:
           return 'dart2js_server_platform.dill';
         case NnbdMode.Weak:
           return 'dart2js_server_platform_unsound.dill';
-        case NnbdMode.Agnostic:
-          break;
       }
-      break;
     case 'vm':
       // TODO(johnniwinther): Stop generating 'vm_platform.dill' and rename
       // 'vm_platform_strong.dill' to 'vm_platform.dill'.
@@ -71,7 +62,6 @@ String? computePlatformDillName(
         //TODO(johnniwinther): Support using the full dill.
         //return 'dart2wasm_platform.dill';
         case NnbdMode.Weak:
-        case NnbdMode.Agnostic:
           break;
       }
       break;
@@ -82,7 +72,6 @@ String? computePlatformDillName(
         //TODO(johnniwinther): Support using the full dill.
         //return 'dart2wasm_js_compatibility_platform.dill';
         case NnbdMode.Weak:
-        case NnbdMode.Agnostic:
           break;
       }
       break;

pkg/front_end/lib/src/fasta/incremental_compiler.dart

@@ -1009,14 +1009,6 @@ class IncrementalCompiler implements IncrementalKernelGenerator {
             kernelTarget.loader.hasInvalidNnbdModeLibrary = true;
           }
           break;
-        case NnbdMode.Agnostic:
-          // Don't expect strong, weak or invalid.
-          if (seenModes[NonNullableByDefaultCompiledMode.Strong.index] ||
-              seenModes[NonNullableByDefaultCompiledMode.Weak.index] ||
-              seenModes[NonNullableByDefaultCompiledMode.Invalid.index]) {
-            kernelTarget.loader.hasInvalidNnbdModeLibrary = true;
-          }
-          break;
       }
     } else {
       // Don't expect strong or invalid.
@@ -2705,9 +2697,6 @@ class _InitializationFromUri extends _InitializationFromSdkSummary {
             case NnbdMode.Strong:
               compiledMode = NonNullableByDefaultCompiledMode.Strong;
               break;
-            case NnbdMode.Agnostic:
-              compiledMode = NonNullableByDefaultCompiledMode.Agnostic;
-              break;
           }
         } else {
           compiledMode = NonNullableByDefaultCompiledMode.Weak;

pkg/front_end/lib/src/fasta/kernel/constant_collection_builders.dart

@@ -172,15 +172,6 @@ class SetConstantBuilder extends _ListOrSetConstantBuilder<SetLiteral> {
       return evaluator.createEvaluationErrorConstant(
           context, templateConstEvalDuplicateElement.withArguments(constant));
     }
-    if (evaluator.evaluationMode == EvaluationMode.agnostic) {
-      Constant weakConstant =
-          evaluator._weakener.visitConstant(constant) ?? constant;
-      bool weakUnseen = weakSeen.add(weakConstant);
-      if (unseen != weakUnseen) {
-        return evaluator.createEvaluationErrorConstant(
-            context, messageNonAgnosticConstant);
-      }
-    }
 
     List<Constant> lastPart;
     if (parts.last is List<Constant>) {
@@ -318,14 +309,7 @@ class MapConstantBuilder {
       return evaluator.createEvaluationErrorConstant(
           keyContext, templateConstEvalDuplicateKey.withArguments(key));
     }
-    if (evaluator.evaluationMode == EvaluationMode.agnostic) {
-      Constant weakKey = evaluator._weakener.visitConstant(key) ?? key;
-      bool weakUnseenKey = weakSeenKeys.add(weakKey);
-      if (unseenKey != weakUnseenKey) {
-        return evaluator.createEvaluationErrorConstant(
-            keyContext, messageNonAgnosticConstant);
-      }
-    }
+
     Constant key2 = evaluator.ensureIsSubtype(key, keyType, keyContext);
     if (key2 is AbortConstant) return key2;
     Constant value2 = evaluator.ensureIsSubtype(value, valueType, valueContext);