Skip to content

Commit c7e8a37

Browse files
DanTupcommit-bot@chromium.org
authored andcommitted
Add a divider between the element description and docs in hovers
Change-Id: I08dc275fd343dc7eaa0f0c6033b8889882889cd2 Reviewed-on: https://dart-review.googlesource.com/c/87406 Commit-Queue: Brian Wilkerson <[email protected]> Reviewed-by: Brian Wilkerson <[email protected]> Auto-Submit: Danny Tuppeny <[email protected]>
1 parent 54d1118 commit c7e8a37

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

pkg/analysis_server/lib/src/lsp/handlers/handler_hover.dart

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,14 +43,15 @@ class HoverHandler extends MessageHandler<TextDocumentPositionParams, Hover> {
4343
}
4444

4545
final content = new StringBuffer();
46+
const divider = '---';
4647

4748
// Description.
4849
if (hover.elementDescription != null) {
4950
content.writeln('```dart');
5051
if (hover.isDeprecated) {
5152
content.write('(deprecated) ');
5253
}
53-
content..writeln(hover.elementDescription)..writeln('```')..writeln();
54+
content..writeln(hover.elementDescription)..writeln('```');
5455
}
5556

5657
// Source library.
@@ -66,6 +67,9 @@ class HoverHandler extends MessageHandler<TextDocumentPositionParams, Hover> {
6667

6768
// Doc comments.
6869
if (hover.dartdoc != null) {
70+
if (content.length != 0) {
71+
content.writeln(divider);
72+
}
6973
content.writeln(cleanDartdoc(hover.dartdoc));
7074
}
7175

pkg/analysis_server/test/lsp/hover_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ class HoverTest extends AbstractLspAnalysisServerTest {
4646
```dart
4747
String abc
4848
```
49-
49+
---
5050
This is a string.
5151
5252
With some [refs] and some

0 commit comments

Comments
 (0)