Skip to content

Commit d0be238

Browse files
Add missing void annotation: refs #32161
Change-Id: Iea314e7a23513eef1823dbfe8690494f45af9185 Reviewed-on: https://dart-review.googlesource.com/42323 Reviewed-by: Dmitry Stefantsov <[email protected]> Commit-Queue: Mike Fairhurst <[email protected]>
1 parent 532ec84 commit d0be238

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

pkg/kernel/lib/transformations/treeshaker.dart

+10-10
Original file line numberDiff line numberDiff line change
@@ -1161,22 +1161,22 @@ class _ExternalTypeVisitor extends DartTypeVisitor {
11611161
}
11621162
}
11631163

1164-
visitCovariant(DartType type) => type?.accept(this);
1164+
void visitCovariant(DartType type) => type?.accept(this);
11651165

1166-
visitInvariant(DartType type) => shaker._invariantVisitor.visit(type);
1166+
void visitInvariant(DartType type) => shaker._invariantVisitor.visit(type);
11671167

1168-
visitInvalidType(InvalidType node) {}
1168+
void visitInvalidType(InvalidType node) {}
11691169

1170-
visitDynamicType(DynamicType node) {
1170+
void visitDynamicType(DynamicType node) {
11711171
// TODO(asgerf): Find a suitable model for untyped externals, e.g. track
11721172
// them to the first type boundary.
11731173
}
11741174

1175-
visitVoidType(VoidType node) {}
1175+
void visitVoidType(VoidType node) {}
11761176

1177-
visitVectorType(VectorType node) {}
1177+
void visitVectorType(VectorType node) {}
11781178

1179-
visitInterfaceType(InterfaceType node) {
1179+
void visitInterfaceType(InterfaceType node) {
11801180
if (isCovariant) {
11811181
shaker._addInstantiatedExternalSubclass(node.classNode);
11821182
}
@@ -1197,11 +1197,11 @@ class _ExternalTypeVisitor extends DartTypeVisitor {
11971197
}
11981198
}
11991199

1200-
visitTypedefType(TypedefType node) {
1200+
void visitTypedefType(TypedefType node) {
12011201
shaker.addUsedTypedef(node.typedefNode);
12021202
}
12031203

1204-
visitFunctionType(FunctionType node) {
1204+
void visitFunctionType(FunctionType node) {
12051205
visit(node.returnType);
12061206
for (int i = 0; i < node.positionalParameters.length; ++i) {
12071207
visitContravariant(node.positionalParameters[i]);
@@ -1211,7 +1211,7 @@ class _ExternalTypeVisitor extends DartTypeVisitor {
12111211
}
12121212
}
12131213

1214-
visitTypeParameterType(TypeParameterType node) {}
1214+
void visitTypeParameterType(TypeParameterType node) {}
12151215

12161216
/// Just treat a couple of whitelisted classes as having covariant type
12171217
/// parameters.

0 commit comments

Comments
 (0)