Skip to content

Commit d99e7a9

Browse files
Sergey G. Grekhovathomas
Sergey G. Grekhov
authored and
athomas
committed
[co19] typo fixed and tests that shifts big integers skipped on JS
Change-Id: Ie1cb192d21022a4c83eec5e49056533fd513607b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192140 Reviewed-by: Erik Ernst <[email protected]>
1 parent def73d6 commit d99e7a9

File tree

2 files changed

+20
-20
lines changed

2 files changed

+20
-20
lines changed

‎tests/co19/co19-dart2js.status

+9-9
Original file line numberDiff line numberDiff line change
@@ -3,19 +3,19 @@
33
# BSD-style license that can be found in the LICENSE file.
44

55
[ $compiler == dart2js ]
6-
Language/Expressions/Constants/integer_size_t03: SkipByDesign # uses integer literal not representable as JavaScript numbert
7-
Language/Expressions/Constants/integer_size_t04: SkipByDesign # uses integer literal not representable as JavaScript numbert
8-
Language/Expressions/Constants/literal_number_t01: SkipByDesign # uses integer literal not representable as JavaScript numbert
9-
Language/Expressions/Constants/math_operators_t01: SkipByDesign # uses integer literal not representable as JavaScript numbert
10-
Language/Expressions/Constants/math_operators_t06: SkipByDesign # uses integer literal not representable as JavaScript numbert
6+
Language/Expressions/Constants/integer_size_t03: SkipByDesign # uses integer literal not representable as JavaScript number
7+
Language/Expressions/Constants/integer_size_t04: SkipByDesign # uses integer literal not representable as JavaScript number
8+
Language/Expressions/Constants/literal_number_t01: SkipByDesign # uses integer literal not representable as JavaScript number
9+
Language/Expressions/Constants/math_operators_t01: SkipByDesign # uses integer literal not representable as JavaScript number
10+
Language/Expressions/Constants/math_operators_t06: SkipByDesign # uses integer literal not representable as JavaScript number
1111
Language/Expressions/Null/instance_of_class_null_t01: Skip # dart:mirrors not supported https://github.com/dart-lang/co19/issues/522.
12-
Language/Expressions/Numbers/integer_size_t03: SkipByDesign # uses integer literal not representable as JavaScript numbert
13-
Language/Expressions/Numbers/static_type_of_int_t01: SkipByDesign # uses integer literal not representable as JavaScript numbert
12+
Language/Expressions/Numbers/integer_size_t03: SkipByDesign # uses integer literal not representable as JavaScript number
13+
Language/Expressions/Numbers/static_type_of_int_t01: SkipByDesign # uses integer literal not representable as JavaScript number
1414
Language/Expressions/Numbers/syntax_t06: SkipByDesign # uses integer literal not representable as JavaScript number
1515
Language/Expressions/Numbers/syntax_t09: SkipByDesign # uses integer literal not representable as JavaScript number
1616
Language/Expressions/Object_Identity/object_t02: SkipByDesign # https://github.com/dart-lang/sdk/issues/42222#issuecomment-640431711
17-
Language/Expressions/Shift/integer_t01: SkipByDesign # uses integer literal not representable as JavaScript numbert
18-
Language/Expressions/Shift/integer_t02: SkipByDesign # uses integer literal not representable as JavaScript numbert
17+
Language/Expressions/Shift/integer_t06: SkipByDesign # uses integer literal not representable as JavaScript number
18+
Language/Expressions/Shift/integer_t07: SkipByDesign # uses integer literal not representable as JavaScript number
1919
Language/Expressions/Spawning_an_Isolate/new_isolate_t01: SkipByDesign
2020
Language/Functions/External_Functions/not_connected_to_a_body_t01: SkipByDesign # Non-JS-interop external members are not supported
2121
Language/Libraries_and_Scripts/Scripts/main_optional_parameters_t01: SkipByDesign # https://github.com/dart-lang/co19/issues/952

‎tests/co19/co19-dartdevc.status

+11-11
Original file line numberDiff line numberDiff line change
@@ -52,21 +52,21 @@ Language/Classes/Instance_Variables/definition_t01: Skip # Times out
5252
Language/Classes/Instance_Variables/definition_t02: Skip # Times out
5353
Language/Classes/Instance_Variables/definition_t04: Skip # Times out
5454
Language/Classes/Setters/instance_setter_t01: Skip # Times out
55-
Language/Expressions/Constants/integer_size_t03: SkipByDesign # uses integer literal not representable as JavaScript numbert
56-
Language/Expressions/Constants/integer_size_t04: SkipByDesign # uses integer literal not representable as JavaScript numbert
57-
Language/Expressions/Constants/literal_number_t01: SkipByDesign # uses integer literal not representable as JavaScript numbert
58-
Language/Expressions/Constants/math_operators_t01: SkipByDesign # uses integer literal not representable as JavaScript numbert
59-
Language/Expressions/Constants/math_operators_t06: SkipByDesign # uses integer literal not representable as JavaScript numbert
55+
Language/Expressions/Constants/integer_size_t03: SkipByDesign # uses integer literal not representable as JavaScript number
56+
Language/Expressions/Constants/integer_size_t04: SkipByDesign # uses integer literal not representable as JavaScript number
57+
Language/Expressions/Constants/literal_number_t01: SkipByDesign # uses integer literal not representable as JavaScript number
58+
Language/Expressions/Constants/math_operators_t01: SkipByDesign # uses integer literal not representable as JavaScript number
59+
Language/Expressions/Constants/math_operators_t06: SkipByDesign # uses integer literal not representable as JavaScript number
6060
Language/Expressions/Function_Invocation/async_generator_invokation_t08: Skip # Times out
6161
Language/Expressions/Function_Invocation/async_generator_invokation_t10: Skip # Times out
6262
Language/Expressions/Null/instance_of_class_null_t01: Skip # dart:mirrors not supported https://github.com/dart-lang/co19/issues/522.
63-
Language/Expressions/Numbers/integer_size_t03: SkipByDesign # uses integer literal not representable as JavaScript numbert
64-
Language/Expressions/Numbers/static_type_of_int_t01: SkipByDesign # uses integer literal not representable as JavaScript numbert
65-
Language/Expressions/Numbers/syntax_t06: SkipByDesign # uses integer literal not representable as JavaScript numbert
66-
Language/Expressions/Numbers/syntax_t09: SkipByDesign # uses integer literal not representable as JavaScript numbert
63+
Language/Expressions/Numbers/integer_size_t03: SkipByDesign # uses integer literal not representable as JavaScript number
64+
Language/Expressions/Numbers/static_type_of_int_t01: SkipByDesign # uses integer literal not representable as JavaScript number
65+
Language/Expressions/Numbers/syntax_t06: SkipByDesign # uses integer literal not representable as JavaScript number
66+
Language/Expressions/Numbers/syntax_t09: SkipByDesign # uses integer literal not representable as JavaScript number
6767
Language/Expressions/Object_Identity/object_t02: SkipByDesign # https://github.com/dart-lang/sdk/issues/42222#issuecomment-640431711
68-
Language/Expressions/Shift/integer_t01: SkipByDesign # uses integer literal not representable as JavaScript numbert
69-
Language/Expressions/Shift/integer_t02: SkipByDesign # uses integer literal not representable as JavaScript numbert
68+
Language/Expressions/Shift/integer_t06: SkipByDesign # uses integer literal not representable as JavaScript number
69+
Language/Expressions/Shift/integer_t07: SkipByDesign # uses integer literal not representable as JavaScript number
7070
Language/Expressions/Spawning_an_Isolate/new_isolate_t01: SkipByDesign # dart:isolate not supported.
7171
Language/Functions/External_Functions/not_connected_to_a_body_t01: SkipByDesign # External variables are not supported
7272
Language/Libraries_and_Scripts/Scripts/top_level_syntax_t01: SkipByDesign # External variables are not supported

0 commit comments

Comments
 (0)