Skip to content

Commit d9aaa9b

Browse files
committed
Reland "[co19] Roll co19 to ae818220b12ec9c2470519db2c7167cbe4745e12"
This reverts commit 88ee333. Reason for revert: Hook added by mistake removed. Original change's description: > Revert "[co19] Roll co19 to ae818220b12ec9c2470519db2c7167cbe4745e12" > > This reverts commit 03e8ddd. > > Reason for revert: Change to hooks does not work with Windows. > > Original change's description: > > [co19] Roll co19 to ae818220b12ec9c2470519db2c7167cbe4745e12 > > > > 2021-03-22 [email protected] Fixes #1032. Change place where analyzer expects COMPILE_TIME_ERROR.UNCHECKED_USE_OF_NULLABLE_VALUE > > 2021-03-22 [email protected] Fixes #1027. Typo fixed > > 2021-03-22 [email protected] Fixes #1026. Missed experimental flag added > > 2021-03-22 [email protected] Fixes SDK issue #45381. Use 32-bit int boundaries for 32-bit systems > > 2021-03-19 [email protected] #1024. Tests that plays with the integers not representable in JS moved to separate files. These files will be skipped on JS > > > > Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-mac-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try,vm-kernel-precomp-nnbd-linux-release-x64-try > > Change-Id: Idc63625a841f1f90b0cce5db9ca6add13e4d1192 > > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192303 > > Reviewed-by: William Hesse <[email protected]> > > Commit-Queue: Alexander Thomas <[email protected]> > > [email protected],[email protected] > > Change-Id: I5f66db541034377f5d68424073282080d13fd34b > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try > Cq-Include-Trybots: dart2js-nnbd-linux-x64-chrome-try > Cq-Include-Trybots: ddc-nnbd-linux-release-chrome-try > Cq-Include-Trybots: front-end-nnbd-linux-release-x64-try > Cq-Include-Trybots: vm-kernel-nnbd-linux-debug-x64-try > Cq-Include-Trybots: vm-kernel-nnbd-linux-release-simarm64-try > Cq-Include-Trybots: vm-kernel-nnbd-linux-release-x64-try > Cq-Include-Trybots: vm-kernel-nnbd-mac-release-x64-try > Cq-Include-Trybots: vm-kernel-nnbd-win-release-x64-try > Cq-Include-Trybots: vm-kernel-precomp-nnbd-linux-debug-x64-try > Cq-Include-Trybots: vm-kernel-precomp-nnbd-linux-release-simarm64-try > Cq-Include-Trybots: vm-kernel-precomp-nnbd-linux-release-x64-try > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192380 > Reviewed-by: William Hesse <[email protected]> # Not skipping CQ checks because this is a reland. Change-Id: Ie54fde2d92d1b2cdb3b70835f1f8c17e3c5ac477 Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-mac-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try,vm-kernel-precomp-nnbd-linux-release-x64-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192384 Reviewed-by: Alexander Thomas <[email protected]> Reviewed-by: William Hesse <[email protected]>
1 parent 51ca214 commit d9aaa9b

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

DEPS

+1-3
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ vars = {
4444
# co19 is a cipd package. Use update.sh in tests/co19[_2] to update these
4545
# hashes. It requires access to the dart-build-access group, which EngProd
4646
# has.
47-
"co19_rev": "1abf208ef6428aac8fee6f3175d65b1c59cd15c8",
47+
"co19_rev": "ae818220b12ec9c2470519db2c7167cbe4745e12",
4848
"co19_2_rev": "cf6eed0535e45413672bb5bb6e65df9f59846372",
4949

5050
# The internal benchmarks to use. See go/dart-benchmarks-internal
@@ -654,8 +654,6 @@ deps_os = {
654654
}
655655
}
656656

657-
# TODO(iposva): Move the necessary tools so that hooks can be run
658-
# without the runtime being available.
659657
hooks = [
660658
{
661659
"name": "firefox_jsshell",

0 commit comments

Comments
 (0)