[VM] Remove observatory_2 directory and all references to it.

TEST=ci

Change-Id: I4e95e59fc909c01517ae59f39d04c38bb353b85a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/330525
Reviewed-by: Ben Konyi <[email protected]>
Reviewed-by: Ryan Macnak <[email protected]>
Commit-Queue: Siva Annamalai <[email protected]>

Author: a-siva

pkg/scrape/lib/scrape.dart

@@ -229,7 +229,6 @@ class Scrape {
         if (entry.path.contains('/analyzer_cli/test/')) continue;
         if (entry.path.contains('/compiler/test/')) continue;
         if (entry.path.contains('/dart/runtime/observatory/tests/')) continue;
-        if (entry.path.contains('/dart/runtime/observatory_2/tests/')) continue;
         if (entry.path.contains('/dart/runtime/tests/')) continue;
         if (entry.path.contains('/dart/tests/')) continue;
         if (entry.path.contains('/dev_compiler/test/')) continue;

pkg/test_runner/lib/src/options.dart

@@ -21,8 +21,6 @@ const _legacyTestSelectors = [
   'language_2',
   'lib_2',
   'kernel',
-  'observatory_ui_2',
-  'service_2',
   'standalone_2',
   'utils',
   'vm',

pkg/test_runner/lib/src/test_configurations.dart

@@ -31,8 +31,6 @@ final testSuiteDirectories = [
   Path('pkg'),
   Path('runtime/observatory/tests/observatory_ui'),
   Path('runtime/observatory/tests/service'),
-  Path('runtime/observatory_2/tests/observatory_ui_2'),
-  Path('runtime/observatory_2/tests/service_2'),
   Path('runtime/tests/vm'),
   Path('samples'),
   Path('tests/corelib'),

pkg/test_runner/lib/src/test_suite.dart

@@ -739,7 +739,7 @@ class StandardTestSuite extends TestSuite {
       _enqueueStandardTest(testFile, expectationSet, onTest);
     } else if (configuration.runtime.isBrowser) {
       _enqueueBrowserTest(testFile, expectationSet, onTest);
-    } else if (suiteName == 'service' || suiteName == 'service_2') {
+    } else if (suiteName == 'service') {
       _enqueueServiceTest(testFile, expectationSet, onTest);
     } else {
       _enqueueStandardTest(testFile, expectationSet, onTest);

pkg/test_runner/test/options_test.dart

@@ -116,9 +116,7 @@ void testSelectors() {
       'vm',
       'utils',
       'lib_2',
-      'service_2',
       'kernel',
-      'observatory_ui_2',
       'ffi_2',
     }, configuration.selectors.keys, "suites for $arguments");
   }