Skip to content

Commit e3b67fb

Browse files
---
yaml --- r: 263071 b: refs/heads/main c: d94dd29 h: refs/heads/main i: 263069: 02e7aa7 263067: 050181e 263063: 6f3db78 263055: cf6dafb 263039: 8576234
1 parent 5b5d798 commit e3b67fb

File tree

4 files changed

+254
-52
lines changed

4 files changed

+254
-52
lines changed

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1994,4 +1994,4 @@ refs/tags/2.14.0-96.0.dev: 1eee24e50fc3028754d9a8e98852b949c04da4e4
19941994
refs/tags/2.14.0-97.0.dev: ba9c1636e87fbdcc02b8bc4a584455c32f8378b4
19951995
refs/tags/2.14.0-98.0.dev: f2d370c93582bbf4da42b5dd4c906d6145b01ea9
19961996
refs/tags/2.14.0-99.0.dev: e722f62b48fb382534efc1f20735def68848006f
1997-
refs/heads/main: 0aa59c48028cd5b4360d5658b558c2c9c294c88e
1997+
refs/heads/main: d94dd29bb8d3a199f51c52f87e0df6ae3cc7d298

trunk/runtime/bin/dartutils.cc

Lines changed: 26 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@ static bool IsWindowsHost() {
3737
}
3838

3939

40-
static const char* MapLibraryUrl(CommandLineOptions* url_mapping,
41-
const char* url_string) {
40+
const char* DartUtils::MapLibraryUrl(CommandLineOptions* url_mapping,
41+
const char* url_string) {
4242
ASSERT(url_mapping != NULL);
4343
// We need to check if the passed in url is found in the url_mapping array,
4444
// in that case use the mapped entry.
@@ -233,32 +233,42 @@ Dart_Handle DartUtils::ReadStringFromFile(const char* filename) {
233233
}
234234

235235

236-
static Dart_Handle ResolveScriptUri(Dart_Handle script_uri,
237-
Dart_Handle builtin_lib) {
236+
Dart_Handle DartUtils::ResolveScriptUri(Dart_Handle script_uri,
237+
Dart_Handle builtin_lib) {
238238
const int kNumArgs = 3;
239239
Dart_Handle dart_args[kNumArgs];
240-
dart_args[0] = DartUtils::NewString(DartUtils::original_working_directory);
240+
dart_args[0] = NewString(original_working_directory);
241241
dart_args[1] = script_uri;
242242
dart_args[2] = (IsWindowsHost() ? Dart_True() : Dart_False());
243243
return Dart_Invoke(builtin_lib,
244-
DartUtils::NewString("_resolveScriptUri"),
244+
NewString("_resolveScriptUri"),
245245
kNumArgs,
246246
dart_args);
247247
}
248248

249249

250-
static Dart_Handle FilePathFromUri(Dart_Handle script_uri,
251-
Dart_Handle builtin_lib) {
250+
Dart_Handle DartUtils::FilePathFromUri(Dart_Handle script_uri,
251+
Dart_Handle builtin_lib) {
252252
const int kNumArgs = 2;
253253
Dart_Handle dart_args[kNumArgs];
254254
dart_args[0] = script_uri;
255255
dart_args[1] = (IsWindowsHost() ? Dart_True() : Dart_False());
256-
Dart_Handle script_path = Dart_Invoke(
257-
builtin_lib,
258-
DartUtils::NewString("_filePathFromUri"),
259-
kNumArgs,
260-
dart_args);
261-
return script_path;
256+
return Dart_Invoke(builtin_lib,
257+
NewString("_filePathFromUri"),
258+
kNumArgs,
259+
dart_args);
260+
}
261+
262+
263+
Dart_Handle DartUtils::ResolveUri(Dart_Handle library_url,
264+
Dart_Handle url,
265+
Dart_Handle builtin_lib) {
266+
const int kNumArgs = 2;
267+
Dart_Handle dart_args[kNumArgs];
268+
dart_args[0] = library_url;
269+
dart_args[1] = url;
270+
return Dart_Invoke(
271+
builtin_lib, NewString("_resolveUri"), kNumArgs, dart_args);
262272
}
263273

264274

@@ -291,12 +301,7 @@ Dart_Handle DartUtils::LibraryTagHandler(Dart_LibraryTag tag,
291301
if (Dart_IsError(library_url)) {
292302
return library_url;
293303
}
294-
const int kNumArgs = 2;
295-
Dart_Handle dart_args[kNumArgs];
296-
dart_args[0] = library_url;
297-
dart_args[1] = url;
298-
return Dart_Invoke(
299-
builtin_lib, NewString("_resolveUri"), kNumArgs, dart_args);
304+
return ResolveUri(library_url, url, builtin_lib);
300305
}
301306
if (is_dart_scheme_url) {
302307
ASSERT(tag == kImportTag);
@@ -343,7 +348,7 @@ Dart_Handle DartUtils::LibraryTagHandler(Dart_LibraryTag tag,
343348

344349
static Dart_Handle ReadSource(Dart_Handle script_uri,
345350
Dart_Handle builtin_lib) {
346-
Dart_Handle script_path = FilePathFromUri(script_uri, builtin_lib);
351+
Dart_Handle script_path = DartUtils::FilePathFromUri(script_uri, builtin_lib);
347352
if (Dart_IsError(script_path)) {
348353
return script_path;
349354
}

trunk/runtime/bin/dartutils.h

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,19 @@ class DartUtils {
144144

145145
static void SetOriginalWorkingDirectory();
146146

147+
static const char* MapLibraryUrl(CommandLineOptions* url_mapping,
148+
const char* url_string);
149+
150+
static Dart_Handle ResolveScriptUri(Dart_Handle script_uri,
151+
Dart_Handle builtin_lib);
152+
153+
static Dart_Handle FilePathFromUri(Dart_Handle script_uri,
154+
Dart_Handle builtin_lib);
155+
156+
static Dart_Handle ResolveUri(Dart_Handle library_url,
157+
Dart_Handle url,
158+
Dart_Handle builtin_lib);
159+
147160
// Global state that stores the original working directory..
148161
static const char* original_working_directory;
149162

0 commit comments

Comments
 (0)