Improve the highlight range for body_might_complete_normally

Closes #44446

Change-Id: I895253b341f299553441e073efb7485ec086ee5f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181640
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>

Author: bwilkerson

pkg/analyzer/lib/src/generated/resolver.dart

@@ -441,6 +441,11 @@ class ResolverVisitor extends ScopedVisitor {
             CompileTimeErrorCode.BODY_MIGHT_COMPLETE_NORMALLY,
             errorNode,
           );
+        } else if (errorNode is BlockFunctionBody) {
+          errorReporter.reportErrorForToken(
+            CompileTimeErrorCode.BODY_MIGHT_COMPLETE_NORMALLY,
+            errorNode.block.leftBracket,
+          );
         } else {
           errorReporter.reportErrorForNode(
             CompileTimeErrorCode.BODY_MIGHT_COMPLETE_NORMALLY,

pkg/analyzer/test/src/diagnostics/body_might_complete_normally_test.dart

@@ -171,23 +171,23 @@ int foo() {
 
   test_functionExpression_future_int_blockBody_async() async {
     await assertErrorsInCode(r'''
-main() {
+void f() {
   Future<int> Function() foo = () async {};
   foo;
 }
 ''', [
-      error(CompileTimeErrorCode.BODY_MIGHT_COMPLETE_NORMALLY, 43, 8),
+      error(CompileTimeErrorCode.BODY_MIGHT_COMPLETE_NORMALLY, 51, 1),
     ]);
   }
 
   test_functionExpression_future_void_blockBody() async {
     await assertErrorsInCode(r'''
-main() {
+void f() {
   Future<void> Function() foo = () {};
   foo;
 }
 ''', [
-      error(CompileTimeErrorCode.BODY_MIGHT_COMPLETE_NORMALLY, 44, 2),
+      error(CompileTimeErrorCode.BODY_MIGHT_COMPLETE_NORMALLY, 46, 1),
     ]);
   }
 
@@ -202,13 +202,13 @@ main() {
 
   test_functionExpression_notNullable_blockBody() async {
     await assertErrorsInCode(r'''
-main() {
+void f() {
   int Function() foo = () {
   };
   foo;
 }
 ''', [
-      error(CompileTimeErrorCode.BODY_MIGHT_COMPLETE_NORMALLY, 35, 5),
+      error(CompileTimeErrorCode.BODY_MIGHT_COMPLETE_NORMALLY, 37, 1),
     ]);
   }