Skip to content

Commit e5c83a3

Browse files
munificentCommit Bot
authored and
Commit Bot
committed
Update the set of directories scrape ignores containing language tests.
Since tests of our internal tools often deliberately contain edge cases and unusual code constructs, scrape supports ignoring Dart files in those directories in order to focus on more representative code. This updates that ignore list to handle all of the various compiler-related packages I could find. Change-Id: I4006d2b3b14a81572f27db0b65e6c6194c4f7f54 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/241506 Auto-Submit: Bob Nystrom <[email protected]> Reviewed-by: Phil Quitslund <[email protected]> Commit-Queue: Phil Quitslund <[email protected]>
1 parent 84fbee0 commit e5c83a3

File tree

1 file changed

+12
-6
lines changed

1 file changed

+12
-6
lines changed

pkg/scrape/lib/scrape.dart

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -223,15 +223,21 @@ class Scrape {
223223
if (entry.path.endsWith('README.dart')) continue;
224224

225225
if (!_includeLanguageTests) {
226-
if (entry.path.contains('/sdk/tests/')) continue;
227-
if (entry.path.contains('/testcases/')) continue;
228-
if (entry.path.contains('/sdk/runtime/tests/')) continue;
229-
if (entry.path.contains('/linter/test/_data/')) continue;
226+
if (entry.path.contains('/_fe_analyzer_shared/test/')) continue;
227+
if (entry.path.contains('/analysis_server/test/')) continue;
230228
if (entry.path.contains('/analyzer/test/')) continue;
231-
if (entry.path.contains('/dev_compiler/test/')) continue;
232229
if (entry.path.contains('/analyzer_cli/test/')) continue;
233-
if (entry.path.contains('/analysis_server/test/')) continue;
230+
if (entry.path.contains('/compiler/test/')) continue;
231+
if (entry.path.contains('/dart/runtime/observatory/tests/')) continue;
232+
if (entry.path.contains('/dart/runtime/observatory_2/tests/')) continue;
233+
if (entry.path.contains('/dart/runtime/tests/')) continue;
234+
if (entry.path.contains('/dart/tests/')) continue;
235+
if (entry.path.contains('/dev_compiler/test/')) continue;
236+
if (entry.path.contains('/front_end/parser_testcases/')) continue;
237+
if (entry.path.contains('/front_end/test/')) continue;
234238
if (entry.path.contains('/kernel/test/')) continue;
239+
if (entry.path.contains('/linter/test/_data/')) continue;
240+
if (entry.path.contains('/testcases/')) continue;
235241
}
236242

237243
if (!_includeTests) {

0 commit comments

Comments
 (0)