Error for assert initializer in redirecting constructor; fixes #37867

Bug: #37867
Change-Id: I74a809f2202e7ea1beeb45a8ce5d62613f102045
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120100
Commit-Queue: Samuel Rawlins <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>

Author: srawlins

pkg/analyzer/lib/error/error.dart

@@ -71,6 +71,7 @@ const List<ErrorCode> errorCodeValues = const [
   CompileTimeErrorCode.AMBIGUOUS_SET_OR_MAP_LITERAL_EITHER,
   CompileTimeErrorCode.ANNOTATION_WITH_NON_CLASS,
   CompileTimeErrorCode.ANNOTATION_WITH_TYPE_ARGUMENTS,
+  CompileTimeErrorCode.ASSERT_IN_REDIRECTING_CONSTRUCTOR,
   CompileTimeErrorCode.ASYNC_FOR_IN_WRONG_CONTEXT,
   CompileTimeErrorCode.AWAIT_IN_WRONG_CONTEXT,
   CompileTimeErrorCode.BUILT_IN_IDENTIFIER_AS_EXTENSION_NAME,

pkg/analyzer/lib/src/error/codes.dart

@@ -410,6 +410,10 @@ class CompileTimeErrorCode extends AnalyzerErrorCode {
   static const ParserErrorCode ANNOTATION_WITH_TYPE_ARGUMENTS =
       ParserErrorCode.ANNOTATION_WITH_TYPE_ARGUMENTS;
 
+  static const CompileTimeErrorCode ASSERT_IN_REDIRECTING_CONSTRUCTOR =
+      const CompileTimeErrorCode('ASSERT_IN_REDIRECTING_CONSTRUCTOR',
+          "A redirecting constructor can't have an 'assert' initializer.");
+
   /**
    * 17.6.3 Asynchronous For-in: It is a compile-time error if an asynchronous
    * for-in statement appears inside a synchronous function.

pkg/analyzer/lib/src/generated/error_verifier.dart

@@ -4538,7 +4538,8 @@ class ErrorVerifier extends RecursiveAstVisitor<void> {
    * redirected constructor invocation(s), super constructor invocations and
    * field initializers.
    *
-   * See [CompileTimeErrorCode.DEFAULT_VALUE_IN_REDIRECTING_FACTORY_CONSTRUCTOR],
+   * See [CompileTimeErrorCode.ASSERT_IN_REDIRECTING_CONSTRUCTOR],
+   * [CompileTimeErrorCode.DEFAULT_VALUE_IN_REDIRECTING_FACTORY_CONSTRUCTOR],
    * [CompileTimeErrorCode.FIELD_INITIALIZER_REDIRECTING_CONSTRUCTOR],
    * [CompileTimeErrorCode.MULTIPLE_REDIRECTING_CONSTRUCTOR_INVOCATIONS],
    * [CompileTimeErrorCode.SUPER_IN_REDIRECTING_CONSTRUCTOR], and
@@ -4606,6 +4607,11 @@ class ErrorVerifier extends RecursiveAstVisitor<void> {
               CompileTimeErrorCode.FIELD_INITIALIZER_REDIRECTING_CONSTRUCTOR,
               initializer);
         }
+        if (initializer is AssertInitializer) {
+          _errorReporter.reportErrorForNode(
+              CompileTimeErrorCode.ASSERT_IN_REDIRECTING_CONSTRUCTOR,
+              initializer);
+        }
       }
     }
   }

pkg/analyzer/test/src/diagnostics/assert_in_redirecting_constructor_test.dart

@@ -0,0 +1,57 @@
+// Copyright (c) 2019, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import 'package:analyzer/src/error/codes.dart';
+import 'package:test_reflective_loader/test_reflective_loader.dart';
+
+import '../dart/resolution/driver_resolution.dart';
+
+main() {
+  defineReflectiveSuite(() {
+    defineReflectiveTests(AssertInRedirectingConstructorTest);
+  });
+}
+
+@reflectiveTest
+class AssertInRedirectingConstructorTest extends DriverResolutionTest {
+  test_assertBeforeRedirection() async {
+    await assertErrorsInCode(r'''
+class A {}
+class B {
+  B(int x) : assert(x > 0), this.name();
+  B.name() {}
+}
+''', [error(CompileTimeErrorCode.ASSERT_IN_REDIRECTING_CONSTRUCTOR, 34, 13)]);
+  }
+
+  test_redirectionBeforeAssert() async {
+    await assertErrorsInCode(r'''
+class A {}
+class B {
+  B(int x) : this.name(), assert(x > 0);
+  B.name() {}
+}
+''', [error(CompileTimeErrorCode.ASSERT_IN_REDIRECTING_CONSTRUCTOR, 47, 13)]);
+  }
+
+  test_justRedirection() async {
+    await assertNoErrorsInCode(r'''
+class A {}
+class B {
+  B(int x) : this.name();
+  B.name() {}
+}
+''');
+  }
+
+  test_justAssert() async {
+    await assertNoErrorsInCode(r'''
+class A {}
+class B {
+  B(int x) : assert(x > 0);
+  B.name() {}
+}
+''');
+  }
+}

pkg/analyzer/test/src/diagnostics/test_all.dart

@@ -10,6 +10,8 @@ import 'ambiguous_extension_member_access_test.dart'
 import 'ambiguous_import_test.dart' as ambiguous_import;
 import 'ambiguous_set_or_map_literal_test.dart' as ambiguous_set_or_map_literal;
 import 'argument_type_not_assignable_test.dart' as argument_type_not_assignable;
+import 'assert_in_redirecting_constructor_test.dart'
+    as assert_in_redirecting_constructor;
 import 'assignment_to_const_test.dart' as assignment_to_const;
 import 'assignment_to_final_local_test.dart' as assignment_to_final_local;
 import 'assignment_to_final_no_setter_test.dart'
@@ -338,6 +340,7 @@ main() {
     ambiguous_import.main();
     ambiguous_set_or_map_literal.main();
     argument_type_not_assignable.main();
+    assert_in_redirecting_constructor.main();
     assignment_to_const.main();
     assignment_to_final_local.main();
     assignment_to_final_no_setter.main();