Skip to content

Commit f6acefa

Browse files
karlklosecommit-bot@chromium.org
authored andcommitted
[infra] Ensure configuration names for custom test-runner steps are valid
Change-Id: I1bf57a3258aeb37f5fee485bde9a74a2ff3af8ba Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139803 Commit-Queue: Karl Klose <[email protected]> Reviewed-by: William Hesse <[email protected]>
1 parent 2eaa5bc commit f6acefa

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

tools/bots/test_matrix.json

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -475,6 +475,9 @@
475475
"builder-tag": "cfe"
476476
}
477477
},
478+
"flutter-frontend": {
479+
"__comment__": "This configuration is only used for a custom test runner. If it conflicts with a new configuration you are adding, you can make this configuration more specific by adding options."
480+
},
478481
"unittest-asserts-no-sdk-(linux|mac|win)": {
479482
"options": {
480483
"compiler": "dartk",
@@ -1042,7 +1045,7 @@
10421045
"testRunner": true,
10431046
"arguments": [
10441047
"pkg/front_end/test/unit_test_suites.dart",
1045-
"-ncfe-${system}-release-x64",
1048+
"-ncfe-unittest-asserts-${mode}-${system}",
10461049
"--verbose"
10471050
]
10481051
}
@@ -1937,7 +1940,7 @@
19371940
"testRunner": true,
19381941
"arguments": [
19391942
"pkg/dev_compiler/test/modular_suite.dart",
1940-
"-ndartdevk-${system}-release",
1943+
"-ndartdevk-checked-${system}-release-chrome",
19411944
"--verbose",
19421945
"--use-sdk"
19431946
]
@@ -2124,7 +2127,7 @@
21242127
"testRunner": true,
21252128
"arguments": [
21262129
"pkg/dev_compiler/test/modular_suite.dart",
2127-
"-ndartdevk-${system}-release",
2130+
"-ndartdevk-checked-mac-release-chrome",
21282131
"--verbose",
21292132
"--use-sdk"
21302133
]
@@ -2266,7 +2269,7 @@
22662269
"testRunner": true,
22672270
"arguments": [
22682271
"pkg/compiler/tool/modular_test_suite.dart",
2269-
"-ndart2js-${system}-release-d8",
2272+
"-nunittest-asserts-no-sdk-linux",
22702273
"--verbose",
22712274
"--use-sdk"
22722275
]

0 commit comments

Comments
 (0)