Skip to content

Commit fcbf534

Browse files
Clement Skaucommit-bot@chromium.org
Clement Skau
authored andcommitted
[SDK] Fixes crash in tools/run_abi_tests.py
logRecords is expected to be of type dict, but the fallback value was previously set to [] (type list). This CL changes the fallback values to an empty dict. It also uses the builtin dict.get() to handle to fallback instead of manually doing so. Note: This CL will not make the bot go green. It will change it from purple (infra failure due to crash) to red since there are tests that are legitimately failing. Bug: #42625 Cq-Include-Trybots: dart/try:vm-dartkb-linux-release-x64-abi-try Change-Id: I12ad7688719039566cd16e128997f0f8efc60a69 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153600 Commit-Queue: Clement Skau <[email protected]> Auto-Submit: Clement Skau <[email protected]> Reviewed-by: Daco Harkes <[email protected]>
1 parent 2e5e03f commit fcbf534

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tools/run_abi_tests.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ def diffAllResults(tests, flags):
195195
flags.configuration_name)
196196
resultFile.write(json.dumps(outResult) + '\n')
197197
if diffs:
198-
logRecords = allLogs[name] if name in allLogs else []
198+
logRecords = allLogs.get(name, {})
199199
logFile.write(
200200
json.dumps(
201201
makeLog(diffs, results, logRecords, flags.

0 commit comments

Comments
 (0)