Skip to content

Remove ElementList and NodeList #2712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DartBot opened this issue Apr 24, 2012 · 13 comments
Closed

Remove ElementList and NodeList #2712

DartBot opened this issue Apr 24, 2012 · 13 comments
Assignees
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures web-libraries Issues impacting dart:html, etc., libraries
Milestone

Comments

@DartBot
Copy link

DartBot commented Apr 24, 2012

This issue was originally filed by @seaneagan


In dart:html:

ElementList
NodeList

could be removed and references replaced with:

List<Element>
List<Node>

if the following are fixed:

issue #1062
issue #1790

@madsager
Copy link
Contributor

Added Area-DOM, Triaged labels.

@vsmenon
Copy link
Member

vsmenon commented Jul 16, 2012

Added this to the M1 milestone.

@vsmenon
Copy link
Member

vsmenon commented Jul 16, 2012

Set owner to @vsmenon.

@vsmenon
Copy link
Member

vsmenon commented Jul 17, 2012

Issue #4125 has been merged into this issue.

@sethladd
Copy link
Contributor

4125 was sort of a dupe. There's a distinct mismatch:

Document.queryAll : NodeList
Top level queryAll : ElementList

Is this distinction on purpose?

@vsmenon
Copy link
Member

vsmenon commented Jul 17, 2012

That's a mistake as well. Both should be statically typed to return List<Node>.

@sethladd
Copy link
Contributor

Removed Priority-Medium label.
Added Priority-High label.

@sethladd
Copy link
Contributor

Let's fix top level queryAll in the meantime. I'm not sure when the blocking issues for this bug will get fixed. Will that work?

@sethladd
Copy link
Contributor

Related is bug 3867

@iposva-google
Copy link
Contributor

Removed Area-DOM label.
Added Area-HTML label.

@vsmenon
Copy link
Member

vsmenon commented Aug 17, 2012

Removed the owner.

@blois
Copy link

blois commented Aug 29, 2012

Set owner to @blois.
Added Accepted label.

@blois
Copy link

blois commented Oct 3, 2012

Added Fixed label.

@DartBot DartBot added Type-Defect P1 A high priority bug; for example, a single project is unusable or has many test failures web-libraries Issues impacting dart:html, etc., libraries labels Oct 3, 2012
@DartBot DartBot added this to the M1 milestone Oct 3, 2012
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures web-libraries Issues impacting dart:html, etc., libraries
Projects
None yet
Development

No branches or pull requests

6 participants