-
Notifications
You must be signed in to change notification settings - Fork 1.7k
implement dart:mirrors #27268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The basic parts of this (i.e., the parts used by angular) are landed. This is still missing a lot of features - general method / function mirrors, parameter names, etc. |
Angular is now using parameter annotations as well (only for constructors). |
From @jmesserly on July 13, 2015 17:13
should be easy to implement now, given that we track parameter types? |
Yeah, we've already got code for class-level annotations too, mainly we just need to decide how we want to encode it. |
Angular is now using https://api.dartlang.org/1.13.0/dart-mirrors/DeclarationMirror/owner.html This will require us to embed a pointer in classes back to the containing library in generated code. |
Some more items required for Angular apps in mirrors mode:
All of these will require additional compile-time metadata. |
From @eernstg on April 20, 2016 8:58 I guess the intended workflow is such that 'reflectable' would not be helpful here, as long as it is running as a pub transformer? |
Yes, this is just a convenience to run Angular2 apps without transformation. |
From @srawlins on August 1, 2016 17:47 LibraryMirror.uri is important for some rare cases of unit testing: dart-lang/test#110 requires this to find assets for a test. |
Bumping and taking. We need some of this for testing support. |
@vsmenon I imagine you can close this? |
yup! closing this now that we have deprecation plan: #32294 |
From @vsmenon on May 27, 2015 18:28
Implement the dart:mirrors API. We should be able to map this to our dynamic invocation code / metadata.
Copied from original issue: dart-archive/dev_compiler#199
The text was updated successfully, but these errors were encountered: