Skip to content

support covariant parameter overrides in AST-based summaries #27298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jmesserly opened this issue Sep 12, 2016 · 0 comments
Closed

support covariant parameter overrides in AST-based summaries #27298

jmesserly opened this issue Sep 12, 2016 · 0 comments
Assignees
Labels
legacy-area-analyzer Use area-devexp instead. P2 A bug or feature request we're likely to work on

Comments

@jmesserly
Copy link

I'm about to send support for @covariant on parameters, which fixes #25578. In the process @stereotype441 helped me get things passing with summaries, however there is a bug, quoting Paul:

The bug they will see while they wait for my fix will be that if they inherit from a class in another package that in turn inherits from a class that declares a parameter as @covariant, the covariant-ness won't get properly passed through (because the intermediate class didn't record inheritsCovariant properly).

We think we can live with that for about a week or so, but filing this bug to track it.

For context, the initial CL for @covariant is https://codereview.chromium.org/2336503003.

@jmesserly jmesserly added legacy-area-analyzer Use area-devexp instead. analyzer-strong-mode P2 A bug or feature request we're likely to work on labels Sep 12, 2016
@stereotype441 stereotype441 self-assigned this Sep 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
legacy-area-analyzer Use area-devexp instead. P2 A bug or feature request we're likely to work on
Projects
None yet
Development

No branches or pull requests

2 participants