Skip to content

Please merge 4482d13ff75dadc68df64758a35976c5cbeadbc6 into dev channel #34021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aartbik opened this issue Jul 28, 2018 · 0 comments
Closed

Please merge 4482d13ff75dadc68df64758a35976c5cbeadbc6 into dev channel #34021

aartbik opened this issue Jul 28, 2018 · 0 comments

Comments

@aartbik
Copy link
Contributor

aartbik commented Jul 28, 2018

commit(s) to merge: 4482d13

merge instructions: clean merge or patch CL

reason: a sentence or two.

Without this fix, Dart VM will crash itself with floating-point exception (i.e. C++ crash, not Dart crash) for reasonable inputs of % operator.

Expect.equals(0, mod(minInt64, -1));
Expect.equals(minInt64, truncdiv(minInt64, -1));

More details at:

#33967

/cc @dgrove @kevmoo @mit-mit @whesse @athomas @a-siva @alexmarkov

@vsmenon vsmenon modified the milestone: Dart2Stable Jul 30, 2018
@athomas athomas closed this as completed Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants