Skip to content

Kernel need way to specify what other kernel files it requires to load #36032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jensjoha opened this issue Feb 26, 2019 · 7 comments
Closed
Labels
front-end-kernel legacy-area-front-end Legacy: Use area-dart-model instead. P1 A high priority bug; for example, a single project is unusable or has many test failures
Milestone

Comments

@jensjoha
Copy link
Contributor

E.g. #35866 is likely caused by a mis-match between the expected and actual platform loaded.
If the dill file knew - for instance - a checksum of the platform it assumed, we could check that the expected and actual platform was the same and discard if it isn't.

@a-siva
Copy link
Contributor

a-siva commented May 24, 2019

issue #37043 and all the issues marked as duplicate in that issue seem to be related. Considering the number of times we seem to have run into this issue I am marking this as p1-high

@dgrove
Copy link
Contributor

dgrove commented May 28, 2019

@kmillikin - can you please take a look, as this is happening frequently on version upgrades?

@dgrove
Copy link
Contributor

dgrove commented Jun 5, 2019

The plan is to suppress this warning for D24 - CL is out here: https://dart-review.googlesource.com/c/sdk/+/104825

@jensjoha
Copy link
Contributor Author

jensjoha commented Jun 6, 2019

Temporary fix landed as 5eff2a0.

@kmillikin
Copy link

The warning should be disabled for compiling against an app that includes an outdated platform. Somehow fixing the underlying issue is getting moved to the next Dart release.

@johnniwinther
Copy link
Member

@jensjoha Is there more work left here?

@jensjoha
Copy link
Contributor Author

jensjoha commented Aug 5, 2020

Well, it haven't exactly been fixed with a list of checksums for other required dills, but for the platform specifically it should have been fixed with #41802 --- let's say that's good enough.

@jensjoha jensjoha closed this as completed Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end-kernel legacy-area-front-end Legacy: Use area-dart-model instead. P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Development

No branches or pull requests

7 participants