Skip to content

[Analysis Server] Support for LSP semantic tokens #42036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ericdallo opened this issue May 24, 2020 · 3 comments
Closed

[Analysis Server] Support for LSP semantic tokens #42036

ericdallo opened this issue May 24, 2020 · 3 comments
Labels
devexp-lsp Issues with analysis server's support of Language Server Protocol devexp-server Issues related to some aspect of the analysis server legacy-area-analyzer Use area-devexp instead.

Comments

@ericdallo
Copy link
Contributor

As discussed here and here there're some languages with support for the new semantic tokens protocol from LSP, which may come on LSP 3.16.
Here is the protocol definition.

Is it possible to add support for that?

Once implemented, we can start using on lsp-dart for Emacs and in the future, on VScode (c/c @DanTup).

@DanTup
Copy link
Collaborator

DanTup commented May 25, 2020

This is something on my radar - the current syntax highlighting in VS Code (powered by a TextMate grammar) has some issues so I'd like to move over to server-supplied highlighting (and the plan is for VS Code to switch over to LSP).

I don't expect to start looking at it until after the spec is finalised and supported by the vscode language server client though (to avoid reworking things if the spec evolves).

@mkustermann mkustermann added devexp-server Issues related to some aspect of the analysis server legacy-area-analyzer Use area-devexp instead. labels May 26, 2020
@devoncarew devoncarew added the devexp-lsp Issues with analysis server's support of Language Server Protocol label Jul 31, 2020
@DanTup
Copy link
Collaborator

DanTup commented Jan 13, 2021

Semantic tokens are available in the latest Dart/Flutter code (probably nightlies/master right now, though probably in dev soon too) - anything after 28523a5 should have them (though there have continued to be some improvements since then).

If you find any issues, please do file bugs here and CC me.

(@ericdallo I can't close issues here, so if you're happy with this please do that for me too :-))

@ericdallo
Copy link
Contributor Author

Thank you @DanTup! I'll test it soon and let you know ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devexp-lsp Issues with analysis server's support of Language Server Protocol devexp-server Issues related to some aspect of the analysis server legacy-area-analyzer Use area-devexp instead.
Projects
None yet
Development

No branches or pull requests

4 participants